From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bernard.iremonger@intel.com> Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B5D7A5B2E for <dev@dpdk.org>; Wed, 24 Oct 2018 17:38:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2018 08:38:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,420,1534834800"; d="scan'208";a="102930357" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga002.jf.intel.com with ESMTP; 24 Oct 2018 08:38:53 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by IRSMSX102.ger.corp.intel.com ([169.254.2.67]) with mapi id 14.03.0319.002; Wed, 24 Oct 2018 16:38:52 +0100 From: "Iremonger, Bernard" <bernard.iremonger@intel.com> To: Thomas Monjalon <thomas@monjalon.net>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "ophirmu@mellanox.com" <ophirmu@mellanox.com>, "wisamm@mellanox.com" <wisamm@mellanox.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com> Thread-Topic: [PATCH 1/5] app/testpmd: check not detaching device twice Thread-Index: AQHUa59Cw8EPuCg66kW1WXdCIllol6Uuh8Gg Date: Wed, 24 Oct 2018 15:38:51 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D16F83@IRSMSX107.ger.corp.intel.com> References: <20181024134111.26771-1-thomas@monjalon.net> <20181024134111.26771-2-thomas@monjalon.net> In-Reply-To: <20181024134111.26771-2-thomas@monjalon.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2YxMWRlZGUtZjM5ZC00MzA2LWE1YTYtZjRkZmE0NjNiMjA4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiV3Jjc09YY0lhV3VtOHRnRlwvcnJvcWNxdUpINUVWYzBsQWw0Q2FkNXNZb29rZkhcL25uUmFWUVExU3R3QXBFRitXIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/5] app/testpmd: check not detaching device twice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 24 Oct 2018 15:38:56 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, October 24, 2018 2:41 PM > To: Iremonger, Bernard <bernard.iremonger@intel.com>; Wu, Jingjing > <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com> > Cc: dev@dpdk.org; ophirmu@mellanox.com; wisamm@mellanox.com; Yigit, > Ferruh <ferruh.yigit@intel.com>; arybchenko@solarflare.com > Subject: [PATCH 1/5] app/testpmd: check not detaching device twice >=20 > The command "port detach" is removing the EAL rte_device of the ethdev po= rt > specified as parameter. > The function name and some comments are updated to make clear that we are > detaching the whole device. >=20 > After detaching, the pointer, which maps a port to its device, is reset. = This way, > it is possible to check whether a port is still associated to a (not remo= ved) > device. >=20 > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>