Re: [dpdk-dev] [PATCH] app/testpmd: fix Rx offload search error

["Iremonger, Bernard" <bernard.iremonger@intel.com>]

Hi Wei,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Peng, Yuan
> Sent: Wednesday, November 7, 2018 7:58 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix Rx offload search error
> 
> Tested-by: Peng, Yuan <yuan.peng@intel.com>

./devtools/check-git-log.sh -1
Wrong tag:
        Tested-by: Peng, Yuan <yuan.peng@intel.com>

Checkpatches.pl is detecting a duplicate signoff
### app/testpmd: fix Rx offload search error

WARNING:BAD_SIGN_OFF: Duplicate signature
#26: 
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

<snip>

> Subject: [PATCH] app/testpmd: fix Rx offload search error
> 
> There is an error in function in function search_rx_offload(), it will break when
> get unexpected return value from function rte_eth_dev_rx_offload_name(), but
> rte_eth_dev_rx_offload_name() will return some unexpected value indead.
> 
> Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API")
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>  app/test-pmd/cmdline.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> 5e08a1b..1275074 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -17805,10 +17805,7 @@ search_rx_offload(const char *name)
>  		if (!strcasecmp(single_name, name)) {
>  			found = 1;
>  			break;
> -		} else if (!strcasecmp(single_name, "UNKNOWN"))
> -			break;
> -		else if (single_name == NULL)
> -			break;
> +		}
>  		single_offload <<= 1;
>  	}
> 
> --
> 2.7.5

Regards,

Bernard.