From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3722B2862; Wed, 7 Nov 2018 18:09:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2018 09:09:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,476,1534834800"; d="scan'208";a="106268246" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga001.jf.intel.com with ESMTP; 07 Nov 2018 09:09:51 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.101]) by IRSMSX102.ger.corp.intel.com ([169.254.2.13]) with mapi id 14.03.0415.000; Wed, 7 Nov 2018 17:09:51 +0000 From: "Iremonger, Bernard" To: "Peng, Yuan" , "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Lu, Wenzhuo" Thread-Topic: [PATCH] app/testpmd: fix Rx offload search error Thread-Index: AQHUdm+9qzHazr5uokOTyEhwdYDUOqVEiyxA Date: Wed, 7 Nov 2018 17:09:50 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D24882@IRSMSX108.ger.corp.intel.com> References: <1541571269-6133-1-git-send-email-wei.zhao1@intel.com> <67D543A150B29E4CAAE53918F64EDAEA376471EF@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <67D543A150B29E4CAAE53918F64EDAEA376471EF@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDMzODllMTktYzEyZC00ZTQ4LWEwYWItZmM3YThmMmUxMjM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWUpwdmRPbzljRWJtWE5oRGJzdUxYRXZWZytxQTN1K3pOZ2k5Y1diOTZMbHJsV0ZyRHpiUmhcL1ZqUWhIZ0trY3AifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix Rx offload search error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 17:09:55 -0000 Hi Wei, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Peng, Yuan > Sent: Wednesday, November 7, 2018 7:58 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: stable@dpdk.org; Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix Rx offload search error >=20 > Tested-by: Peng, Yuan ./devtools/check-git-log.sh -1 Wrong tag: Tested-by: Peng, Yuan Checkpatches.pl is detecting a duplicate signoff ### app/testpmd: fix Rx offload search error WARNING:BAD_SIGN_OFF: Duplicate signature #26:=20 Signed-off-by: Wei Zhao > Subject: [PATCH] app/testpmd: fix Rx offload search error >=20 > There is an error in function in function search_rx_offload(), it will br= eak when > get unexpected return value from function rte_eth_dev_rx_offload_name(), = but > rte_eth_dev_rx_offload_name() will return some unexpected value indead. >=20 > Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") > Signed-off-by: Wei Zhao > --- > app/test-pmd/cmdline.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 5e08a1b..1275074 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -17805,10 +17805,7 @@ search_rx_offload(const char *name) > if (!strcasecmp(single_name, name)) { > found =3D 1; > break; > - } else if (!strcasecmp(single_name, "UNKNOWN")) > - break; > - else if (single_name =3D=3D NULL) > - break; > + } > single_offload <<=3D 1; > } >=20 > -- > 2.7.5 Regards, Bernard.