From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D401F4C9F for ; Tue, 15 Jan 2019 13:34:07 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2019 04:34:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,481,1539673200"; d="scan'208";a="106743952" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga007.jf.intel.com with ESMTP; 15 Jan 2019 04:34:05 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.205]) by IRSMSX101.ger.corp.intel.com ([169.254.1.213]) with mapi id 14.03.0415.000; Tue, 15 Jan 2019 12:34:05 +0000 From: "Iremonger, Bernard" To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: "Iremonger, Bernard" Thread-Topic: [PATCH] test/ipsec: fix test suite setup function Thread-Index: AQHUrMRN9oocfroEVE6xehvRY826pqWwOPqAgAABXvA= Date: Tue, 15 Jan 2019 12:34:04 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D4ECBD@IRSMSX108.ger.corp.intel.com> References: <1547551191-28863-1-git-send-email-bernard.iremonger@intel.com> <2601191342CEEE43887BDE71AB977258010D90422F@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258010D90422F@irsmsx105.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjFhNjIyMWMtNDBkYS00YWNjLWI2OTEtZTNmNzE1YTZmNzgyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYnJVeXBMNXVWRjQ3Mmp5UGpkd3d1YSt3QU9EVmpOclpad3RCS3EyK1dLcjZEYUthYitSQlR6MFpmelM4Y05hNCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test/ipsec: fix test suite setup function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 12:34:08 -0000 Hi Konstantin > > Subject: [PATCH] test/ipsec: fix test suite setup function > > > > Check for valid crypto_null devices before continuing. > > > > Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") > > Signed-off-by: Bernard Iremonger > > --- > > test/test/test_ipsec.c | 17 +++++++++++++++-- > > 1 file changed, 15 insertions(+), 2 deletions(-) > > > > diff --git a/test/test/test_ipsec.c b/test/test/test_ipsec.c index > > ff1a1c4..4dfc55b 100644 > > --- a/test/test/test_ipsec.c > > +++ b/test/test/test_ipsec.c > > @@ -46,6 +46,8 @@ > > #define BURST_SIZE 32 > > #define REORDER_PKTS 1 > > > > +static int gbl_driver_id; > > + >=20 > Why do you need that global here? test_ipsec.c is based on test_cryptodev.c. gbl_driver_id used to store the ID of the required driver. >=20 > > struct user_params { > > enum rte_crypto_sym_xform_type auth; > > enum rte_crypto_sym_xform_type cipher; @@ -218,7 +220,7 @@ > > testsuite_setup(void) { > > struct ipsec_testsuite_params *ts_params =3D &testsuite_params; > > struct rte_cryptodev_info info; > > - uint32_t nb_devs, dev_id; > > + uint32_t i, nb_devs, dev_id; > > size_t sess_sz; > > > > memset(ts_params, 0, sizeof(*ts_params)); @@ -251,7 +253,18 @@ > > testsuite_setup(void) > > return TEST_FAILED; > > } > > > > - ts_params->valid_devs[ts_params->valid_dev_count++] =3D 0; > > + gbl_driver_id =3D rte_cryptodev_driver_id_get( > > + RTE_STR(CRYPTODEV_NAME_NULL_PMD)); These tests only work with the crypto_null PMD's, gbl_driver_id is set to= the crypto_null PMD id here. > > + > > + /* Create list of valid crypto devs */ > > + for (i =3D 0; i < nb_devs; i++) { > > + rte_cryptodev_info_get(i, &info); > > + if (info.driver_id =3D=3D gbl_driver_id) > > + ts_params->valid_devs[ts_params->valid_dev_count++] > =3D i; > > + } >=20 > I think you need to check driver capabilities, instead of relying on driv= er name. I don't think it is necessary to check the driver capabilities. This is how it is done in test_cryptodev.c. I think it makes sense to mirror the test_cryptodev.c implementation.=20 =20 > > + > > + if (ts_params->valid_dev_count < 1) > > + return TEST_FAILED; > > > > /* Set up all the qps on the first of the valid devices found */ > > dev_id =3D ts_params->valid_devs[0]; >=20 > If we always use just valid_dev[0] to determine private session size, why= do you > keep going though all devs in the loop above? There may be several crypto devs present for example, crypto_aesni_mb0, cry= pto_aseni_mb1, crypto_null0 and crypto_null1. The valid_dev[] array will contain all devs of the requested type, in this = case crypto_null0 and crypto_null1. > Another thing, as I mentioned off-line - later you still use all vald_dev= s[] to init > session: > s =3D rte_cryptodev_sym_session_create(qp->mp_session); > if (s =3D=3D NULL) > return -ENOMEM; >=20 > /* initiliaze SA crypto session for all supported devices */ > for (i =3D 0; i !=3D devnum; i++) { > rc =3D rte_cryptodev_sym_session_init(devid[i], s, > ut->crypto_xforms, qp->mp_session_private); > if (rc !=3D 0) > break; > } >=20 > I think we need either to determine max private session size based on *al= l* > valid_devs[], or just use one device that can do NULL algorithm. The valid_devs[] array only contains crypto_null PMD's=20 The code is using the crypto_null PMD only.=20 > As we always enqueue/dequeuer into valid_devs[0] - I think there is no po= int to > have an arrays here, just single valid_dev should be sufficient. The test program may be started with several crypto_dev PMD's for example: test -c f -n 4 --vdev crypto_aesni_mb0 --vdev crypto_null0 --vdev crypto_ae= sni_mb1 --vdev crypto_dev_null1 In this case the valid_devs[] array will contain crypto_dev_null0 and crypt= o_dev_null1. > Konstantin >=20 >=20 Regards, Bernard.