From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 176312B95 for ; Mon, 8 Apr 2019 15:07:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 06:07:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,325,1549958400"; d="scan'208";a="159728688" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga004.fm.intel.com with ESMTP; 08 Apr 2019 06:07:34 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.82]) by irsmsx105.ger.corp.intel.com ([169.254.7.31]) with mapi id 14.03.0415.000; Mon, 8 Apr 2019 14:07:34 +0100 From: "Iremonger, Bernard" To: Stephen Hemminger , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 addresses Thread-Index: AQHU6ZQ1++cOM66EikueIO7rBeH2HqYyREbw Date: Mon, 8 Apr 2019 13:07:33 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D8555E@IRSMSX108.ger.corp.intel.com> References: <20180618213557.15209-2-stephen@networkplumber.org> <20190402203907.28679-1-stephen@networkplumber.org> <20190402203907.28679-3-stephen@networkplumber.org> In-Reply-To: <20190402203907.28679-3-stephen@networkplumber.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTVmNmRiODMtZGViMy00Njk3LTkxMjgtYTBhMDAzYzcyNDQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWnR1K3NLVExzVFBmZ3hKQUhXOFlEQlpFSXNycWhmSk1obnV2ZXN1emRqN2RuclVYXC8raEc4eElUNVRHU1BQc3kifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2019 13:07:37 -0000 Hi Stephen, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, April 2, 2019 9:39 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 > addresses >=20 > The l3fwd example should use the IPv4 addresses defined in RFC5735 and th= e > IPv6 addresses defined in RFC5180 for the L3 forwarding example Longest P= refix > Match table. There should probably be a fixes line. Also the commit line should have the "fix" keyword.=20 >=20 > Signed-off-by: Stephen Hemminger > --- > v4 - fix IPv6 /48 entries >=20 > examples/l3fwd/l3fwd_lpm.c | 34 ++++++++++++++++++---------------- > 1 file changed, 18 insertions(+), 16 deletions(-) >=20 > diff --git a/examples/l3fwd/l3fwd_lpm.c b/examples/l3fwd/l3fwd_lpm.c inde= x > b1dc195ad8cb..3191fc4c2639 100644 > --- a/examples/l3fwd/l3fwd_lpm.c > +++ b/examples/l3fwd/l3fwd_lpm.c > @@ -39,26 +39,28 @@ struct ipv6_l3fwd_lpm_route { > uint8_t if_out; > }; >=20 > +/* 192.18.0.0/16 are set aside for RFC2544 benchmarking. */ > static struct ipv4_l3fwd_lpm_route ipv4_l3fwd_lpm_route_array[] =3D { > - {IPv4(1, 1, 1, 0), 24, 0}, > - {IPv4(2, 1, 1, 0), 24, 1}, > - {IPv4(3, 1, 1, 0), 24, 2}, > - {IPv4(4, 1, 1, 0), 24, 3}, > - {IPv4(5, 1, 1, 0), 24, 4}, > - {IPv4(6, 1, 1, 0), 24, 5}, > - {IPv4(7, 1, 1, 0), 24, 6}, > - {IPv4(8, 1, 1, 0), 24, 7}, > + {IPv4(192, 18, 0, 0), 24, 0}, > + {IPv4(192, 18, 1, 0), 24, 1}, > + {IPv4(192, 18, 2, 0), 24, 2}, > + {IPv4(192, 18, 3, 0), 24, 3}, > + {IPv4(192, 18, 4, 0), 24, 4}, > + {IPv4(192, 18, 5, 0), 24, 5}, > + {IPv4(192, 18, 6, 0), 24, 6}, > + {IPv4(192, 18, 7, 0), 24, 7}, > }; >=20 > +/* 2001:0200::/48 is IANA reserved range for IPv6 benchmarking > +(RFC5180) */ > static struct ipv6_l3fwd_lpm_route ipv6_l3fwd_lpm_route_array[] =3D { > - {{1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 0}, > - {{2, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 1}, > - {{3, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 2}, > - {{4, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 3}, > - {{5, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 4}, > - {{6, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 5}, > - {{7, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 6}, > - {{8, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 7}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, 48, 0}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0}, 48, 1}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0}, 48, 2}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0}, 48, 3}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 4, 0, 0, 0, 0, 0, 0}, 48, 4}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0}, 48, 5}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0}, 48, 6}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0}, 48, 7}, > }; >=20 > #define IPV4_L3FWD_LPM_NUM_ROUTES \ > -- > 2.17.1 Regards, Bernard. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3C20BA0096 for ; Mon, 8 Apr 2019 15:07:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8D6C2BCE; Mon, 8 Apr 2019 15:07:38 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 176312B95 for ; Mon, 8 Apr 2019 15:07:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 06:07:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,325,1549958400"; d="scan'208";a="159728688" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga004.fm.intel.com with ESMTP; 08 Apr 2019 06:07:34 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.82]) by irsmsx105.ger.corp.intel.com ([169.254.7.31]) with mapi id 14.03.0415.000; Mon, 8 Apr 2019 14:07:34 +0100 From: "Iremonger, Bernard" To: Stephen Hemminger , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 addresses Thread-Index: AQHU6ZQ1++cOM66EikueIO7rBeH2HqYyREbw Date: Mon, 8 Apr 2019 13:07:33 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D8555E@IRSMSX108.ger.corp.intel.com> References: <20180618213557.15209-2-stephen@networkplumber.org> <20190402203907.28679-1-stephen@networkplumber.org> <20190402203907.28679-3-stephen@networkplumber.org> In-Reply-To: <20190402203907.28679-3-stephen@networkplumber.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTVmNmRiODMtZGViMy00Njk3LTkxMjgtYTBhMDAzYzcyNDQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWnR1K3NLVExzVFBmZ3hKQUhXOFlEQlpFSXNycWhmSk1obnV2ZXN1emRqN2RuclVYXC8raEc4eElUNVRHU1BQc3kifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190408130733.3KuA1PXFUf0f7-gNtEUyWIc6sTeIByANQ1DJx5rzWVM@z> Hi Stephen, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, April 2, 2019 9:39 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 > addresses >=20 > The l3fwd example should use the IPv4 addresses defined in RFC5735 and th= e > IPv6 addresses defined in RFC5180 for the L3 forwarding example Longest P= refix > Match table. There should probably be a fixes line. Also the commit line should have the "fix" keyword.=20 >=20 > Signed-off-by: Stephen Hemminger > --- > v4 - fix IPv6 /48 entries >=20 > examples/l3fwd/l3fwd_lpm.c | 34 ++++++++++++++++++---------------- > 1 file changed, 18 insertions(+), 16 deletions(-) >=20 > diff --git a/examples/l3fwd/l3fwd_lpm.c b/examples/l3fwd/l3fwd_lpm.c inde= x > b1dc195ad8cb..3191fc4c2639 100644 > --- a/examples/l3fwd/l3fwd_lpm.c > +++ b/examples/l3fwd/l3fwd_lpm.c > @@ -39,26 +39,28 @@ struct ipv6_l3fwd_lpm_route { > uint8_t if_out; > }; >=20 > +/* 192.18.0.0/16 are set aside for RFC2544 benchmarking. */ > static struct ipv4_l3fwd_lpm_route ipv4_l3fwd_lpm_route_array[] =3D { > - {IPv4(1, 1, 1, 0), 24, 0}, > - {IPv4(2, 1, 1, 0), 24, 1}, > - {IPv4(3, 1, 1, 0), 24, 2}, > - {IPv4(4, 1, 1, 0), 24, 3}, > - {IPv4(5, 1, 1, 0), 24, 4}, > - {IPv4(6, 1, 1, 0), 24, 5}, > - {IPv4(7, 1, 1, 0), 24, 6}, > - {IPv4(8, 1, 1, 0), 24, 7}, > + {IPv4(192, 18, 0, 0), 24, 0}, > + {IPv4(192, 18, 1, 0), 24, 1}, > + {IPv4(192, 18, 2, 0), 24, 2}, > + {IPv4(192, 18, 3, 0), 24, 3}, > + {IPv4(192, 18, 4, 0), 24, 4}, > + {IPv4(192, 18, 5, 0), 24, 5}, > + {IPv4(192, 18, 6, 0), 24, 6}, > + {IPv4(192, 18, 7, 0), 24, 7}, > }; >=20 > +/* 2001:0200::/48 is IANA reserved range for IPv6 benchmarking > +(RFC5180) */ > static struct ipv6_l3fwd_lpm_route ipv6_l3fwd_lpm_route_array[] =3D { > - {{1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 0}, > - {{2, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 1}, > - {{3, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 2}, > - {{4, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 3}, > - {{5, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 4}, > - {{6, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 5}, > - {{7, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 6}, > - {{8, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}, 48, 7}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, 48, 0}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0}, 48, 1}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0}, 48, 2}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0}, 48, 3}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 4, 0, 0, 0, 0, 0, 0}, 48, 4}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0}, 48, 5}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0}, 48, 6}, > + {{32, 1, 2, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0}, 48, 7}, > }; >=20 > #define IPV4_L3FWD_LPM_NUM_ROUTES \ > -- > 2.17.1 Regards, Bernard.