From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4C506A0096 for ; Fri, 7 Jun 2019 15:59:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA0391BC0F; Fri, 7 Jun 2019 15:59:20 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1809E1BB37; Fri, 7 Jun 2019 15:59:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jun 2019 06:59:17 -0700 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga001.fm.intel.com with ESMTP; 07 Jun 2019 06:59:17 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.121]) by IRSMSX101.ger.corp.intel.com ([169.254.1.80]) with mapi id 14.03.0415.000; Fri, 7 Jun 2019 14:59:16 +0100 From: "Iremonger, Bernard" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Peng, Yuan" , "Yigit, Ferruh" , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec Thread-Index: AQHVCTxYj4zN0v8IZUyxUboqiDbkXqaQXbng Date: Fri, 7 Jun 2019 13:59:15 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260DAD471@IRSMSX108.ger.corp.intel.com> References: <1557386426-57149-1-git-send-email-wei.zhao1@intel.com> <1557477677-54876-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTA3NzQ5MjctNjEzYS00ZWU0LTgxNGYtOGYwNmZiNDNjZGNlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS0tlaUx6OURZMEJ1MlwvU3JGZENXaDY2YmVSSWU1cDIxR1hDTDd1SWttWDlWZ2tMamJXTko3SzV1YlhZQ1NHMEIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Wei, > > Subject: [PATCH v2] app/testpmd: remove port stop check for macsec > > > > There is no need to do such a check when set macsec for ixgbe, > > reconfig_device_queueand is also useless. If we do not delete this Typo: space missing before "and" in previous line. > > unnessary code, users have to sotp port before enable or disable Typo: "sotp" should be "stop" > > macsec, then restart this port after make configuration. All these Typo: "these" should be "this" > > process is useless. As this cmdline is a private API which is only used= by ixgbe > NIC, so remove it. > > > > Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wei Zhao Otherwise Acked-by: Bernard Iremonger