DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [RFC] app/testpmd: add profiling for Rx/Tx burst routines
Date: Thu, 20 Jun 2019 15:15:05 +0000	[thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260DBA635@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <AM4PR05MB32651491F4B46F7F4FED6608D2130@AM4PR05MB3265.eurprd05.prod.outlook.com>

Hi  Slava,


> -----Original Message-----
> From: Slava Ovsiienko [mailto:viacheslavo@mellanox.com]
> Sent: Monday, June 10, 2019 5:40 AM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: RE: [dpdk-dev] [RFC] app/testpmd: add profiling for Rx/Tx burst
> routines
> 
<snip>

> > >  static void
> > > diff --git a/config/common_base b/config/common_base index
> > > 6b96e0e..6e84af4 100644
> > > --- a/config/common_base
> > > +++ b/config/common_base
> > > @@ -998,6 +998,8 @@ CONFIG_RTE_PROC_INFO=n  #
> > CONFIG_RTE_TEST_PMD=y
> > > CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES=n
> > > +CONFIG_RTE_TEST_PMD_RECORD_CORE_RX_CYCLES=n
> > > +CONFIG_RTE_TEST_PMD_RECORD_CORE_TX_CYCLES=n
> > >  CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS=n
> >
> > Should the RECORD macros be documented in the run_app.rst file ?

You missed the above comment in your reply.
There seems to be no documentation on the RECORD macros at present, there probably should be some.

Regards,

Bernard.



  reply	other threads:[~2019-06-20 15:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27  5:47 Viacheslav Ovsiienko
2019-06-07 16:07 ` Iremonger, Bernard
2019-06-10  4:39   ` Slava Ovsiienko
2019-06-20 15:15     ` Iremonger, Bernard [this message]
2019-06-24  4:03       ` Slava Ovsiienko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CEF83825BEC744B83065625E567D7C260DBA635@IRSMSX108.ger.corp.intel.com \
    --to=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).