From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FB63A0487 for ; Wed, 3 Jul 2019 12:30:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6020C5689; Wed, 3 Jul 2019 12:30:13 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 0EED45680; Wed, 3 Jul 2019 12:30:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2019 03:30:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,446,1557212400"; d="scan'208";a="165942738" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga007.fm.intel.com with ESMTP; 03 Jul 2019 03:30:08 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.46]) by IRSMSX152.ger.corp.intel.com ([169.254.6.79]) with mapi id 14.03.0439.000; Wed, 3 Jul 2019 11:30:08 +0100 From: "Iremonger, Bernard" To: Akhil Goyal , "Ananyev, Konstantin" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v6 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto Thread-Index: AQHVIS5toZxp/+I0hUaF5UkhVK8CcKaZdXeAgB9E9ICAABH1oP//8buAgAATBHA= Date: Wed, 3 Jul 2019 10:30:07 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260DC12DA@IRSMSX108.ger.corp.intel.com> References: <1559819547-20742-1-git-send-email-bernard.iremonger@intel.com> <1560351121-21234-2-git-send-email-bernard.iremonger@intel.com> <2601191342CEEE43887BDE71AB97725801688E4E2C@IRSMSX104.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C260DC128E@IRSMSX108.ger.corp.intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2JmZDBkOTItODk1ZS00ZGE2LTlkY2ItNWMyMTM5YzNhYzZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicjhrQlR2Y2crZW8xeXU1dTBLQjJzUk5vb05YVk0zeGxTRmRaOFdlU2d4eHhZUVVpVm1XV3hUbVBtNktnVDZJeiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Wednesday, July 3, 2019 11:18 AM > To: Iremonger, Bernard ; Ananyev, > Konstantin ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH v6 1/2] examples/ipsec-secgw: fix 1st pkt dropped for > inline crypto >=20 >=20 >=20 > > > > Hi Akhil, > > > > > > > > Hi Bernard, > > > > > > > > > > > > > Inline crypto installs a flow rule in the NIC. This flow rule > > > > > must be installed before the first inbound packet is received. > > > > > > > > > > The create_session() function installs the flow rule, > > > > > create_session() has been refactored into > > > > > create_inline_session() and create_lookaside_session(). The > > > > > create_inline_session() function uses the socket_ctx data and is > > > > > now called at initialisation in sa_add_rules(). > > > > > > > > > > The max_session_size() function has been added to calculate > > > > > memory requirements. > > > > > > > > > > The cryprodev_init() function has been refactored to drop calls > > > > > to > > > > > rte_mempool_create() and to drop calculation of memory > requirements. > > > > > > > > > > The main() function has been refactored to call > > > > > max_session_size() and to call session_pool_init() and > session_priv_pool_init() earlier. > > > > > The ports are started now before adding a flow rule in main(). > > > > > The sa_init(), sp4_init(), sp6_init() and rt_init() functions > > > > > are now called after the ports have been started. > > > > > > > > > > The rte_ipsec_session_prepare() function is called in > > > > > fill_ipsec_session() for inline which is called from the > > > > > ipsec_sa_init() > > > function. > > > > > > > > > > Fixes: ec17993a145a ("examples/ipsec-secgw: support security > > > > > offload") > > > > > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample > > > > > application") > > > > > Cc: stable@dpdk.org > > > > > > > > > > Signed-off-by: Bernard Iremonger > > > > > --- > > > > > > > > Acked-by: Konstantin Ananyev > > > > Tested-by: Konstantin Ananyev > > > > > > > > > > This patch need to be rebased. > > > > > > However, I will try to work on your v5 in next few days if I get > > > time. If I don't get time to fix that, will need you to send a rebase= d > version of this patch. > > > > > > Thanks, > > > Akhil > > > > > > > v6 is the latest version > > I will send a v7 rebased on 19.08.rc1 >=20 > I was talking about your previous which was for both lookaside and inline > cases to create sessions at init time. > If I get time, I will fix that or will ask you to rebase this one. > > > > Regards, > > > > Bernard > > They previous one was v4, where we could not test the lookaside code. Should I rebase the v4 and send as v7? Regards, Bernard.