From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EDD6CA00E6 for ; Fri, 12 Jul 2019 15:33:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 456111B9C6; Fri, 12 Jul 2019 15:33:53 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4E5622C6A; Fri, 12 Jul 2019 15:33:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2019 06:33:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,482,1557212400"; d="scan'208";a="171555554" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga006.jf.intel.com with ESMTP; 12 Jul 2019 06:33:48 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 12 Jul 2019 14:33:47 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.229]) by irsmsx111.ger.corp.intel.com ([169.254.2.65]) with mapi id 14.03.0439.000; Fri, 12 Jul 2019 14:33:46 +0100 From: "Iremonger, Bernard" To: "Mcloughlin, Aideen" , "Lu, Wenzhuo" , "Wu, Jingjing" CC: "dev@dpdk.org" , "david.marchand@redhat.com" , "stable@dpdk.org" Thread-Topic: [PATCH] app/testpmd: fix doubling of 'total TX dropped' Thread-Index: AQHVOIxy/t3XXJweF06Tdvcc8mpxK6bG+uPA Date: Fri, 12 Jul 2019 13:33:46 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260DCF8E5@IRSMSX108.ger.corp.intel.com> References: <20190712083221.4987-1-aideen.mcloughlin@intel.com> In-Reply-To: <20190712083221.4987-1-aideen.mcloughlin@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWE0MTI5ZWMtMTYxOC00ZGM4LTkxNDEtNDNmYTM5NTNhNWYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibUh5Tmp2c0s4YzJkRTI2QitzUEtYN0g1ajJFdDV5Y3hXMDE1djlsQTF0QmJOZUJJQytSVTdiWWFsSCtBQXdvSCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix doubling of 'total TX dropped' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Aideen, > -----Original Message----- > From: Mcloughlin, Aideen > Sent: Friday, July 12, 2019 9:32 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; Mcloughlin, Aideen ; > david.marchand@redhat.com; stable@dpdk.org > Subject: [PATCH] app/testpmd: fix doubling of 'total TX dropped' >=20 > The 'Accumulated forward statistics for all ports' incorrectly displayed = double > the actual value for 'total_tx_dropped'. This was because 2 lines in the = same > function both incremented total_tx_dropped every time a packet was > dropped. I removed one of these lines to fix this issue. >=20 > Fixes: 53324971a14e ("app/testpmd: display/clear forwarding stats on > demand") > Cc: david.marchand@redhat.com > Cc: stable@dpdk.org >=20 > Signed-off-by: A.McLoughlin ./devtools/check-git-log.sh -1 Wrong headline lowercase: app/testpmd: fix doubling of 'total TX dropped' Otherwise Acked-by: Bernard Iremonger