Re: [dpdk-dev] [PATCH] app/testpmd: show max number of segments

["Iremonger, Bernard" <bernard.iremonger@intel.com>]

Hi Viacheslav,

> -----Original Message-----
> From: Viacheslav Ovsiienko [mailto:viacheslavo@mellanox.com]
> Sent: Tuesday, July 16, 2019 9:30 AM
> To: dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: [PATCH] app/testpmd: show max number of segments
> 
> This patch updates "show port info [port_id]" command, it shows the
> tx_desc_lim.nb_seg_max and tx_desc_lim.nb_mtu_seg_max fields of
> rte_eth_dev_info structure.
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
>  app/test-pmd/config.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> 1d80470..ba43be5 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -509,6 +509,10 @@
>  	printf("Min possible number of TXDs per queue: %hu\n",
>  		dev_info.tx_desc_lim.nb_min);
>  	printf("TXDs number alignment: %hu\n",
> dev_info.tx_desc_lim.nb_align);
> +	printf("Max segment number per packet: %hu\n",
> +		dev_info.tx_desc_lim.nb_seg_max);
> +	printf("Max segment number per MTU/TSO: %hu\n",
> +		dev_info.tx_desc_lim.nb_mtu_seg_max);
> 
>  	/* Show switch info only if valid switch domain and port id is set */
>  	if (dev_info.switch_info.domain_id !=
> --
> 1.8.3.1

This patch looks like a fix, if so, it should have the "fix" keyword in the commit message and a fixes line in the body of the commit message and also  Cc: stable@dpdk.org if you intend it to be backported.

The code change looks fine.

Regards,

Bernard.