DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: show max number of segments
Date: Tue, 16 Jul 2019 10:07:33 +0000	[thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260DD0816@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1563265771-24647-1-git-send-email-viacheslavo@mellanox.com>

Hi Viacheslav,

> -----Original Message-----
> From: Viacheslav Ovsiienko [mailto:viacheslavo@mellanox.com]
> Sent: Tuesday, July 16, 2019 9:30 AM
> To: dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: [PATCH] app/testpmd: show max number of segments
> 
> This patch updates "show port info [port_id]" command, it shows the
> tx_desc_lim.nb_seg_max and tx_desc_lim.nb_mtu_seg_max fields of
> rte_eth_dev_info structure.
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
>  app/test-pmd/config.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> 1d80470..ba43be5 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -509,6 +509,10 @@
>  	printf("Min possible number of TXDs per queue: %hu\n",
>  		dev_info.tx_desc_lim.nb_min);
>  	printf("TXDs number alignment: %hu\n",
> dev_info.tx_desc_lim.nb_align);
> +	printf("Max segment number per packet: %hu\n",
> +		dev_info.tx_desc_lim.nb_seg_max);
> +	printf("Max segment number per MTU/TSO: %hu\n",
> +		dev_info.tx_desc_lim.nb_mtu_seg_max);
> 
>  	/* Show switch info only if valid switch domain and port id is set */
>  	if (dev_info.switch_info.domain_id !=
> --
> 1.8.3.1

This patch looks like a fix, if so, it should have the "fix" keyword in the commit message and a fixes line in the body of the commit message and also  Cc: stable@dpdk.org if you intend it to be backported.

The code change looks fine.

Regards,

Bernard.


      reply	other threads:[~2019-07-16 10:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-16  8:29 Viacheslav Ovsiienko
2019-07-16 10:07 ` Iremonger, Bernard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CEF83825BEC744B83065625E567D7C260DD0816@IRSMSX108.ger.corp.intel.com \
    --to=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).