From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D14EA0471 for ; Tue, 16 Jul 2019 12:07:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB8AF4CE4; Tue, 16 Jul 2019 12:07:38 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id AC1F73423 for ; Tue, 16 Jul 2019 12:07:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jul 2019 03:07:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,497,1557212400"; d="scan'208";a="187310925" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 16 Jul 2019 03:07:33 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.229]) by IRSMSX102.ger.corp.intel.com ([169.254.2.59]) with mapi id 14.03.0439.000; Tue, 16 Jul 2019 11:07:34 +0100 From: "Iremonger, Bernard" To: Viacheslav Ovsiienko , "dev@dpdk.org" Thread-Topic: [PATCH] app/testpmd: show max number of segments Thread-Index: AQHVO7Cj5inWBAsxVkOEgEOwN6p+7abNA3jQ Date: Tue, 16 Jul 2019 10:07:33 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260DD0816@IRSMSX108.ger.corp.intel.com> References: <1563265771-24647-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1563265771-24647-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTI5YWQ3NTAtMmQxNC00NTkwLWI3ZDMtMTYyNGE4ZTgzZGZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicFBtS1ZEOXJnbm95QlRMNEFZVWtXS01PWDFCWUNRRXE4NVJoaXF4MWIraExzZFwvZnowblkxRE5JcFFtNG9tNmoifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: show max number of segments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Viacheslav, > -----Original Message----- > From: Viacheslav Ovsiienko [mailto:viacheslavo@mellanox.com] > Sent: Tuesday, July 16, 2019 9:30 AM > To: dev@dpdk.org > Cc: Iremonger, Bernard > Subject: [PATCH] app/testpmd: show max number of segments >=20 > This patch updates "show port info [port_id]" command, it shows the > tx_desc_lim.nb_seg_max and tx_desc_lim.nb_mtu_seg_max fields of > rte_eth_dev_info structure. >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > app/test-pmd/config.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > 1d80470..ba43be5 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -509,6 +509,10 @@ > printf("Min possible number of TXDs per queue: %hu\n", > dev_info.tx_desc_lim.nb_min); > printf("TXDs number alignment: %hu\n", > dev_info.tx_desc_lim.nb_align); > + printf("Max segment number per packet: %hu\n", > + dev_info.tx_desc_lim.nb_seg_max); > + printf("Max segment number per MTU/TSO: %hu\n", > + dev_info.tx_desc_lim.nb_mtu_seg_max); >=20 > /* Show switch info only if valid switch domain and port id is set */ > if (dev_info.switch_info.domain_id !=3D > -- > 1.8.3.1 This patch looks like a fix, if so, it should have the "fix" keyword in the= commit message and a fixes line in the body of the commit message and also= Cc: stable@dpdk.org if you intend it to be backported. The code change looks fine. Regards, Bernard.