From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72A45A046B for ; Wed, 24 Jul 2019 17:00:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C501F1C204; Wed, 24 Jul 2019 17:00:52 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D1A2C1C1FA; Wed, 24 Jul 2019 17:00:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 08:00:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,303,1559545200"; d="scan'208";a="172325727" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga003.jf.intel.com with ESMTP; 24 Jul 2019 08:00:49 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.229]) by IRSMSX107.ger.corp.intel.com ([169.254.10.251]) with mapi id 14.03.0439.000; Wed, 24 Jul 2019 16:00:48 +0100 From: "Iremonger, Bernard" To: David Marchand , "dev@dpdk.org" CC: "olivier.matz@6wind.com" , "stable@dpdk.org" , "Lu, Wenzhuo" , "Wu, Jingjing" Thread-Topic: [PATCH] app/testpmd: fix eth packet dump for small buffers Thread-Index: AQHVQg7mBb63Q6LbAk2Y3PKO1Wa60KbZ3MDQ Date: Wed, 24 Jul 2019 15:00:48 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260DD3D34@IRSMSX108.ger.corp.intel.com> References: <1563965936-1098-1-git-send-email-david.marchand@redhat.com> In-Reply-To: <1563965936-1098-1-git-send-email-david.marchand@redhat.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzkyZjM5ZTMtOTUzMC00MWFmLTkyNGQtN2YyMDk5NzU5N2Y0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibThmU2hTQm55aUxZSjZEWXBuY3JOdzZrVVZiS1FTSDFld0dCd1IyRFIzSXl4cDBTN1hmSnJJOXFISk9BRFBteCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix eth packet dump for small buffers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: David Marchand [mailto:david.marchand@redhat.com] > Sent: Wednesday, July 24, 2019 11:59 AM > To: dev@dpdk.org > Cc: olivier.matz@6wind.com; stable@dpdk.org; Lu, Wenzhuo > ; Wu, Jingjing ; Iremonger, > Bernard > Subject: [PATCH] app/testpmd: fix eth packet dump for small buffers >=20 > In the rather unlikely case where the first segment is too small to conta= in an > ethernet header, we can't go and directly dereference the mbuf data buffe= r. >=20 > Using rte_pktmbuf_read is a little more expensive but this is still accep= table > for a debugging feature. >=20 > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand Acked-by: Bernard Iremonger