DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
	"Su, Simei" <simei.su@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Ye, Xiaolong" <xiaolong.ye@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v8 2/3] ethdev: extend RSS offload types
Date: Tue, 1 Oct 2019 16:02:44 +0000	[thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260DFF4DE@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <155d1d0d-c5cd-2fc1-ad48-345d219bd02f@solarflare.com>

Hi Simei,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andrew Rybchenko
> Sent: Tuesday, October 1, 2019 3:49 PM
> To: Su, Simei <simei.su@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Ye,
> Xiaolong <xiaolong.ye@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v8 2/3] ethdev: extend RSS offload types
> 
> On 10/1/19 5:36 PM, Simei Su wrote:
> > This patch reserves several bits as input set selection from the high
> > end of the 64 bits. It is combined with exisiting ETH_RSS_* to
> > represent RSS types.
> >
> > Signed-off-by: Simei Su <simei.su@intel.com>
> > Reviewed-by: Qi Zhang <qi.z.zhang@intel.com>
> > Acked-by: Ori Kam <orika@mellanox.com>
> > ---
> >   lib/librte_ethdev/rte_ethdev.c | 22 ++++++++++++++++++++++
> >   lib/librte_ethdev/rte_ethdev.h | 14 ++++++++++++++
> >   2 files changed, 36 insertions(+)
> >
> > diff --git a/lib/librte_ethdev/rte_ethdev.c
> > b/lib/librte_ethdev/rte_ethdev.c index af82360..5e5a974 100644
> > --- a/lib/librte_ethdev/rte_ethdev.c
> > +++ b/lib/librte_ethdev/rte_ethdev.c
> > @@ -1269,6 +1269,17 @@ struct rte_eth_dev *
> >   		goto rollback;
> >   	}
> >
> > +	/* simplified the SRC/DST_ONLY RSS offload modificaiton */
> > +	if (dev_conf->rx_adv_conf.rss_conf.rss_hf &
> ETH_RSS_L3_SRC_ONLY &&
> > +		dev_conf->rx_adv_conf.rss_conf.rss_hf &
> ETH_RSS_L3_DST_ONLY)
> 
> I'm afraid some compiler versions could bark about missing parenthesis here.
> Consider to use something like:
>   (rss_conf->rss_hf & (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY) ==
>    (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY)) May be parenthesis
> around & is not required.
> 
> > +			dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf
> &=
> > +				~(ETH_RSS_L3_SRC_ONLY |
> ETH_RSS_L3_DST_ONLY);
> > +
> > +	if (dev_conf->rx_adv_conf.rss_conf.rss_hf &
> ETH_RSS_L4_SRC_ONLY &&
> > +		dev_conf->rx_adv_conf.rss_conf.rss_hf &
> ETH_RSS_L4_DST_ONLY)
> > +			dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf
> &=
> > +				~(ETH_RSS_L4_SRC_ONLY |
> ETH_RSS_L4_DST_ONLY);
> > +
> 
> I think it is wrong to duplicate the logic twice (here and below).
> Helper static function should be used to avoid it.
> 
> >   	/* Check that device supports requested rss hash functions. */
> >   	if ((dev_info.flow_type_rss_offloads |
> >   	     dev_conf->rx_adv_conf.rss_conf.rss_hf) != @@ -3112,6 +3123,17
> > @@ struct rte_eth_dev *
> >   	if (ret != 0)
> >   		return ret;
> >
> > +	/* simplified the SRC/DST_ONLY RSS offload modificaiton */
> > +	if (rss_conf->rss_hf & ETH_RSS_L3_SRC_ONLY &&
> > +		rss_conf->rss_hf & ETH_RSS_L3_DST_ONLY)
> > +			rss_conf->rss_hf &=
> > +				~(ETH_RSS_L3_SRC_ONLY |
> ETH_RSS_L3_DST_ONLY);
> > +
> > +	if (rss_conf->rss_hf & ETH_RSS_L4_SRC_ONLY &&
> > +		rss_conf->rss_hf & ETH_RSS_L4_DST_ONLY)
> > +			rss_conf->rss_hf &=
> > +				~(ETH_RSS_L4_SRC_ONLY |
> ETH_RSS_L4_DST_ONLY);
> > +
> >   	dev = &rte_eth_devices[port_id];
> >   	if ((dev_info.flow_type_rss_offloads | rss_conf->rss_hf) !=
> >   	    dev_info.flow_type_rss_offloads) { diff --git
> > a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> > index 7722f70..6d61b84 100644
> > --- a/lib/librte_ethdev/rte_ethdev.h
> > +++ b/lib/librte_ethdev/rte_ethdev.h
> > @@ -505,6 +505,20 @@ struct rte_eth_rss_conf {
> >   #define ETH_RSS_GENEVE             (1ULL << 20)
> >   #define ETH_RSS_NVGRE              (1ULL << 21)
> >
> > +/*
> > + * We use the following macros to combine with above ETH_RSS_* for
> > + * more specific input set selection. These bits are defined starting
> > + * from the high end of the 64 bits.
> > + * Note: If we use above ETH_RSS_* without SRC/DST_ONLY, it
> > +represents
> > + * both SRC and DST are taken into account. If SRC_ONLY and DST_ONLY
> > +of
> > + * the same level be used simultaneously, it is the same case as none
> > +of
> > + * them are added.
> > + */
> > +#define ETH_RSS_L3_SRC_ONLY        (1ULL << 63)
> > +#define ETH_RSS_L3_DST_ONLY        (1ULL << 62)
> > +#define ETH_RSS_L4_SRC_ONLY        (1ULL << 61)
> > +#define ETH_RSS_L4_DST_ONLY        (1ULL << 60)
> > +
> >   #define ETH_RSS_IP ( \
> >   	ETH_RSS_IPV4 | \
> >   	ETH_RSS_FRAG_IPV4 | \

This patch fails to apply to the latest master branch, a rebase may be needed.

Regards,

Bernard


  reply	other threads:[~2019-10-01 16:02 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  5:35 [dpdk-dev] [PATCH 0/2] " simei
2019-08-09  5:35 ` [dpdk-dev] [PATCH 1/2] ethdev: " simei
2019-08-09  5:35 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add RSS offload types extending support simei
2019-09-23 14:05 ` [dpdk-dev] [PATCH v2 0/2] extend RSS offload types Simei Su
2019-09-23 14:05   ` [dpdk-dev] [PATCH v2 1/2] ethdev: " Simei Su
2019-09-25 10:27     ` Ye Xiaolong
2019-09-25 12:04       ` Su, Simei
2019-09-25 12:23         ` Ye Xiaolong
2019-09-25 12:42           ` Su, Simei
2019-09-25 10:49     ` Ye Xiaolong
2019-09-25 12:00       ` Su, Simei
2019-09-25 12:22         ` Ye Xiaolong
2019-09-25 12:38           ` Su, Simei
2019-09-23 14:05   ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add RSS offload types extending support Simei Su
2019-09-24  5:32   ` [dpdk-dev] [PATCH v2 0/2] extend RSS offload types Zhang, Qi Z
2019-09-25 14:06   ` [dpdk-dev] [PATCH v3 " Simei Su
2019-09-25 14:06     ` [dpdk-dev] [PATCH v3 1/2] ethdev: " Simei Su
2019-09-26  9:16       ` Andrew Rybchenko
2019-09-27  5:54         ` Zhang, Qi Z
2019-09-25 14:06     ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add RSS offload types extending support Simei Su
2019-09-27  8:54     ` [dpdk-dev] [PATCH v4 0/3] extend RSS offload types Simei Su
2019-09-27  8:54       ` [dpdk-dev] [PATCH v4 1/3] ethdev: decouple flow types and " Simei Su
2019-09-29 11:32         ` Andrew Rybchenko
2019-09-27  8:54       ` [dpdk-dev] [PATCH v4 2/3] ethdev: extend " Simei Su
2019-09-28  1:03         ` Zhang, Qi Z
2019-09-28  1:39           ` Su, Simei
2019-09-27  8:54       ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-09-28 16:49         ` Ori Kam
2019-09-29  6:46           ` Su, Simei
2019-09-29  7:21             ` Su, Simei
2019-09-28  2:29       ` [dpdk-dev] [PATCH v5 0/3] extend RSS offload types Simei Su
2019-09-28  2:29         ` [dpdk-dev] [PATCH v5 1/3] ethdev: decouple flow types and " Simei Su
2019-09-28 16:23           ` Ori Kam
2019-09-28  2:29         ` [dpdk-dev] [PATCH v5 2/3] ethdev: extend " Simei Su
2019-09-28 16:26           ` Ori Kam
2019-09-28  2:29         ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-09-29  5:11         ` [dpdk-dev] [PATCH v6 0/3] extend RSS offload types Simei Su
2019-09-29  5:11           ` [dpdk-dev] [PATCH v6 1/3] ethdev: decouple flow types and " Simei Su
2019-09-29  5:11           ` [dpdk-dev] [PATCH v6 2/3] ethdev: extend " Simei Su
2019-09-29 11:40             ` Andrew Rybchenko
2019-09-30  7:49               ` Zhang, Qi Z
2019-09-29  5:11           ` [dpdk-dev] [PATCH v6 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-09-29  7:09           ` [dpdk-dev] [PATCH v7 0/3] extend RSS offload types Simei Su
2019-09-29  7:09             ` [dpdk-dev] [PATCH v7 1/3] ethdev: decouple flow types and " Simei Su
2019-09-29  7:55               ` Yang, Zhiyong
2019-09-29  8:38                 ` Su, Simei
2019-09-29  7:09             ` [dpdk-dev] [PATCH v7 2/3] ethdev: extend " Simei Su
2019-09-29  8:55               ` Su, Simei
2019-09-29  9:15                 ` Su, Simei
2019-09-29  7:09             ` [dpdk-dev] [PATCH v7 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-01 14:36             ` [dpdk-dev] [PATCH v8 0/3] extend RSS offload types Simei Su
2019-10-01 14:36               ` [dpdk-dev] [PATCH v8 1/3] ethdev: decouple flow types and " Simei Su
2019-10-01 14:36               ` [dpdk-dev] [PATCH v8 2/3] ethdev: extend " Simei Su
2019-10-01 14:49                 ` Andrew Rybchenko
2019-10-01 16:02                   ` Iremonger, Bernard [this message]
2019-10-01 16:45                     ` Ferruh Yigit
2019-10-05  4:54                   ` Su, Simei
2019-10-01 14:36               ` [dpdk-dev] [PATCH v8 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-03 11:35               ` [dpdk-dev] [PATCH v9 0/3] extend RSS offload types Simei Su
2019-10-03 11:35                 ` [dpdk-dev] [PATCH v9 1/3] ethdev: decouple flow types and " Simei Su
2019-10-03 11:35                 ` [dpdk-dev] [PATCH v9 2/3] ethdev: extend " Simei Su
2019-10-03 11:35                 ` [dpdk-dev] [PATCH v9 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-04  4:45                 ` [dpdk-dev] [PATCH v10 0/3] extend RSS offload types Simei Su
2019-10-04  4:46                   ` [dpdk-dev] [PATCH v10 1/3] ethdev: decouple flow types and " Simei Su
2019-10-04  4:46                   ` [dpdk-dev] [PATCH v10 2/3] ethdev: extend " Simei Su
2019-10-08 16:45                     ` Andrew Rybchenko
2019-10-09  7:06                       ` Su, Simei
2019-10-04  4:46                   ` [dpdk-dev] [PATCH v10 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-09  6:57                   ` [dpdk-dev] [PATCH v11 0/3] extend RSS offload types Simei Su
2019-10-09  6:57                     ` [dpdk-dev] [PATCH v11 1/3] ethdev: decouple flow types and " Simei Su
2019-10-09  6:57                     ` [dpdk-dev] [PATCH v11 2/3] ethdev: extend " Simei Su
2019-10-09  7:18                       ` Andrew Rybchenko
2019-10-09  7:42                         ` Su, Simei
2019-10-09  7:55                           ` Andrew Rybchenko
2019-10-09  9:08                             ` Su, Simei
2019-10-09  9:32                             ` Zhang, Qi Z
2019-10-10 14:37                               ` Su, Simei
2019-10-09  6:57                     ` [dpdk-dev] [PATCH v11 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-14 13:36                     ` [dpdk-dev] [PATCH v12 0/3] extend RSS offload types Simei Su
2019-10-14 13:36                       ` [dpdk-dev] [PATCH v12 1/3] ethdev: decouple flow types and " Simei Su
2019-10-14 13:36                       ` [dpdk-dev] [PATCH v12 2/3] ethdev: extend " Simei Su
2019-10-15  9:07                         ` Andrew Rybchenko
2019-10-15 10:55                           ` Su, Simei
2019-10-15 11:09                             ` Andrew Rybchenko
2019-10-15 11:21                               ` Su, Simei
2019-10-14 13:36                       ` [dpdk-dev] [PATCH v12 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-15 12:56                       ` [dpdk-dev] [PATCH v13 0/3] extend RSS offload types Simei Su
2019-10-15 12:56                         ` [dpdk-dev] [PATCH v13 1/3] ethdev: decouple flow types and " Simei Su
2019-10-15 12:56                         ` [dpdk-dev] [PATCH v13 2/3] ethdev: extend " Simei Su
2019-10-15 13:07                           ` Andrew Rybchenko
2019-10-15 15:00                             ` Su, Simei
2019-10-15 12:56                         ` [dpdk-dev] [PATCH v13 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-15 15:09                         ` [dpdk-dev] [PATCH v14 0/3] extend RSS offload types Simei Su
2019-10-15 15:09                           ` [dpdk-dev] [PATCH v14 1/3] ethdev: decouple flow types and " Simei Su
2019-10-15 15:09                           ` [dpdk-dev] [PATCH v14 2/3] ethdev: extend " Simei Su
2019-10-15 15:09                           ` [dpdk-dev] [PATCH v14 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-18 11:43                           ` [dpdk-dev] [PATCH v14 0/3] extend RSS offload types Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CEF83825BEC744B83065625E567D7C260DFF4DE@IRSMSX108.ger.corp.intel.com \
    --to=bernard.iremonger@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=simei.su@intel.com \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).