From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E693AA3160 for ; Fri, 11 Oct 2019 17:13:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B60DF1EB0D; Fri, 11 Oct 2019 17:13:49 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 012AF1EAFD for ; Fri, 11 Oct 2019 17:13:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2019 08:13:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,284,1566889200"; d="scan'208";a="224361751" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga002.fm.intel.com with ESMTP; 11 Oct 2019 08:13:44 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.26]) by IRSMSX153.ger.corp.intel.com ([169.254.9.123]) with mapi id 14.03.0439.000; Fri, 11 Oct 2019 16:13:44 +0100 From: "Iremonger, Bernard" To: Akhil Goyal , "dev@dpdk.org" , "Ananyev, Konstantin" , "anoobj@marvell.com" , "jerinj@marvell.com" , "'Thomas Monjalon'" CC: "Iremonger, Bernard" Thread-Topic: [PATCH v2 0/3] examples/ipsec-secgw: set default Thread-Index: AQHVeGt1dSqO/sYt5EmWNwDv6tYJ0KdVYHmAgAA6TQA= Date: Fri, 11 Oct 2019 15:13:43 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260E050D5@IRSMSX108.ger.corp.intel.com> References: <1567069173-10505-1-git-send-email-bernard.iremonger@intel.com> <1569943080-20228-1-git-send-email-bernard.iremonger@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDZkYWNhYjYtOWFmMy00ZWMwLWFlMjUtMzMzNjg3MWMyNTc1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaXBiQmNZdWVjVGRNTTdLZ0ZyMHN1WVFlZFNcL25COTJ1VHU4WUlvdTd4TlRKUnpkdElOanRcL1NmWlwvREF3MWxEWSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, With this patch applied the legacy code path in the ipsec-secgw application= is still available. The default code path is now to use librte_ipsec. The "-l 0" option at startup allows the legacy code path to be used. Both code paths are still available. Regards, Bernard=20 > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Friday, October 11, 2019 1:40 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Ananyev, Konstantin ; > anoobj@marvell.com; jerinj@marvell.com; 'Thomas Monjalon' > > Subject: RE: [PATCH v2 0/3] examples/ipsec-secgw: set default >=20 > Hi All, >=20 > This patchset would need ack from more vendors as it will impact user > experience on a key example application which is normally demonstrated to > customers. >=20 > IPSec library is still evolving and there are new functionality added eve= ry > release. > Atleast from NXP side we are not OK with this change. >=20 > I would hold this patch till RC2 atleast. >=20 > Regards, > Akhil >=20 > > -----Original Message----- > > From: Bernard Iremonger > > Sent: Tuesday, October 1, 2019 8:48 PM > > To: dev@dpdk.org; konstantin.ananyev@intel.com; Akhil Goyal > > > > Cc: Bernard Iremonger > > Subject: [PATCH v2 0/3] examples/ipsec-secgw: set default > > > > This patch set, sets the default code path in the ipsec-secgw > > application to use the librte_ipsec. > > The *_old test scripts have been modified to use the legacy code path. > > > > Changes in v2: > > ------------- > > The error messages for the -l option have been updated. > > The pktest.sh script has been updated to drop the -l option. > > > > Bernard Iremonger (3): > > examples/ipsec-secgw: set default to IPsec library mode > > examples/ipsec-secgw: add -l 0 parameter to old scripts > > examples/ipsec-secgw: update pktest.sh script > > > > doc/guides/rel_notes/release_19_11.rst | 8 ++++ > > doc/guides/sample_app_ug/ipsec_secgw.rst | 6 ++- > > examples/ipsec-secgw/ipsec-secgw.c | 46 ++++++++++++++= ------- > - > > examples/ipsec-secgw/test/pkttest.sh | 1 - > > .../ipsec-secgw/test/trs_3descbc_sha1_old_defs.sh | 2 +- > > .../ipsec-secgw/test/trs_aescbc_sha1_old_defs.sh | 2 +- > > .../ipsec-secgw/test/trs_aesctr_sha1_old_defs.sh | 2 +- > > .../test/trs_aesgcm_inline_crypto_old_defs.sh | 2 +- > > examples/ipsec-secgw/test/trs_aesgcm_old_defs.sh | 2 +- > > .../ipsec-secgw/test/tun_3descbc_sha1_old_defs.sh | 2 +- > > .../ipsec-secgw/test/tun_aescbc_sha1_old_defs.sh | 2 +- > > .../ipsec-secgw/test/tun_aesctr_sha1_old_defs.sh | 2 +- > > .../test/tun_aesgcm_inline_crypto_old_defs.sh | 2 +- > > examples/ipsec-secgw/test/tun_aesgcm_old_defs.sh | 2 +- > > 14 files changed, 52 insertions(+), 29 deletions(-) > > > > -- > > 2.7.4