From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Xu, Ting" <ting.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix CRC strip command failure
Date: Tue, 15 Oct 2019 09:40:32 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260E0E2E6@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20191015091420.98104-1-ting.xu@intel.com>
> -----Original Message-----
> From: Xu, Ting
> Sent: Tuesday, October 15, 2019 10:14 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] app/testpmd: fix CRC strip command failure
>
> This patch fixed the bug that a failure appeared when config rx_offload
> crc_strip using command "port config all crc-strip
> on|off". The reason is that this command was removed in Commit
> e5db17a1e54e. The current command is "port config <port_id> rx_offload
> keep_crc on|off" instead.
>
> In this patch, some codes left over about 'crc_strip' are removed to make the
> current command clearer.
>
> Fixes: e5db17a1e54e ("app/testpmd: remove duplicated Rx offload
> commands")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ting Xu <ting.xu@intel.com>
Acked by: Bernard Iremonger <bernard.iremonger@intel.com>
next prev parent reply other threads:[~2019-10-15 9:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 12:18 [dpdk-dev] [PATCH v1] app/testpmd: fix CRC strip config error Ting Xu
2019-10-14 11:25 ` Iremonger, Bernard
2019-10-14 11:41 ` Iremonger, Bernard
2019-10-15 1:03 ` Xu, Ting
2019-10-14 12:28 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-10-15 0:49 ` Xu, Ting
2019-10-15 9:14 ` [dpdk-dev] [PATCH v2] app/testpmd: fix CRC strip command failure Ting Xu
2019-10-15 9:40 ` Iremonger, Bernard [this message]
2019-10-15 13:13 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C260E0E2E6@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=stable@dpdk.org \
--cc=ting.xu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).