From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D335AA2EFC for ; Tue, 15 Oct 2019 11:40:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5CAE1EB32; Tue, 15 Oct 2019 11:40:36 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 43EBC1EB2A; Tue, 15 Oct 2019 11:40:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Oct 2019 02:40:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,298,1566889200"; d="scan'208";a="195233788" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga007.fm.intel.com with ESMTP; 15 Oct 2019 02:40:33 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.131]) by IRSMSX102.ger.corp.intel.com ([169.254.2.40]) with mapi id 14.03.0439.000; Tue, 15 Oct 2019 10:40:32 +0100 From: "Iremonger, Bernard" To: "Xu, Ting" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Wu, Jingjing" , "Mcnamara, John" , "Kovacevic, Marko" , "stable@dpdk.org" Thread-Topic: [PATCH v2] app/testpmd: fix CRC strip command failure Thread-Index: AQHVgv4waKOhvCr2f06RFkFXhX6jhKdbcr4g Date: Tue, 15 Oct 2019 09:40:32 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260E0E2E6@IRSMSX108.ger.corp.intel.com> References: <22fa727a2ce09834133530c40cb02666e0be10ba.1570882485.git.ting.xu@intel.com> <20191015091420.98104-1-ting.xu@intel.com> In-Reply-To: <20191015091420.98104-1-ting.xu@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDExNDM5YmQtODdhOS00YTM2LWI4ZWQtYjhiZjIxZGEzYTJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUDZhcm5EcHcrcHBCM04xWFNkYUd4Z2hmRjIzRE1nMTFtOTA4VXEyYVpMSHNVc0UzUFRYRFdTcGFxeEFiSDVWaCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix CRC strip command failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xu, Ting > Sent: Tuesday, October 15, 2019 10:14 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Mcnamara, John > ; Kovacevic, Marko > ; stable@dpdk.org > Subject: [PATCH v2] app/testpmd: fix CRC strip command failure >=20 > This patch fixed the bug that a failure appeared when config rx_offload > crc_strip using command "port config all crc-strip > on|off". The reason is that this command was removed in Commit > e5db17a1e54e. The current command is "port config rx_offload > keep_crc on|off" instead. >=20 > In this patch, some codes left over about 'crc_strip' are removed to make= the > current command clearer. >=20 > Fixes: e5db17a1e54e ("app/testpmd: remove duplicated Rx offload > commands") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ting Xu Acked by: Bernard Iremonger