From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 300D8A00D7; Thu, 31 Oct 2019 11:33:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 02FE81C1FF; Thu, 31 Oct 2019 11:33:53 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AA7AA1C1FE for ; Thu, 31 Oct 2019 11:33:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2019 03:33:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,250,1569308400"; d="scan'208";a="206070809" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by FMSMGA003.fm.intel.com with ESMTP; 31 Oct 2019 03:33:48 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.131]) by IRSMSX153.ger.corp.intel.com ([169.254.9.119]) with mapi id 14.03.0439.000; Thu, 31 Oct 2019 10:33:47 +0000 From: "Iremonger, Bernard" To: "pbhagavatula@marvell.com" , "Yigit, Ferruh" , "arybchenko@solarflare.com" , "jerinj@marvell.com" , "Lu, Wenzhuo" , "Wu, Jingjing" , "Mcnamara, John" , "Kovacevic, Marko" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v15 7/7] app/testpmd: add command to set supported ptype mask Thread-Index: AQHVjm7bah3ACFVxjkWk8Bz/V9qLiad0jomw Date: Thu, 31 Oct 2019 10:33:47 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260E15483@IRSMSX108.ger.corp.intel.com> References: <20191029050312.2715-1-pbhagavatula@marvell.com> <20191029153722.4547-1-pbhagavatula@marvell.com> <20191029153722.4547-8-pbhagavatula@marvell.com> In-Reply-To: <20191029153722.4547-8-pbhagavatula@marvell.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGQwNzc5YWMtMGViNi00MjU2LTk1ZWQtMTIxNmM5NDkxZjY1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibEJ0V010b2JtTnA1Um4rdzFzalg4S1RHUFo4OWhrOHM5ZGpwY01GRmRDYm55TW5CM3Q0ZjI4Wk9LcmFTemVEeiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v15 7/7] app/testpmd: add command to set supported ptype mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pavan, > -----Original Message----- > From: pbhagavatula@marvell.com > Sent: Tuesday, October 29, 2019 3:37 PM > To: Yigit, Ferruh ; arybchenko@solarflare.com; > jerinj@marvell.com; Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Mcnamara, John > ; Kovacevic, Marko > > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v15 7/7] app/testpmd: add command to set > supported ptype mask >=20 > From: Pavan Nikhilesh >=20 > Add command to set supported ptype mask. > Usage: > set port ptype_mask >=20 > Disable ptype parsing by default. >=20 > Signed-off-by: Pavan Nikhilesh > --- > app/test-pmd/cmdline.c | 80 +++++++++++++++++++++ > app/test-pmd/testpmd.c | 6 ++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 ++ > 3 files changed, 93 insertions(+) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 447806991..9f0356b50 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c The help text should be updated to describe the new command at line 240 in = cmdline.c > @@ -18915,6 +18915,85 @@ cmdline_parse_inst_t > cmd_show_port_supported_ptypes =3D { > }, > }; >=20 > +/* Common result structure for set port ptypes */ struct > +cmd_set_port_supported_ptypes_result { > + cmdline_fixed_string_t set; > + cmdline_fixed_string_t port; > + portid_t port_id; > + cmdline_fixed_string_t ptype_mask; > + uint32_t mask; > +}; > + > +/* Common CLI fields for set port ptypes */ > +cmdline_parse_token_string_t cmd_set_port_supported_ptypes_set =3D > + TOKEN_STRING_INITIALIZER > + (struct cmd_set_port_supported_ptypes_result, > + set, "set"); > +cmdline_parse_token_string_t cmd_set_port_supported_ptypes_port =3D > + TOKEN_STRING_INITIALIZER > + (struct cmd_set_port_supported_ptypes_result, > + port, "port"); > +cmdline_parse_token_num_t cmd_set_port_supported_ptypes_port_id =3D > + TOKEN_NUM_INITIALIZER > + (struct cmd_set_port_supported_ptypes_result, > + port_id, UINT16); > +cmdline_parse_token_string_t > cmd_set_port_supported_ptypes_mask_str =3D > + TOKEN_STRING_INITIALIZER > + (struct cmd_set_port_supported_ptypes_result, > + ptype_mask, "ptype_mask"); > +cmdline_parse_token_num_t > cmd_set_port_supported_ptypes_mask_u32 =3D > + TOKEN_NUM_INITIALIZER > + (struct cmd_set_port_supported_ptypes_result, > + mask, UINT32); > + > +static void > +cmd_set_port_supported_ptypes_parsed( > + void *parsed_result, > + __attribute__((unused)) struct cmdline *cl, > + __attribute__((unused)) void *data) > +{ > + struct cmd_set_port_supported_ptypes_result *res =3D > parsed_result; > +#define PTYPE_NAMESIZE 256 > + char ptype_name[PTYPE_NAMESIZE]; > + uint16_t port_id =3D res->port_id; > + uint32_t ptype_mask =3D res->mask; > + int ret, i; > + > + ret =3D rte_eth_dev_get_supported_ptypes(port_id, ptype_mask, > NULL, 0); > + if (ret <=3D 0) { > + printf("Port %d doesn't support any ptypes.\n", port_id); > + return; > + } > + > + uint32_t ptypes[ret]; Might be better to move above variable declaration to top of function with = the other declarations. > + ret =3D rte_eth_dev_set_supported_ptypes(port_id, ptype_mask, > ptypes, > + ret); > + if (ret <=3D 0) { > + printf("Unable to set requested ptypes for Port %d\n", > port_id); > + return; > + } > + > + printf("Successfully set following ptypes for Port %d\n", port_id); > + for (i =3D 0; i < ret && ptypes[i] !=3D RTE_PTYPE_UNKNOWN; i++) { > + rte_get_ptype_name(ptypes[i], ptype_name, > sizeof(ptype_name)); > + printf("%s\n", ptype_name); > + } > +} > + > +cmdline_parse_inst_t cmd_set_port_supported_ptypes =3D { > + .f =3D cmd_set_port_supported_ptypes_parsed, > + .data =3D NULL, > + .help_str =3D "set port ptype_mask ", > + .tokens =3D { > + (void *)&cmd_set_port_supported_ptypes_set, > + (void *)&cmd_set_port_supported_ptypes_port, > + (void *)&cmd_set_port_supported_ptypes_port_id, > + (void *)&cmd_set_port_supported_ptypes_mask_str, > + (void *)&cmd_set_port_supported_ptypes_mask_u32, > + NULL, > + }, > +}; > + > /* > ********************************************************** > ********************** */ >=20 > /* list of instructions */ > @@ -19154,6 +19233,7 @@ cmdline_parse_ctx_t main_ctx[] =3D { > (cmdline_parse_inst_t *)&cmd_show_vf_stats, > (cmdline_parse_inst_t *)&cmd_clear_vf_stats, > (cmdline_parse_inst_t *)&cmd_show_port_supported_ptypes, > + (cmdline_parse_inst_t *)&cmd_set_port_supported_ptypes, > (cmdline_parse_inst_t *)&cmd_ptype_mapping_get, > (cmdline_parse_inst_t *)&cmd_ptype_mapping_replace, > (cmdline_parse_inst_t *)&cmd_ptype_mapping_reset, diff --git > a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 38acbc58a..fd2c04d64 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2028,6 +2028,7 @@ start_port(portid_t pid) > queueid_t qi; > struct rte_port *port; > struct rte_ether_addr mac_addr; > + static uint8_t clr_ptypes =3D 1; >=20 > if (port_id_is_invalid(pid, ENABLED_WARN)) > return 0; > @@ -2157,6 +2158,11 @@ start_port(portid_t pid) > } > } > configure_rxtx_dump_callbacks(verbose_level); > + if (clr_ptypes) { > + clr_ptypes =3D 0; > + rte_eth_dev_set_supported_ptypes(pi, > RTE_PTYPE_UNKNOWN, > + NULL, 0); > + } > /* start port */ > if (rte_eth_dev_start(pi) < 0) { > printf("Fail to start port %d\n", pi); diff --git > a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index c68a742eb..9c4dc92aa 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -472,6 +472,13 @@ Show ptypes supported for a specific port:: >=20 > testpmd> show port (port_id) ptypes >=20 > +set port supported ptypes > +~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +Inform packet types classification interested in for a specific port:: The description of the command is not very clear. Perhaps something like the following would be better: "set packet types classification for a specific port::" > + > + testpmd> set port (port_id) ptypes_mask (mask) > + > show device info > ~~~~~~~~~~~~~~~~ >=20 > -- > 2.17.1 Regards, Bernard.