From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB60EA04AB; Wed, 6 Nov 2019 13:35:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E18EB1C12E; Wed, 6 Nov 2019 13:35:57 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A43B61C10B for ; Wed, 6 Nov 2019 13:35:55 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 04:35:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,274,1569308400"; d="scan'208";a="192450589" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga007.jf.intel.com with ESMTP; 06 Nov 2019 04:35:50 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.131]) by IRSMSX102.ger.corp.intel.com ([169.254.2.40]) with mapi id 14.03.0439.000; Wed, 6 Nov 2019 12:35:49 +0000 From: "Iremonger, Bernard" To: Dekel Peled , "Mcnamara, John" , "Kovacevic, Marko" , "nhorman@tuxdriver.com" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , "Burakov, Anatoly" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "matan@mellanox.com" , "shahafs@mellanox.com" , "viacheslavo@mellanox.com" , "rmody@marvell.com" , "shshaikh@marvell.com" , "maxime.coquelin@redhat.com" , "Bie, Tiwei" , "Wang, Zhihong" , "yongwang@vmware.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "arybchenko@solarflare.com" , "Wu, Jingjing" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 3/3] app/testpmd: use API to set max LRO packet size Thread-Index: AQHVlJY37sXEFkqA8k+dlgsqC2YZp6d+EaSQ Date: Wed, 6 Nov 2019 12:35:48 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260E211E1@IRSMSX108.ger.corp.intel.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDY5OThlY2ItY2M0MS00MWE3LTlkMTctNzRiYTc4ODNjOTgwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidWN2YUVMZGRcL0o4UUdUcTlBY3pPVkF6RUJnWVFWU0x0ZVNWSEpNOHk2MVpJRVo2V1NvTmIxNVJHdzdxQUMzT0UifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: use API to set max LRO packet size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dekel, > -----Original Message----- > From: Dekel Peled > Sent: Wednesday, November 6, 2019 11:35 AM > To: Mcnamara, John ; Kovacevic, Marko > ; nhorman@tuxdriver.com; > ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; Burakov, > Anatoly ; xuanziyang2@huawei.com; > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; Lu, Wenzhuo > ; Ananyev, Konstantin > ; matan@mellanox.com; > shahafs@mellanox.com; viacheslavo@mellanox.com; rmody@marvell.com; > shshaikh@marvell.com; maxime.coquelin@redhat.com; Bie, Tiwei > ; Wang, Zhihong ; > yongwang@vmware.com; thomas@monjalon.net; Yigit, Ferruh > ; arybchenko@solarflare.com; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org > Subject: [PATCH v2 3/3] app/testpmd: use API to set max LRO packet size >=20 > This patch implements use of the API for LRO aggregated packet max size. > It adds command-line and runtime commands to configure this value, and > adds option to show the supported value. > Documentation is updated accordingly. >=20 > Signed-off-by: Dekel Peled > --- > app/test-pmd/cmdline.c | 73 > +++++++++++++++++++++++++++++ > app/test-pmd/config.c | 2 + > app/test-pmd/parameters.c | 5 ++ > app/test-pmd/testpmd.c | 1 + > doc/guides/testpmd_app_ug/run_app.rst | 5 ++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 ++++ > 6 files changed, 95 insertions(+) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 4478069..edfa60f 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -2037,6 +2037,78 @@ struct cmd_config_max_pkt_len_result { > }, > }; >=20 > +/* *** config max LRO aggregated packet size *** */ struct > +cmd_config_max_lro_pkt_size_result { > + cmdline_fixed_string_t port; > + cmdline_fixed_string_t keyword; > + cmdline_fixed_string_t all; > + cmdline_fixed_string_t name; > + uint32_t value; > +}; > + > +static void > +cmd_config_max_lro_pkt_size_parsed(void *parsed_result, > + __attribute__((unused)) struct cmdline *cl, > + __attribute__((unused)) void *data) { > + struct cmd_config_max_lro_pkt_size_result *res =3D parsed_result; > + portid_t pid; > + > + if (!all_ports_stopped()) { > + printf("Please stop all ports first\n"); > + return; > + } > + > + RTE_ETH_FOREACH_DEV(pid) { > + struct rte_port *port =3D &ports[pid]; > + > + if (!strcmp(res->name, "max-lro-pkt-size")) { > + if (res->value =3D=3D > + port- > >dev_conf.rxmode.max_lro_pkt_size) > + return; > + Should there be a check on the input value, max is RTE_ETHER_MAX_LEN ? > + port->dev_conf.rxmode.max_lro_pkt_size =3D res- > >value; > + } else { > + printf("Unknown parameter\n"); > + return; > + } > + } > + > + init_port_config(); > + > + cmd_reconfig_device_queue(RTE_PORT_ALL, 1, 1); } > + > +cmdline_parse_token_string_t cmd_config_max_lro_pkt_size_port =3D > + TOKEN_STRING_INITIALIZER(struct > cmd_config_max_lro_pkt_size_result, > + port, "port"); > +cmdline_parse_token_string_t cmd_config_max_lro_pkt_size_keyword =3D > + TOKEN_STRING_INITIALIZER(struct > cmd_config_max_lro_pkt_size_result, > + keyword, "config"); > +cmdline_parse_token_string_t cmd_config_max_lro_pkt_size_all =3D > + TOKEN_STRING_INITIALIZER(struct > cmd_config_max_lro_pkt_size_result, > + all, "all"); > +cmdline_parse_token_string_t cmd_config_max_lro_pkt_size_name =3D > + TOKEN_STRING_INITIALIZER(struct > cmd_config_max_lro_pkt_size_result, > + name, "max-lro-pkt-size"); > +cmdline_parse_token_num_t cmd_config_max_lro_pkt_size_value =3D > + TOKEN_NUM_INITIALIZER(struct > cmd_config_max_lro_pkt_size_result, > + value, UINT32); > + > +cmdline_parse_inst_t cmd_config_max_lro_pkt_size =3D { > + .f =3D cmd_config_max_lro_pkt_size_parsed, > + .data =3D NULL, > + .help_str =3D "port config all max-lro-pkt-size ", > + .tokens =3D { > + (void *)&cmd_config_max_lro_pkt_size_port, > + (void *)&cmd_config_max_lro_pkt_size_keyword, > + (void *)&cmd_config_max_lro_pkt_size_all, > + (void *)&cmd_config_max_lro_pkt_size_name, > + (void *)&cmd_config_max_lro_pkt_size_value, > + NULL, > + }, > +}; > + > /* *** configure port MTU *** */ > struct cmd_config_mtu_result { > cmdline_fixed_string_t port; > @@ -19024,6 +19096,7 @@ struct > cmd_show_port_supported_ptypes_result { > (cmdline_parse_inst_t *)&cmd_config_rx_tx, > (cmdline_parse_inst_t *)&cmd_config_mtu, > (cmdline_parse_inst_t *)&cmd_config_max_pkt_len, > + (cmdline_parse_inst_t *)&cmd_config_max_lro_pkt_size, > (cmdline_parse_inst_t *)&cmd_config_rx_mode_flag, > (cmdline_parse_inst_t *)&cmd_config_rss, > (cmdline_parse_inst_t *)&cmd_config_rxtx_ring_size, diff --git > a/app/test-pmd/config.c b/app/test-pmd/config.c index efe2812..50e6ac0 > 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -629,6 +629,8 @@ static int bus_match_all(const struct rte_bus *bus, > const void *data) > printf("Minimum size of RX buffer: %u\n", > dev_info.min_rx_bufsize); > printf("Maximum configurable length of RX packet: %u\n", > dev_info.max_rx_pktlen); > + printf("Maximum configurable size of LRO aggregated packet: %u\n", > + dev_info.max_lro_pkt_size); > if (dev_info.max_vfs) > printf("Maximum number of VFs: %u\n", dev_info.max_vfs); > if (dev_info.max_vmdq_pools) > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index > 9ea87c1..3e371e2 100644 > --- a/app/test-pmd/parameters.c > +++ b/app/test-pmd/parameters.c > @@ -592,6 +592,7 @@ > { "mbuf-size", 1, 0, 0 }, > { "total-num-mbufs", 1, 0, 0 }, > { "max-pkt-len", 1, 0, 0 }, > + { "max-lro-pkt-size", 1, 0, 0 }, The max-lro-pkt-size option should be documented in the usage() function ar= ound line 110 in parameters.c > { "pkt-filter-mode", 1, 0, 0 }, > { "pkt-filter-report-hash", 1, 0, 0 }, > { "pkt-filter-size", 1, 0, 0 }, > @@ -888,6 +889,10 @@ > "Invalid max-pkt-len=3D%d - > should be > %d\n", > n, RTE_ETHER_MIN_LEN); > } > + if (!strcmp(lgopts[opt_idx].name, "max-lro-pkt- > size")) { > + n =3D atoi(optarg); Should there be a check on the value input, max value is RTE_ETHER_MAX_LEN? > + rx_mode.max_lro_pkt_size =3D (uint32_t) n; > + } > if (!strcmp(lgopts[opt_idx].name, "pkt-filter-mode")) > { > if (!strcmp(optarg, "signature")) > fdir_conf.mode =3D > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 38acbc5..d4f67ec 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -419,6 +419,7 @@ struct fwd_engine * fwd_engines[] =3D { struct > rte_eth_rxmode rx_mode =3D { > .max_rx_pkt_len =3D RTE_ETHER_MAX_LEN, > /**< Default maximum frame length. */ > + .max_lro_pkt_size =3D RTE_ETHER_MAX_LEN, > }; >=20 > struct rte_eth_txmode tx_mode =3D { > diff --git a/doc/guides/testpmd_app_ug/run_app.rst > b/doc/guides/testpmd_app_ug/run_app.rst > index ef677ba..bc17f3f 100644 > --- a/doc/guides/testpmd_app_ug/run_app.rst > +++ b/doc/guides/testpmd_app_ug/run_app.rst > @@ -112,6 +112,11 @@ The command line options are: >=20 > Set the maximum packet size to N bytes, where N >=3D 64. The default= value > is 1518. >=20 > +* ``--max-lro-pkt-size=3DN`` > + > + Set the maximum LRO aggregated packet size to N bytes, where N >=3D = 64. > + The default value is 1518. Should a max value be specified ? > + > * ``--eth-peers-configfile=3Dname`` >=20 > Use a configuration file containing the Ethernet addresses of the pe= er > ports. > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index c68a742..0267295 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -2139,6 +2139,15 @@ Set the maximum packet length:: >=20 > This is equivalent to the ``--max-pkt-len`` command-line option. >=20 > +port config - max-lro-pkt-size > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +Set the maximum LRO aggregated packet size:: > + > + testpmd> port config all max-lro-pkt-size (value) > + > +This is equivalent to the ``--max-lro-pkt-size`` command-line option. > + > port config - Drop Packets > ~~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > -- > 1.8.3.1 Regards, Bernard.