From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C070A04C1; Thu, 21 Nov 2019 12:43:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF18C2BA3; Thu, 21 Nov 2019 12:43:08 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 6FD5423D; Thu, 21 Nov 2019 12:43:07 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 03:43:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,224,1571727600"; d="scan'208";a="205045735" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga008.fm.intel.com with ESMTP; 21 Nov 2019 03:43:05 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.131]) by IRSMSX101.ger.corp.intel.com ([169.254.1.76]) with mapi id 14.03.0439.000; Thu, 21 Nov 2019 11:43:05 +0000 From: "Iremonger, Bernard" To: Stephen Hemminger , "dev@dpdk.org" CC: "ndabilpuram@marvell.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] testpmd: fix memory leak in iterator Thread-Index: AQHVn/oPFMDicny+9kahGRt87Pg5j6eVgOCA Date: Thu, 21 Nov 2019 11:43:04 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260E2820B@IRSMSX108.ger.corp.intel.com> References: <20191120232628.29737-1-stephen@networkplumber.org> In-Reply-To: <20191120232628.29737-1-stephen@networkplumber.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDE2YTg5OGItMmYzYy00NGM5LThmOTMtNmE3M2QzOWYxYjEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOGwrb3Z3MzBDUmNXQ25cL2VQQ3N0aTRTMGc2UmxobXNZSkozQUlnV1Z1N3pqaDBcL2xhelphS0dja2dnTHlSd0loIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] testpmd: fix memory leak in iterator X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Stephen Hemminger > Sent: Wednesday, November 20, 2019 11:26 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; > ndabilpuram@marvell.com; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] testpmd: fix memory leak in iterator >=20 > The RTE_FOREACH_MATCHING_DEV iterator requires that if a break is done > before the end of the loop, the function rte_eth_iterator_cleanup() must = be > called. >=20 > Fixes: 55e51c962432 ("app/testpmd: add device related commands") > Cc: ndabilpuram@marvell.com > Cc: stable@dpdk.org > Signed-off-by: Stephen Hemminger ./devtools/check-git-log.sh -1 Wrong headline label: testpmd: fix memory leak in iterator Headline label should be app/testpmd Otherwise Acked-by: Bernard Iremonger