From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F79FA04B5; Mon, 11 Jan 2021 21:22:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 059A5140CDC; Mon, 11 Jan 2021 21:22:55 +0100 (CET) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id 76615140CD7 for ; Mon, 11 Jan 2021 21:22:53 +0100 (CET) Received: by mail-pf1-f170.google.com with SMTP id m6so632014pfm.6 for ; Mon, 11 Jan 2021 12:22:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Beu8JzXa5lIAPzlqs5cVhbXxYOfb92Y58/WgzD9TB1g=; b=xMrzcPvPs0XACvvHUSe5KhdC59uY1bqmDjUjCwGJgKXDtRsv+nUDIkKnY8PGD/ivNO OpQiRjo4QqSPSVuBSbo7srDb4lmtFpgMiALX7NReKLrQGUc4K3ERuxmLmgHRSZr5gYdV IcD/7+2C6TL+u4rTyDkaGr09UTjAtK2g+QpqBkQ6CCmo9S7z8f5yxT9w/sYtEB97MqcH 6HTY8YbTGzVn0Qo/WUR/YEzaT/f0Rx6ZUDcA6GzJRyb42uMGuH6mhqvSJGZlo8k30yw3 MnyJJF7qvmwgmCTBdMiLuzVJcDQS502eoHa7H3eVPcMEHZUgD5zoTzGiJp0xwHnGzbul 5TbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Beu8JzXa5lIAPzlqs5cVhbXxYOfb92Y58/WgzD9TB1g=; b=T3m0uIGEnIVjUuPeV9QqzBTg9bBbRN0+B4apz6MSuCwzAhu7+koDW1NlZmNNmhFDt1 Dw9sy5JehSS2HTj1FZYPwfZKYRI8djbEAyj312dEuHtAI3VzEQ2UXnq72LyCSnf7kbAs PMdRiwPT7bvpMvALjXabmI338qHqdjh9piKs4zVeW/b954gjjmOvY0I46NIAu9SiWtCv 7tEqHaDafE0zUAEj88+xP4ViDL8grfqyexGxqwfULmTbdImGRsnmDn+BN7I5khGuAnQ9 0mHMNIH/p6t0hI9WOuCNzhZtOvKhSVjeQy0TQebcxFEbkU2Up6CBXaS4vUpdPUKnlaKb u6Ig== X-Gm-Message-State: AOAM531EPIllNTZFdYkkkNxw9DlOJrVeCKkZ7M7wmrI6pT/iQNbmZRVd FtCwaHEQ0Tv6Lw2FQYKnST1MJA== X-Google-Smtp-Source: ABdhPJyiPINNllcSWTsywokCWU6EgEYJb+3QK2Zl5lvD9r19hGECWL8O72IQ1ZlJd7ZEU5xfuN2PWg== X-Received: by 2002:a62:1ec1:0:b029:1a8:2c01:13c0 with SMTP id e184-20020a621ec10000b02901a82c0113c0mr1366758pfe.8.1610396572499; Mon, 11 Jan 2021 12:22:52 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:1129:cd4b:9e0e:30cb? ([2600:1700:6b0:fde0:1129:cd4b:9e0e:30cb]) by smtp.gmail.com with ESMTPSA id n1sm475831pfu.28.2021.01.11.12.22.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jan 2021 12:22:51 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) From: Andrew Boyer In-Reply-To: <1605874101-30893-11-git-send-email-juraj.linkes@pantheon.tech> Date: Mon, 11 Jan 2021 15:22:49 -0500 Cc: Bruce Richardson , Ruifeng Wang , Honnappa.Nagarahalli@arm.com, Phil.Yang@arm.com, vcchunga@amazon.com, Dharmik.Thakkar@arm.com, jerinjacobk@gmail.com, hemant.agrawal@nxp.com, ajit.khaparde@broadcom.com, ferruh.yigit@intel.com, dev@dpdk.org Content-Transfer-Encoding: quoted-printable Message-Id: <8F5395F0-2B37-4150-8BF7-22FA66755179@pensando.io> References: <1605277875-13625-1-git-send-email-juraj.linkes@pantheon.tech> <1605874101-30893-1-git-send-email-juraj.linkes@pantheon.tech> <1605874101-30893-11-git-send-email-juraj.linkes@pantheon.tech> To: =?utf-8?Q?Juraj_Linke=C5=A1?= X-Mailer: Apple Mail (2.3608.120.23.2.4) Subject: Re: [dpdk-dev] [PATCH v13 10/12] build: disable libnuma in cross builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Nov 20, 2020, at 7:08 AM, Juraj Linke=C5=A1 = wrote: >=20 > Some Arm SoCs are not NUMA systems. Add the capability to disable NUMA > for cross build and disable NUMA in Arm cross files. >=20 > Signed-off-by: Juraj Linke=C5=A1 > Reviewed-by: Honnappa Nagarahalli > --- > config/arm/arm64_armada_linux_gcc | 1 + > config/arm/arm64_bluefield_linux_gcc | 1 + > config/arm/arm64_dpaa_linux_gcc | 1 + > config/arm/arm64_graviton2_linux_gcc | 1 + > config/arm/arm64_n1sdp_linux_gcc | 1 + > config/arm/arm64_octeontx2_linux_gcc | 1 + > config/arm/arm64_stingray_linux_gcc | 1 + > config/arm/meson.build | 2 -- > config/meson.build | 19 +++++++++++++------ > .../linux_gsg/cross_build_dpdk_for_arm64.rst | 4 ++++ > 10 files changed, 24 insertions(+), 8 deletions(-) >=20 > ... > diff --git a/config/meson.build b/config/meson.build > index 2bff6137f..9583be4ab 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -142,12 +142,19 @@ endif >=20 > # check for libraries used in multiple places in DPDK > has_libnuma =3D 0 > -numa_dep =3D cc.find_library('numa', required: false) > -if numa_dep.found() and cc.has_header('numaif.h') > - dpdk_conf.set10('RTE_HAS_LIBNUMA', true) > - has_libnuma =3D 1 > - add_project_link_arguments('-lnuma', language: 'c') > - dpdk_extra_ldflags +=3D '-lnuma' > +find_libnuma =3D true > +if meson.is_cross_build() and not meson.get_cross_property('numa', = true) > + # don't look for libnuma if explicitly disabled in cross build > + check_libnuma =3D false > +endif Looks like =E2=80=98check_libnuma=E2=80=99 should be =E2=80=98find_libnuma= =E2=80=99. There are no other references to =E2=80=98check_libnuma=E2=80=99= . -Andrew > +if find_libnuma > + numa_dep =3D cc.find_library('numa', required: false) > + if numa_dep.found() and cc.has_header('numaif.h') > + dpdk_conf.set10('RTE_HAS_LIBNUMA', true) > + has_libnuma =3D 1 > + add_project_link_arguments('-lnuma', language: 'c') > + dpdk_extra_ldflags +=3D '-lnuma' > + endif > endif >=20 > ...