From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 72A552E8B for ; Thu, 28 Apr 2016 07:45:19 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 27 Apr 2016 22:45:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,545,1455004800"; d="scan'208";a="794006505" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 27 Apr 2016 22:45:18 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 27 Apr 2016 22:45:17 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 27 Apr 2016 22:45:17 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.229]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.184]) with mapi id 14.03.0248.002; Thu, 28 Apr 2016 13:45:16 +0800 From: "Wang, Zhihong" To: Yuanhan Liu , "dev@dpdk.org" CC: "Xie, Huawei" Thread-Topic: [dpdk-dev] [PATCH 0/7] vhost/example cleanup/fix Thread-Index: AQHRn3ZEmIq89zqSqUOcZ6MZL/URXZ+e3Z9Q Date: Thu, 28 Apr 2016 05:45:16 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE09410342FBFF@SHSMSX103.ccr.corp.intel.com> References: <1461645951-14603-1-git-send-email-yuanhan.liu@linux.intel.com> In-Reply-To: <1461645951-14603-1-git-send-email-yuanhan.liu@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWQ2MmEzYzUtYTk0Mi00MjQxLThjOGEtNzlmOGVmNDZjMDkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ilp6clRVTTIzUFVXRmUxbmZQcDJiUlFyOVMzSHQ5ZzdqeEFFZk9xOEhkalU9In0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/7] vhost/example cleanup/fix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2016 05:45:19 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yuanhan Liu > Sent: Tuesday, April 26, 2016 12:46 PM > To: dev@dpdk.org > Cc: Xie, Huawei ; Yuanhan Liu > > Subject: [dpdk-dev] [PATCH 0/7] vhost/example cleanup/fix >=20 > I'm starting to work on the vhost ABI refactoring, that I also have to > touch the vhost example code, to make it work. The vhost example code, > however, is very messy, full of __very__ long lines. This would make > a later diff to apply the new vhost API be very ugly, therefore, not > friendly for review. This is how this cleanup comes. I think this patch is great effort to clean the messy code and make clearer logic, only one suggestion: do you think a complete cleanup would help more= ? in terms of code style and function organization. Since there'll be further= work on it, and it's a small file anyway. Currently some parts still seem messy = to me, which compromises the effort of this patch. >=20 > Besides that, there is one enhancement patch, which handles the broadcast > packets so that we could rely the ARP request packet, to let vhost-switch > be more like a real switch. There is another patch that (hopefully) would > fix the mbuf allocation failure ultimately. I also added some guidelines > there as comments to show how to count how many mbuf entries is enough fo= r > our usage. >=20 > --- > Yuanhan Liu (7): > examples/vhost: remove the non-working zero copy code > examples/vhost: remove unused macro and struct > examples/vhost: use tailq to link vhost devices > examples/vhost: use mac compare helper function directly > examples/vhost: handle broadcast packet > examples/vhost: fix mbuf allocation failures > examples/vhost: switch_worker cleanup >=20 > doc/guides/sample_app_ug/vhost.rst | 36 +- > examples/vhost/main.c | 2319 ++++++------------------------= ------ > examples/vhost/main.h | 49 +- > 3 files changed, 375 insertions(+), 2029 deletions(-) >=20 > -- > 1.9.0