From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A744B2C12 for ; Thu, 26 May 2016 04:40:40 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 25 May 2016 19:40:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,366,1459839600"; d="scan'208";a="962522815" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 25 May 2016 19:40:37 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 25 May 2016 19:40:36 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 25 May 2016 19:40:36 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.58]) by SHSMSX152.ccr.corp.intel.com ([10.239.6.52]) with mapi id 14.03.0248.002; Thu, 26 May 2016 10:40:02 +0800 From: "Wang, Zhihong" To: Thomas Monjalon CC: "dev@dpdk.org" , "Ananyev, Konstantin" , "Richardson, Bruce" , "De Lara Guarch, Pablo" Thread-Topic: [PATCH 1/6] testpmd: add io_retry forwarding Thread-Index: AQHRp1t5bWZZqQmXmEy1banZ795YMJ/I+8+AgAGjAUA= Date: Thu, 26 May 2016 02:40:01 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE09411074370A@SHSMSX103.ccr.corp.intel.com> References: <1462488421-118990-1-git-send-email-zhihong.wang@intel.com> <1462488421-118990-2-git-send-email-zhihong.wang@intel.com> <2292380.hL3i5NyNHm@xps13> In-Reply-To: <2292380.hL3i5NyNHm@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTNlNTkyZmQtMGI5MC00YTljLTg5OTctMWYzMzYzZjNiZTAzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImdWd3J1OVRmdHFqWFN4anJHeHNnYWNJXC93TWV2SmU4dkRURkkzMUxoUlg0PSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/6] testpmd: add io_retry forwarding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2016 02:40:41 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, May 25, 2016 5:32 PM > To: Wang, Zhihong > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Richardson, Bruce ; De Lara Guarch, Pablo > > Subject: Re: [PATCH 1/6] testpmd: add io_retry forwarding >=20 > 2016-05-05 18:46, Zhihong Wang: > > --- a/app/test-pmd/testpmd.h > > +++ b/app/test-pmd/testpmd.h > > extern struct fwd_engine io_fwd_engine; > > +extern struct fwd_engine io_retry_fwd_engine; > > extern struct fwd_engine mac_fwd_engine; > > extern struct fwd_engine mac_retry_fwd_engine; > > extern struct fwd_engine mac_swap_engine; >=20 > We now have 2 engines with "retry" behaviour. > It is maybe the way to go, but I want to ask the question: > Would it be possible to have "retry" as an engine parameter? >=20 If it's just about the way to write commands there isn't much difference, like "set fwd io_rety" and "set fwd io retry". Do you mean to add the "retry" for all engines, and also implement this as a parameter in each original engine? So for example, no iofwd-retry.c, just add this feature inside iofwd.c?