From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 06A922BC6 for ; Thu, 26 May 2016 11:31:44 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 26 May 2016 02:31:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,367,1459839600"; d="scan'208";a="974882713" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 26 May 2016 02:31:44 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 26 May 2016 02:31:43 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 26 May 2016 02:31:43 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.58]) by shsmsx102.ccr.corp.intel.com ([169.254.2.104]) with mapi id 14.03.0248.002; Thu, 26 May 2016 17:31:41 +0800 From: "Wang, Zhihong" To: Thomas Monjalon CC: "dev@dpdk.org" , "Ananyev, Konstantin" , "Richardson, Bruce" , "De Lara Guarch, Pablo" Thread-Topic: [PATCH 2/6] testpmd: configurable tx_first burst number Thread-Index: AQHRp1t5KylxnFmvj0uiV1pomTNyG5/I/KcAgAGkjSD//7qQgIAAtm1Q Date: Thu, 26 May 2016 09:31:41 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE09411074399C@SHSMSX103.ccr.corp.intel.com> References: <1462488421-118990-1-git-send-email-zhihong.wang@intel.com> <1511439.3kRGpiG3WX@xps13> <8F6C2BD409508844A0EFC19955BE094110743728@SHSMSX103.ccr.corp.intel.com> <1640688.ZKKLjeEMeZ@xps13> In-Reply-To: <1640688.ZKKLjeEMeZ@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzQ4NWYzOWItMDdiOS00ZWJiLWI4ODMtZjZiNTc3NDQ3NjkwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjExZVBvcWx0dDlydHY3d2pub2Yyd0RkTkFWZVwvYWxVSGV5XC94QVlKUjFXZz0ifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/6] testpmd: configurable tx_first burst number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2016 09:31:45 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, May 26, 2016 2:32 PM > To: Wang, Zhihong > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Richardson, Bruce ; De Lara Guarch, Pablo > > Subject: Re: [PATCH 2/6] testpmd: configurable tx_first burst number >=20 > 2016-05-26 02:53, Wang, Zhihong: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2016-05-05 18:46, Zhihong Wang: > > > > This patch enables configurable tx_first burst number. > > > > > > > > Use "start tx_first (burst_num)" to specify how many bursts of pack= ets to > > > > be sent before forwarding start, or "start tx_first" like before fo= r the > > > > default 1 burst send. > > > > > > The idea here is to fill the loopback latency gap with bursts. > > > Would it be possible to make it automatic by detecting the first > > > received packets to stop Tx generator? > > > > The idea is great! The implementation might not be graceful though > > -- current tx_first mode first calls txonly engine before calling the > > actual engine, say iofwd, so iofwd is not established before tx_first > > is done, therefore no detection. >=20 > And what about rewriting tx_first? > No strong opinion. I let you and Pablo decide. >=20 I think the current way is better in terms of simplicity and flexibility. Also this "fill the ring" criteria doesn't fit other test scenarios, it's just for this loop back test, but tx_first is for all scenarios. > > It's possible to do this, but we need to implement another forward > > engine like "io_retry_fill_first" alone, it complicates testpmd just fo= r > > this loop back test. > > > > Looks to me it's better to use combination of existing fwd engines to > > do this, it's also more flexible with burst number parameters.