From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id CF25AADAA for ; Wed, 8 Jun 2016 03:29:36 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 07 Jun 2016 18:29:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,436,1459839600"; d="scan'208";a="982984671" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 07 Jun 2016 18:29:37 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 7 Jun 2016 18:29:35 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.107]) with mapi id 14.03.0248.002; Wed, 8 Jun 2016 09:29:34 +0800 From: "Wang, Zhihong" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "Richardson, Bruce" , "thomas.monjalon@6wind.com" Thread-Topic: [PATCH v2 1/5] testpmd: add retry option Thread-Index: AQHRu/EZLYewdB/NI0+Vgtbe7pZgUJ/dP8oAgAGSn4A= Date: Wed, 8 Jun 2016 01:29:33 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE09411075A2A4@SHSMSX103.ccr.corp.intel.com> References: <1462488421-118990-1-git-send-email-zhihong.wang@intel.com> <1464751663-135211-1-git-send-email-zhihong.wang@intel.com> <1464751663-135211-2-git-send-email-zhihong.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjYwZmM5MDAtNjQ4Ny00NGYyLTk5ZTUtYzAwY2NlYjg0YWQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im9TRW5uYXNvblBXUVNGU2JDRzYxandmdWF3d3hnVE4yOWVSTUkwZEhDcWM9In0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/5] testpmd: add retry option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2016 01:29:37 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Tuesday, June 7, 2016 5:28 PM > To: Wang, Zhihong ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Richardson, Bruce > ; thomas.monjalon@6wind.com > Subject: RE: [PATCH v2 1/5] testpmd: add retry option >=20 >=20 >=20 > > -----Original Message----- > > From: Wang, Zhihong > > Sent: Wednesday, June 01, 2016 4:28 AM > > To: dev@dpdk.org > > Cc: Ananyev, Konstantin; Richardson, Bruce; De Lara Guarch, Pablo; > > thomas.monjalon@6wind.com; Wang, Zhihong > > Subject: [PATCH v2 1/5] testpmd: add retry option > > > > This patch adds retry option in testpmd to prevent most packet losses. > > It can be enabled by "set fwd retry". All modes except rxonly > > support this option. > > > > Adding retry mechanism expands test case coverage to support scenarios > > where packet loss affects test results. > > > > > > Signed-off-by: Zhihong Wang >=20 > ... >=20 > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > @@ -249,8 +249,10 @@ set fwd > > > > Set the packet forwarding mode:: > > > > - testpmd> set fwd (io|mac|mac_retry|macswap|flowgen| \ > > - rxonly|txonly|csum|icmpecho) > > + testpmd> set fwd (io|mac|macswap|flowgen| \ > > + rxonly|txonly|csum|icmpecho) (""|retry) > > + > > +``retry`` can be specified for forwarding engines except ``rx_only``. > > > > The available information categories are: > > > > @@ -260,8 +262,6 @@ The available information categories are: > > > > * ``mac``: Changes the source and the destination Ethernet addresses o= f > > packets before forwarding them. > > > > -* ``mac_retry``: Same as "mac" forwarding mode, but includes retries i= f the > > destination queue is full. > > - > > * ``macswap``: MAC swap forwarding mode. > > Swaps the source and the destination Ethernet addresses of packets > before > > forwarding them. > > > > @@ -392,7 +392,7 @@ Set number of packets per burst:: > > > > This is equivalent to the ``--burst command-line`` option. > > > > -In ``mac_retry`` forwarding mode, the transmit delay time and number o= f > > retries can also be set:: > > +When retry is enabled, the transmit delay time and number of retries c= an > > also be set:: > > > > testpmd> set burst tx delay (micrseconds) retry (num) >=20 > Could you fix the typo "micrseconds" in this patch? Sure ;) >=20 > > > > -- > > 2.5.0 >=20 > Apart from this, >=20 > Acked-by: Pablo de Lara