From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 848262951 for ; Wed, 24 Aug 2016 05:37:08 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 23 Aug 2016 20:37:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,569,1464678000"; d="scan'208";a="1019389770" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 23 Aug 2016 20:37:07 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 23 Aug 2016 20:37:06 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 23 Aug 2016 20:37:06 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.194]) with mapi id 14.03.0301.000; Wed, 24 Aug 2016 11:37:04 +0800 From: "Wang, Zhihong" To: Thomas Monjalon , Maxime Coquelin , "yuanhan.liu@linux.intel.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue Thread-Index: AQHR+hh5PoNiMS5qakKA1d8du6AZMqBUHzGAgAAe5YCAAAlJgIADNMtg Date: Wed, 24 Aug 2016 03:37:03 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE094110775CA8@SHSMSX103.ccr.corp.intel.com> References: <1471319402-112998-1-git-send-email-zhihong.wang@intel.com> <2a5320b9-c9dd-f7e3-e659-7d14cd1e5620@redhat.com> <1565135.2L3BcyTl7O@xps13> In-Reply-To: <1565135.2L3BcyTl7O@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2016 03:37:09 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, August 22, 2016 6:35 PM > To: Maxime Coquelin ; Wang, Zhihong > ; yuanhan.liu@linux.intel.com > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue >=20 > 2016-08-22 12:01, Maxime Coquelin: > > I forgot to add that before this series, I think we should first fix th= e > windows bug. > > Else we will need a dedicated fix for the stable branch. >=20 > This is a funny situation :) > If Zhihong had reworked the code without mentioning it is fixing a scenar= io > with Windows guests, maybe that nobody would have notice ;) That's > probably why it is not written in v2/v3. But thanks to the v1, we all kno= w it: > "It also fixes the issue working with Windows VMs." I thought it'd be more appropriate to send a dedicated fix for stable branc= h. So I removed this info. >=20 > So yes, it would be a lot better to find the root cause and try to have a > minimal fix for 16.07, then rework the code for performance in 16.11. > I think we must avoid silent fixes, and even more, avoid writing specific= fixes > for stable branches without validating them in the master branch and its = large > users base. Okay, that's also what Maxime and Yuanhan suggest. BTW the root cause has been identified and fix will be in v4. >=20 > Thanks for your good works guys, DPDK vhost is improving very well.