From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 95C282BF7 for ; Fri, 14 Oct 2016 09:24:45 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 14 Oct 2016 00:24:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,491,1473145200"; d="scan'208";a="179741070" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 14 Oct 2016 00:24:44 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 14 Oct 2016 00:24:44 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 14 Oct 2016 00:24:43 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Fri, 14 Oct 2016 15:24:40 +0800 From: "Wang, Zhihong" To: Maxime Coquelin , "yuanhan.liu@linux.intel.com" , "Xie, Huawei" , "dev@dpdk.org" CC: "vkaplans@redhat.com" , "mst@redhat.com" , "stephen@networkplumber.org" Thread-Topic: [dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path Thread-Index: AQHSGJsuPULF2YwoOkWK68sRWtMF+6CnouKw Date: Fri, 14 Oct 2016 07:24:39 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE09414E7CE6D1@SHSMSX103.ccr.corp.intel.com> References: <1474619303-16709-1-git-send-email-maxime.coquelin@redhat.com> <1474965769-24782-1-git-send-email-maxime.coquelin@redhat.com> In-Reply-To: <1474965769-24782-1-git-send-email-maxime.coquelin@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2016 07:24:46 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Tuesday, September 27, 2016 4:43 PM > To: yuanhan.liu@linux.intel.com; Xie, Huawei ; > dev@dpdk.org > Cc: vkaplans@redhat.com; mst@redhat.com; > stephen@networkplumber.org; Maxime Coquelin > > Subject: [dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to > the TX path >=20 > Indirect descriptors are usually supported by virtio-net devices, > allowing to dispatch a larger number of requests. >=20 > When the virtio device sends a packet using indirect descriptors, > only one slot is used in the ring, even for large packets. >=20 > The main effect is to improve the 0% packet loss benchmark. > A PVP benchmark using Moongen (64 bytes) on the TE, and testpmd > (fwd io for host, macswap for VM) on DUT shows a +50% gain for > zero loss. >=20 > On the downside, micro-benchmark using testpmd txonly in VM and > rxonly on host shows a loss between 1 and 4%.i But depending on > the needs, feature can be disabled at VM boot time by passing > indirect_desc=3Doff argument to vhost-user device in Qemu. >=20 > Signed-off-by: Maxime Coquelin Hi Maxime, Seems this patch can't with Windows virtio guest in my test. Have you done similar tests before? The way I test: 1. Make sure https://patchwork.codeaurora.org/patch/84339/ is applied 2. Start testpmd with iofwd between 2 vhost ports 3. Start 2 Windows guests connected to the 2 vhost ports 4. Disable firewall and assign IP to each guest using ipconfig 5. Use ping to test connectivity When I disable this patch by setting: 0ULL << VIRTIO_RING_F_INDIRECT_DESC, the connection is fine, but when I restore: 1ULL << VIRTIO_RING_F_INDIRECT_DESC, the connection is broken. Thanks Zhihong