From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A6306152A for ; Mon, 9 Jan 2017 06:29:46 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 08 Jan 2017 21:29:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="1080736378" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 08 Jan 2017 21:29:45 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 8 Jan 2017 21:29:44 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 8 Jan 2017 21:29:44 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Mon, 9 Jan 2017 13:29:42 +0800 From: "Wang, Zhihong" To: Thomas Monjalon , Ravi Kerur CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions Thread-Index: AQHReMVAwLpgxle4AUi4lce7uR+4BZ/LY3twgBFoO4CAAZnDwIFIk/iAgApsFiA= Date: Mon, 9 Jan 2017 05:29:42 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE0941512003E4@SHSMSX103.ccr.corp.intel.com> References: <1457391583-29604-1-git-send-email-rkerur@gmail.com> <8F6C2BD409508844A0EFC19955BE094110759EFE@SHSMSX103.ccr.corp.intel.com> <1828046.HL686xpgu5@xps13> In-Reply-To: <1828046.HL686xpgu5@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 05:29:47 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, January 3, 2017 4:41 AM > To: Wang, Zhihong ; Ravi Kerur > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp > functions >=20 > 2016-06-07 11:09, Wang, Zhihong: > > From: Ravi Kerur [mailto:rkerur@gmail.com] > > > Zhilong, Thomas, > > > > > > If there is enough interest within DPDK community I can work on addin= g > support > > > for 'unaligned access' and 'test cases' for it. Please let me know ei= ther > way. > > > > Hi Ravi, > > > > This rte_memcmp is proved with better performance than glibc's in align= ed > > cases, I think it has good value to DPDK lib. > > > > Though we don't have memcmp in critical pmd data path, it offers a bett= er > > choice for applications who do. >=20 > Re-thinking about this series, could it be some values to have a rte_memc= mp > implementation? I think this series (rte_memcmp included) could help: 1. Potentially better performance in hot paths. 2. Agile for tuning. 3. Avoid performance complications -- unusual but possible, like the glibc memset issue I met while working on vhost enqueue. > What is the value compared to glibc one? Why not working on glibc? As to working on glibc, wider design consideration and test coverage might be needed, and we'll face different release cycles, can we have the same agility? Also working with old glibc could be a problem.