From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 27B5F58EC for ; Thu, 27 Apr 2017 11:18:27 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2017 02:18:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,383,1488873600"; d="scan'208";a="1161610920" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 27 Apr 2017 02:18:26 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 27 Apr 2017 02:18:26 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 27 Apr 2017 02:18:25 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by shsmsx102.ccr.corp.intel.com ([169.254.2.246]) with mapi id 14.03.0319.002; Thu, 27 Apr 2017 17:18:22 +0800 From: "Wang, Zhihong" To: Thomas Monjalon , "Richardson, Bruce" CC: "dev@dpdk.org" , "yuanhan.liu@linux.intel.com" Thread-Topic: [dpdk-dev] [PATCH] config: make AVX and AVX512 configurable Thread-Index: AQHSvweBfWoQ6HbgMkKSxsKxwOZsxqHYZ10AgACGoEA= Date: Thu, 27 Apr 2017 09:18:21 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE09415126F7FE@SHSMSX103.ccr.corp.intel.com> References: <1493310859-49106-1-git-send-email-zhihong.wang@intel.com> <2616350.yKybQRU0rL@xps> In-Reply-To: <2616350.yKybQRU0rL@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] config: make AVX and AVX512 configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 09:18:27 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, April 27, 2017 5:08 PM > To: Wang, Zhihong ; Richardson, Bruce > > Cc: dev@dpdk.org; yuanhan.liu@linux.intel.com > Subject: Re: [dpdk-dev] [PATCH] config: make AVX and AVX512 configurable >=20 > 27/04/2017 18:34, Zhihong Wang: > > Making AVX and AVX512 configurable is useful for performance and power > > testing. > > > > The similar kernel patch at https://patchwork.kernel.org/patch/9618883/= . > [...] > > +# > > +# Recognize/ignore the AVX/AVX512 CPU flags for performance/power > testing > > +# > > +CONFIG_RTE_ENABLE_AVX=3Dy > > +CONFIG_RTE_ENABLE_AVX512=3Dn >=20 > It is disabling AVX512 in default configuration. > Please explain this behaviour change. Though AVX512 rte_memcpy has been in DPDK for quite a while it's still unproven in hardware with rich use cases. Mark it as experimental for now, user can enable it for their own testing. Will enable it with enough field tests and possible optimization. Should I add the explanation in commit log, or comments in the source, or both?