From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4D7439E3 for ; Thu, 27 Apr 2017 12:03:46 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2017 03:03:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,383,1488873600"; d="scan'208";a="92794137" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 27 Apr 2017 03:03:45 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 27 Apr 2017 03:03:45 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 27 Apr 2017 03:03:44 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.217]) with mapi id 14.03.0319.002; Thu, 27 Apr 2017 18:03:42 +0800 From: "Wang, Zhihong" To: Thomas Monjalon CC: "Richardson, Bruce" , "dev@dpdk.org" , "yuanhan.liu@linux.intel.com" Thread-Topic: [dpdk-dev] [PATCH] config: make AVX and AVX512 configurable Thread-Index: AQHSvweBfWoQ6HbgMkKSxsKxwOZsxqHYZ10AgACGoED//3zVAIAAkfpA Date: Thu, 27 Apr 2017 10:03:42 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE09415126F8CB@SHSMSX103.ccr.corp.intel.com> References: <1493310859-49106-1-git-send-email-zhihong.wang@intel.com> <2616350.yKybQRU0rL@xps> <8F6C2BD409508844A0EFC19955BE09415126F7FE@SHSMSX103.ccr.corp.intel.com> <1558565.2fZJ5xpf6Y@xps> In-Reply-To: <1558565.2fZJ5xpf6Y@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] config: make AVX and AVX512 configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 10:03:46 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, April 27, 2017 5:20 PM > To: Wang, Zhihong > Cc: Richardson, Bruce ; dev@dpdk.org; > yuanhan.liu@linux.intel.com > Subject: Re: [dpdk-dev] [PATCH] config: make AVX and AVX512 configurable >=20 > 27/04/2017 11:18, Wang, Zhihong: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 27/04/2017 18:34, Zhihong Wang: > > > > Making AVX and AVX512 configurable is useful for performance and > power > > > > testing. > > > > > > > > The similar kernel patch at > https://patchwork.kernel.org/patch/9618883/. > > > [...] > > > > +# > > > > +# Recognize/ignore the AVX/AVX512 CPU flags for > performance/power > > > testing > > > > +# > > > > +CONFIG_RTE_ENABLE_AVX=3Dy > > > > +CONFIG_RTE_ENABLE_AVX512=3Dn > > > > > > It is disabling AVX512 in default configuration. > > > Please explain this behaviour change. > > > > Though AVX512 rte_memcpy has been in DPDK for quite a while it's still > > unproven in hardware with rich use cases. Mark it as experimental for > > now, user can enable it for their own testing. > > > > Will enable it with enough field tests and possible optimization. > > > > Should I add the explanation in commit log, or comments in the source, > > or both? >=20 > Yes please, add the explanation in the commit log and experimental > comment > in the config. Thanks a lot! It's included in v2.