From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8E0822BAC for ; Fri, 26 May 2017 06:35:24 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 May 2017 21:35:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,395,1491289200"; d="scan'208";a="266588261" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 25 May 2017 21:35:21 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 May 2017 21:35:20 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 May 2017 21:35:20 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.217]) with mapi id 14.03.0319.002; Fri, 26 May 2017 12:35:18 +0800 From: "Wang, Zhihong" To: Yuanhan Liu , Jens Freimann CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] vhost: support rx_queue_count Thread-Index: AQHS0tHORjPuuZeLM0yQLuDyWcgEJqIBSqqAgACWVUCAAL68gIAABhGAgAAB5wCAA2VwsA== Date: Fri, 26 May 2017 04:35:18 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE094151280580@SHSMSX103.ccr.corp.intel.com> References: <1495483268-60184-1-git-send-email-zhihong.wang@intel.com> <20170523115335.gtykyluswrsjuls3@dhcp-192-218.str.redhat.com> <8F6C2BD409508844A0EFC19955BE09415127D9EE@SHSMSX103.ccr.corp.intel.com> <20170524081419.GU2276@yliu-dev> <20170524083601.sd7sueoskpfeyxt7@dhcp-192-218.str.redhat.com> <20170524084250.GW2276@yliu-dev> In-Reply-To: <20170524084250.GW2276@yliu-dev> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] vhost: support rx_queue_count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 May 2017 04:35:25 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Wednesday, May 24, 2017 4:43 PM > To: Jens Freimann > Cc: Wang, Zhihong ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] vhost: support rx_queue_count >=20 > On Wed, May 24, 2017 at 10:36:01AM +0200, Jens Freimann wrote: > > On Wed, May 24, 2017 at 04:14:19PM +0800, Yuanhan Liu wrote: > > > On Tue, May 23, 2017 at 12:51:56PM +0000, Wang, Zhihong wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > From: Jens Freimann [mailto:jfreiman@redhat.com] > > > > > Sent: Tuesday, May 23, 2017 7:54 PM > > > > > To: Wang, Zhihong > > > > > Cc: dev@dpdk.org; yuanhan.liu@linux.intel.com > > > > > Subject: Re: [dpdk-dev] [PATCH] vhost: support rx_queue_count > > > > > > > > > > On Mon, May 22, 2017 at 04:01:08PM -0400, Zhihong Wang wrote: > > > > > > This patch implements the ops rx_queue_count for vhost PMD by > adding > > > > > > a helper function rte_vhost_rx_queue_count in vhost lib. > > > > > > > > > > > > The ops ops rx_queue_count gets vhost RX queue avail count and > helps > > > > > > > > > > s/ops ops/ops/ ? > > > > > > > > Thanks a lot! > > > > > > Seems you overlooked other comments, such as: > > > > > > > > > + vq =3D dev->virtqueue[qid]; > > > > > > > > > > check for vq =3D=3D NULL? > > > > > > > > > > regards, > > > > > Jens > > > > > > Besides, Jens, I'm not a big fan of "dev =3D=3D NULL" over "!dev". I = accept > > > both :) > > > > Personally I'm with you on this, but it says different in > http://dpdk.org/doc/guides/contributing/coding_style.html > > Anyway, up to you :) >=20 > Yes, I know that. To make every body happy, I would suggset you to > follow the coding style. But if you have already choosen another way, > I won't bother to ask you do the change. Unless, it becomes a must > in future. Thanks Yuanhan and Jens! Will address these comments in v3. >=20 > --yliu