Re: [PATCH] vhost: cleanup vq resubmit info when set_inflight_fd

[Maxime Coquelin <maxime.coquelin@redhat.com>]

Hi Haoqian,

We try to avoid passing functions or variable names in the commit title.
Maybe something like this would work:
"vhost: cleanup resubmit info before inflight setup"

On 3/21/24 10:57, Haoqian He wrote:
> We should cleanup vq resubmit info when set_inflight_fd

virtqueue*

> before set_vring_kick which will check if there is any
> inflight io waiting for resubmission.

IO

> 
> Otherwise, when the vm is rebooting immediately after

VM

> reconnecting to the vhost target (inflight io has not
> been resubmitted yet), the vhost backend still use the

uses

> old resubmit info set when reconnection.

reconnecting

> 

You need to add "Fixes:" tag pointing to the commit introducing the 
issue, so that it is backported in stable releases.

This is documented in the contribution guidelines if you have any doubt
on the formatting.

> Signed-off-by: Haoqian He <haoqian.he@smartx.com>
> ---
>   lib/vhost/vhost_user.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 414192500e..7c54afc5fb 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -1871,6 +1871,7 @@ vhost_user_set_inflight_fd(struct virtio_net **pdev,
>   		if (!vq)
>   			continue;
>   
> +		cleanup_vq_inflight(dev, vq);
>   		if (vq_is_packed(dev)) {
>   			vq->inflight_packed = addr;
>   			vq->inflight_packed->desc_num = queue_size;