From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55AE3A0C45; Mon, 14 Jun 2021 19:05:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 122784067E; Mon, 14 Jun 2021 19:05:20 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id CB4784067A for ; Mon, 14 Jun 2021 19:05:18 +0200 (CEST) Received: from [192.168.1.71] (unknown [188.170.85.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id A7B3D7F514; Mon, 14 Jun 2021 20:05:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru A7B3D7F514 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1623690318; bh=Kz25eJC9qs/bTyWJxmG/59ccMHiLatDwKO3rU3+ib6o=; h=Subject:To:References:From:Date:In-Reply-To; b=kOTJ5FezPoIFav8Bz7C825th2FvY3sz2RT5ZQ2T1PgVh+HiSIBJIyskn2KkWq863U wr2tCpJVqMjJXgj87LWno6Po26iQUrTGwp6nH2uIvgF3a1zNQHPl9LFjZck+38nJoW 6w0LXRVCWGMT3l/1qku+QQk61bmGDILDS3PJz7nY= To: Jiawen Wu , dev@dpdk.org References: <20210602094108.1575640-1-jiawenwu@trustnetic.com> <20210602094108.1575640-2-jiawenwu@trustnetic.com> From: Andrew Rybchenko Message-ID: <8a23e3a1-74ae-9fae-af1c-e06415cd4950@oktetlabs.ru> Date: Mon, 14 Jun 2021 20:05:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210602094108.1575640-2-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 01/24] net/ngbe: add build and doc infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/2/21 12:40 PM, Jiawen Wu wrote: > Adding bare minimum PMD library and doc build infrastructure > and claim the maintainership for ngbe PMD. > > Signed-off-by: Jiawen Wu > --- > MAINTAINERS | 6 ++++++ > doc/guides/nics/features/ngbe.ini | 10 +++++++++ > doc/guides/nics/index.rst | 1 + > doc/guides/nics/ngbe.rst | 28 ++++++++++++++++++++++++++ > doc/guides/rel_notes/release_21_08.rst | 6 ++++++ > drivers/net/meson.build | 1 + > drivers/net/ngbe/meson.build | 12 +++++++++++ > drivers/net/ngbe/ngbe_ethdev.c | 5 +++++ > drivers/net/ngbe/ngbe_ethdev.h | 5 +++++ > drivers/net/ngbe/version.map | 3 +++ > 10 files changed, 77 insertions(+) > create mode 100644 doc/guides/nics/features/ngbe.ini > create mode 100644 doc/guides/nics/ngbe.rst > create mode 100644 drivers/net/ngbe/meson.build > create mode 100644 drivers/net/ngbe/ngbe_ethdev.c > create mode 100644 drivers/net/ngbe/ngbe_ethdev.h > create mode 100644 drivers/net/ngbe/version.map > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5877a16971..04672f6eaa 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -903,6 +903,12 @@ F: drivers/net/txgbe/ > F: doc/guides/nics/txgbe.rst > F: doc/guides/nics/features/txgbe.ini > > +Wangxun ngbe > +M: Jiawen Wu > +F: drivers/net/ngbe/ > +F: doc/guides/nics/ngbe.rst > +F: doc/guides/nics/features/ngbe.ini > + Because of alphabetical order (n before t), it should go just beforenet/txgbe. > VMware vmxnet3 > M: Yong Wang > F: drivers/net/vmxnet3/ > diff --git a/doc/guides/nics/features/ngbe.ini b/doc/guides/nics/features/ngbe.ini > new file mode 100644 > index 0000000000..a7a524defc > --- /dev/null > +++ b/doc/guides/nics/features/ngbe.ini > @@ -0,0 +1,10 @@ > +; > +; Supported features of the 'ngbe' network poll mode driver. > +; > +; Refer to default.ini for the full list of available PMD features. > +; > +[Features] > +Linux = Y > +ARMv8 = Y > +x86-32 = Y > +x86-64 = Y > diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst > index 799697caf0..31a3e6bcdc 100644 > --- a/doc/guides/nics/index.rst > +++ b/doc/guides/nics/index.rst > @@ -47,6 +47,7 @@ Network Interface Controller Drivers > netvsc > nfb > nfp > + ngbe > null > octeontx > octeontx2 > diff --git a/doc/guides/nics/ngbe.rst b/doc/guides/nics/ngbe.rst > new file mode 100644 > index 0000000000..4ec2623a05 > --- /dev/null > +++ b/doc/guides/nics/ngbe.rst > @@ -0,0 +1,28 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright(c) 2018-2020 Beijing WangXun Technology Co., Ltd. > + > +NGBE Poll Mode Driver > +====================== > + > +The NGBE PMD (librte_pmd_ngbe) provides poll mode driver support > +for Wangxun 1 Gigabit Ethernet NICs. > + > +Prerequisites > +------------- > + > +- Learning about Wangxun 1 Gigabit Ethernet NICs using > + ``_. > + > +- Follow the DPDK :ref:`Getting Started Guide for Linux ` to setup the basic DPDK environment. > + > +Driver compilation and testing > +------------------------------ > + > +Refer to the document :ref:`compiling and testing a PMD for a NIC ` > +for details. > + > +Limitations or Known issues > +--------------------------- > + > +Build with ICC is not supported yet. > +Power8, ARMv7 and BSD are not supported yet. > diff --git a/doc/guides/rel_notes/release_21_08.rst b/doc/guides/rel_notes/release_21_08.rst > index a6ecfdf3ce..2deac4f398 100644 > --- a/doc/guides/rel_notes/release_21_08.rst > +++ b/doc/guides/rel_notes/release_21_08.rst > @@ -55,6 +55,12 @@ New Features > Also, make sure to start the actual text at the margin. > ======================================================= > > +* **Added Wangxun ngbe PMD.** > + > + Added a new PMD driver for Wangxun 1 Gigabit Ethernet NICs. > + > + See the :doc:`../nics/ngbe` for more details. > + > > Removed Items > ------------- > diff --git a/drivers/net/meson.build b/drivers/net/meson.build > index c8b5ce2980..d6c1751540 100644 > --- a/drivers/net/meson.build > +++ b/drivers/net/meson.build > @@ -40,6 +40,7 @@ drivers = [ > 'netvsc', > 'nfb', > 'nfp', > + 'ngbe', > 'null', > 'octeontx', > 'octeontx2', > diff --git a/drivers/net/ngbe/meson.build b/drivers/net/ngbe/meson.build > new file mode 100644 > index 0000000000..de2d7be716 > --- /dev/null > +++ b/drivers/net/ngbe/meson.build > @@ -0,0 +1,12 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2018-2020 Beijing WangXun Technology Co., Ltd. > + > +if is_windows > + build = false > + reason = 'not supported on Windows' > + subdir_done() > +endif > + > +sources = files( > + 'ngbe_ethdev.c', > +) > diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c > new file mode 100644 > index 0000000000..e424ff11a2 > --- /dev/null > +++ b/drivers/net/ngbe/ngbe_ethdev.c > @@ -0,0 +1,5 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018-2020 Beijing WangXun Technology Co., Ltd. > + * Copyright(c) 2010-2017 Intel Corporation > + */ > + I strongly dislike empty files with just copyrights. At least dummy (always fail) probe/remove should be in the first patch. > diff --git a/drivers/net/ngbe/ngbe_ethdev.h b/drivers/net/ngbe/ngbe_ethdev.h > new file mode 100644 > index 0000000000..e424ff11a2 > --- /dev/null > +++ b/drivers/net/ngbe/ngbe_ethdev.h > @@ -0,0 +1,5 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018-2020 Beijing WangXun Technology Co., Ltd. > + * Copyright(c) 2010-2017 Intel Corporation > + */ > + Same here > diff --git a/drivers/net/ngbe/version.map b/drivers/net/ngbe/version.map > new file mode 100644 > index 0000000000..4a76d1d52d > --- /dev/null > +++ b/drivers/net/ngbe/version.map > @@ -0,0 +1,3 @@ > +DPDK_21 { > + local: *; > +}; >