From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by dpdk.org (Postfix) with ESMTP id 297C32BB9
for <dev@dpdk.org>; Fri, 9 Jun 2017 13:24:59 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
09 Jun 2017 04:24:58 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.39,317,1493708400"; d="scan'208";a="96280100"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91])
([10.237.220.91])
by orsmga004.jf.intel.com with ESMTP; 09 Jun 2017 04:24:57 -0700
To: Shijith Thotton <shijith.thotton@caviumnetworks.com>, dev@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>
References: <1496920971-9400-1-git-send-email-shijith.thotton@caviumnetworks.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <8a2d812e-846b-73fd-4418-6da5738005d5@intel.com>
Date: Fri, 9 Jun 2017 12:24:56 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <1496920971-9400-1-git-send-email-shijith.thotton@caviumnetworks.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/liquidio: do not touch mbuf initialized
fields
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Jun 2017 11:25:00 -0000
On 6/8/2017 12:22 PM, Shijith Thotton wrote:
> Avoid re-initializing of mbuf fields which are set while in pool.
> Replaced lio_recv_buffer_alloc with rte_pktmbuf_alloc.
>
> See commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool").
>
> Signed-off-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
<...>
> @@ -489,9 +466,6 @@
> droq->refill_count++;
>
> if (likely(nicbuf != NULL)) {
> - nicbuf->data_off = RTE_PKTMBUF_HEADROOM;
Hi Shijith, Olivier,
nb_segs and next are initialized properly when mbuf allocated, but is
"data_off = RTE_PKTMBUF_HEADROOM" guaranteed?
> - nicbuf->nb_segs = 1;
> - nicbuf->next = NULL;
> /* We don't have a way to pass flags yet */
> nicbuf->ol_flags = 0;
> if (rh->r_dh.has_hash) {
<...>