From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE769A0521; Tue, 3 Nov 2020 13:18:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8015FC974; Tue, 3 Nov 2020 13:18:58 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E57D2C96C for ; Tue, 3 Nov 2020 13:18:55 +0100 (CET) IronPort-SDR: HqIhXnZgr5gG/LQiTh64sTzUpc0FMwF0RZ0EpNmu/d2REPk1czqM3rRApxr1NeGDjrhahlWtf0 OFGY/c/1Xqpg== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="169147551" X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="169147551" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 04:18:54 -0800 IronPort-SDR: Wvgz6cROonJbyuBTWIZZiRs6luZS9Es8ggG4l6EU3mxRO2+D+J+x1H53BcOxCanLht/HiDhE+0 yf4W+Rm9u9RQ== X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="538469379" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.178]) ([10.213.218.178]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 04:18:53 -0800 To: oulijun Cc: dev@dpdk.org, linuxarm@huawei.com References: <1604327899-60126-1-git-send-email-oulijun@huawei.com> <1604327899-60126-8-git-send-email-oulijun@huawei.com> <44cc36e0-c554-f717-953a-fe0d0ea259bc@intel.com> From: Ferruh Yigit Message-ID: <8a3669ae-25ad-6cd3-78f2-c84910a26a6f@intel.com> Date: Tue, 3 Nov 2020 12:18:51 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 7/8] net/hns3: fix some static check errors by coverity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/2020 12:11 PM, oulijun wrote: > > > 在 2020/11/3 19:41, Ferruh Yigit 写道: >> On 11/2/2020 2:38 PM, Lijun Ou wrote: >>> From: Hongbo Zheng >>> >>> This patch fixes some warnings. >>> coverity:function format symbol does not match >> >> I think we are not getting these warnings in the public coverity, is there a >> specific configuration for it? >> > Yes, the coverity scan is configured internally instead of the DPDK CI coverity > warning. However, we think it is reasonable. > That is OK, I just wonder if it is enabled explicitly with a config, and what that config is (for the record). >>> >>> coverity:not_unsigned: Violation: Operand >>> "hw->hw_tc_map & (1UL << i)",  Right Expression: >>> "1UL << i" is not an unsigned type >>> >> >> Can you please split this patch into multiple patches, one for each type of >> issue? >> >>> Coverity issue: 91708127 >>> Coverity issue: 89776953 >> >> I assume these are internal coverity ids, it has not much value to record them >> in the commit log. >> >> We record the public coverity [1] ids with this tag. > Hi, Ferruh >   The warning is our configuration. As a result, it has no public id.If the ID > is not added, the check-git-log check fails. > > Do you have any good advice? > Doesn't mention from coverity at all in the commit log, like first patch can be: " net/hns3: fix logging format symbols " etc... > Thanks > Lijun Ou >> >> [1] >> https://scan.coverity.com/projects/dpdk-data-plane-development-kit?tab=overview >> >>> Fixes: 62e3ccc2b94c ("net/hns3: support flow control") >>> Fixes: 19a3ca4c99cf ("net/hns3: add start/stop and configure operations") >>> Fixes: a5475d61fa34 ("net/hns3: support VF") >>> Fixes: fb94f359481f ("net/hns3: fix adding multicast MAC address") >>> Fixes: fcba820d9b9e ("net/hns3: support flow director") >>> Fixes: a951c1ed3ab5 ("net/hns3: support different numbers of Rx and Tx queues") >>> Fixes: 2790c6464725 ("net/hns3: support device reset") >>> Fixes: 23d4b61fee5d ("net/hns3: support multiple process") >>> Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") >>> Fixes: e31f123db06b ("net/hns3: support NEON Tx") >>> Fixes: 8839c5e202f3 ("net/hns3: support device stats") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Hongbo Zheng >>> Signed-off-by: Lijun Ou >> >> <...> >> >> . >>