From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8C8B3A0547;
	Tue, 19 Oct 2021 19:23:03 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 587B640683;
	Tue, 19 Oct 2021 19:23:03 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id D8E5B4003E
 for <dev@dpdk.org>; Tue, 19 Oct 2021 19:23:01 +0200 (CEST)
Received: from [192.168.1.192] (unknown [188.242.181.57])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 3FBA47F59B;
 Tue, 19 Oct 2021 20:23:01 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3FBA47F59B
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1634664181;
 bh=HTKTovwMGAse3wXZMFPCY10D9FU0CnTg82eH3cZP8cM=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=rT/7UKR8SfB4C56z3v7Wx/6JWWGci03YEHqHxC+qeQa4F2jMkKkRu/EwCAbBXJbAB
 zlFcJ6DUrK4SgsZnhnxDgIH93CnNxRk9tLz2jwOAi1MMRphQf0jMIroANIUscAYopK
 G8xzd5jKtACFqC6iNToLCwyABnjU0BaQ1W2Q1rNc=
To: Olivier Matz <olivier.matz@6wind.com>
Cc: David Marchand <david.marchand@redhat.com>, Ray Kinsella <mdr@ashroe.eu>, 
 dev@dpdk.org
References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru>
 <20211019100845.1632332-1-andrew.rybchenko@oktetlabs.ru>
 <20211019100845.1632332-5-andrew.rybchenko@oktetlabs.ru>
 <YW7u8bE1CPaC9zhW@platinum>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <8a5ff8f9-635f-76e8-5c5e-48fe59fcbeb9@oktetlabs.ru>
Date: Tue, 19 Oct 2021 20:23:00 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <YW7u8bE1CPaC9zhW@platinum>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 4/6] mempool: make header size calculation
 internal
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/19/21 7:14 PM, Olivier Matz wrote:
> On Tue, Oct 19, 2021 at 01:08:43PM +0300, Andrew Rybchenko wrote:
>> Add RTE_ prefix to helper macro to calculate mempool header size and
>> make it internal. Old macro is still available, but deprecated.
>>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 
> (...)
> 
>> +/** Deprecated. Use RTE_MEMPOOL_HEADER_SIZE() for internal purposes only. */
>> +#define MEMPOOL_HEADER_SIZE(mp, cs) \
>> +	RTE_DEPRECATED(RTE_MEMPOOL_HEADER_SIZE(mp, cs))
>> +
> 
> 
> I think it should be instead:
> 
> #define MEMPOOL_HEADER_SIZE(mp, cs) \
> 	RTE_DEPRECATED(MEMPOOL_HEADER_SIZE) RTE_MEMPOOL_HEADER_SIZE(mp, cs)
> 

Thanks a lot (a bit ashamed... :) )