From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 247FDA04A8; Wed, 26 Jan 2022 10:30:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEA2942708; Wed, 26 Jan 2022 10:30:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id DFCD74069D for ; Wed, 26 Jan 2022 10:30:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643189418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4bF95bYsPeNYGjtvUlDTFg18DXsOf2Pxay3m4XMlAmc=; b=iCnRdxEylGDDLEoIGGP7jEoPoE8GNDRGOHWVsn9r1bDeeb0glNWGq4dkFg/L9+3IC5U47t V6HjuXVjUwHfTcJDFvJRYt+swi42tNgePbNyYk/M2jV9ie+1N2qFJnHpzElHrL632sUCmg m6+SVyjZx7VuOlJztT90hAj1jg2nwqo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-435-I8gSh_mNORKpdua57HtFGg-1; Wed, 26 Jan 2022 04:30:16 -0500 X-MC-Unique: I8gSh_mNORKpdua57HtFGg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9A1381966324; Wed, 26 Jan 2022 09:30:15 +0000 (UTC) Received: from [10.39.208.28] (unknown [10.39.208.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A2FF4EC77; Wed, 26 Jan 2022 09:30:14 +0000 (UTC) Message-ID: <8a8e0453-2b7a-e780-356c-c5d68c1c65d3@redhat.com> Date: Wed, 26 Jan 2022 10:30:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2 7/9] vhost: remove multi-line logs To: "Xia, Chenbo" , "dev@dpdk.org" , "david.marchand@redhat.com" References: <20220125112457.166434-1-maxime.coquelin@redhat.com> <20220125112457.166434-8-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, On 1/26/22 04:27, Xia, Chenbo wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Tuesday, January 25, 2022 7:25 PM >> To: dev@dpdk.org; Xia, Chenbo ; >> david.marchand@redhat.com >> Cc: Maxime Coquelin >> Subject: [PATCH v2 7/9] vhost: remove multi-line logs >> >> This patch replaces multi-lines logs in multiple single- >> line logs in order to ease logs filtering based on their >> socket path. >> >> Signed-off-by: Maxime Coquelin >> --- >> lib/vhost/socket.c | 10 ++-- >> lib/vhost/vhost.c | 8 ++-- >> lib/vhost/vhost_user.c | 106 +++++++++++++++++++---------------------- >> 3 files changed, 60 insertions(+), 64 deletions(-) >> ... >> @@ -1122,8 +1121,7 @@ vhost_user_postcopy_region_register(struct virtio_net >> *dev, >> >> if (ioctl(dev->postcopy_ufd, UFFDIO_REGISTER, >> ®_struct)) { >> - VHOST_LOG_CONFIG(ERR, "(%s) failed to register ufd for region " >> - "%" PRIx64 " - %" PRIx64 " (ufd = %d) %s\n", >> + VHOST_LOG_CONFIG(ERR, "(%s) failed to register ufd for region %" >> PRIx64 " - %" PRIx64 " (ufd = %d) %s\n", > > This line is > 100 chars, and I think the original one is fine for log filtering > or using log to search code. > What do you think? Makes sense, I will revert this change in v3. Thanks, Maxime