From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F16F45C20; Thu, 31 Oct 2024 13:45:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ECE1E4356F; Thu, 31 Oct 2024 13:45:44 +0100 (CET) Received: from smtp-fw-80007.amazon.com (smtp-fw-80007.amazon.com [99.78.197.218]) by mails.dpdk.org (Postfix) with ESMTP id E018540264 for ; Thu, 31 Oct 2024 13:45:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1730378744; x=1761914744; h=from:to:cc:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=tEJsVR/HK4aHGmMwNqj8DjLum58QvzwWiusf8ODft6s=; b=tUc7EUxo6jrkluTybB6XajWTZEBtQOuNuTloTm//BjuIhtrAj4bYJf5z WubfVV6mTJkqF3Cja1ksBWrMzVwSFnFOtfeZSGSaVjgPLAxp2FAjyv+dN 76LhfBjUNXQ5hasp2QLt5nR0L/gMEbWxQNSmn4ytL7amC8zE22P1RgKam w=; X-IronPort-AV: E=Sophos;i="6.11,247,1725321600"; d="scan'208";a="348322955" Subject: RE: [PATCH 0/1] net/ena: adding a histogram framework to 2.11.0 Thread-Topic: [PATCH 0/1] net/ena: adding a histogram framework to 2.11.0 Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.25.36.210]) by smtp-border-fw-80007.pdx80.corp.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2024 12:45:42 +0000 Received: from EX19MTAEUB001.ant.amazon.com [10.0.43.254:1815] by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.4.191:2525] with esmtp (Farcaster) id f202dafe-667a-4976-8829-aa767e05f2e6; Thu, 31 Oct 2024 12:45:40 +0000 (UTC) X-Farcaster-Flow-ID: f202dafe-667a-4976-8829-aa767e05f2e6 Received: from EX19D007EUA003.ant.amazon.com (10.252.50.8) by EX19MTAEUB001.ant.amazon.com (10.252.51.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.34; Thu, 31 Oct 2024 12:45:40 +0000 Received: from EX19D007EUA002.ant.amazon.com (10.252.50.68) by EX19D007EUA003.ant.amazon.com (10.252.50.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.35; Thu, 31 Oct 2024 12:45:39 +0000 Received: from EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc]) by EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc%3]) with mapi id 15.02.1258.035; Thu, 31 Oct 2024 12:45:39 +0000 From: "Brandes, Shai" To: =?iso-8859-1?Q?Morten_Br=F8rup?= , "ferruh.yigit@amd.com" CC: "dev@dpdk.org" Thread-Index: AQHbKdjhnaEsuOOLyESIiL75Nk2ME7KdbLEAgANlAPA= Date: Thu, 31 Oct 2024 12:45:39 +0000 Message-ID: <8ab650f4bddd4bbc8245690bde407d7b@amazon.com> References: <20241029080215.5069-1-shaibran@amazon.com> <98CBD80474FA8B44BF855DF32C47DC35E9F843@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F843@smartserver.smartshare.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.51.153] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Morten Br=F8rup > Sent: Tuesday, October 29, 2024 10:55 AM > To: Brandes, Shai ; ferruh.yigit@amd.com > Cc: dev@dpdk.org > Subject: RE: [EXTERNAL] [PATCH 0/1] net/ena: adding a histogram framework > to 2.11.0 >=20 > CAUTION: This email originated from outside of the organization. Do not c= lick > links or open attachments unless you can confirm the sender and know the > content is safe. >=20 >=20 >=20 > > From: Shai Brandes > > > > This update is an enhancement to the ENA driver version 2.11.0 release. > > It is a "nice to have" feature for the 24.11 release, should it be > > included before the code freeze deadline. > > > > This addition leverages an internal framework used in our testing > > processes, which may offer significant benefits for customers. > > It calculates the differences between specified start and end points > > in the code, generating a histogram of time intervals to provide > > detailed insights into performance. >=20 > Yes, histograms can be extremely useful. > The SmartShare applications use histograms for a variety of purposes, e.g= . > function profiling (like yours), number of packets per RX burst, number o= f > packets per flow, and much more. > The distribution index can be linear (like yours), log2, or - for higher > resolution - floating point with 3 or 4 bits mantissa and 5 or more bits > exponent. >=20 > Please provide generic histograms as a proper library, not tied to a spec= ific > driver, and not specifically using "time" as parameter. Acknowledged, thanks for your insights!