From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77EB54575E; Wed, 7 Aug 2024 16:24:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 096284028C; Wed, 7 Aug 2024 16:24:59 +0200 (CEST) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by mails.dpdk.org (Postfix) with ESMTP id B2C0C4027B for ; Wed, 7 Aug 2024 16:24:56 +0200 (CEST) Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a7a9a369055so188166966b.3 for ; Wed, 07 Aug 2024 07:24:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1723040696; x=1723645496; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=w7UVqPPY4NY/EMV/R+PaO9COS/9grsVO019OQ2robWE=; b=sI8IP6tP5sw/mleIlBCQ3ZYu3mTXZhhSKGWEh2CagBAM8ol9ggkVU5xH4C3aTUaRfh yKIRO5fVDcPCI6DfNOVqAOL0yY1Uqd4xZQuZxdtrws1uBBrzQRTG4H1bvbqxqaSe+T5P X5xc12/mBB6PNPOqJ7L6mNyPw8bbqkr2KqwbLmHzpfYWeGNdNIX5nqkmlmrvALsD2R7d oDaJ7i/S50P3IXjsvRzBBpfrb5wBGdAZScv+hIKl2IBErGiPRJ+xCuF1CFbusQ9ci38p 7pGRf3wMVTc1/cmnqU77kf5BhiUFKoYr8xz05K5OpN0tEIWHzenPD5c2m2N1gvsDtsBT 2iVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723040696; x=1723645496; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w7UVqPPY4NY/EMV/R+PaO9COS/9grsVO019OQ2robWE=; b=mKn5ajh6xj1hEMhs1sP2Srf4UvlChB5hdk8jU02qxj5pVGyZpl8ntoWRy4Mbjgr4Zc opKA1haJ50BwNvOWXo3jRM/ABlM6lkn//hkQUYXKvcRAZe12bvoBuJ0pQ2nABr77rGCW kR54JTGPP+PMrKW5R9N1R7en+XNI33W7p9n/zETwDejJI9aqrtwFq9zu9L1E03Ikh4g9 nZEkE3g45dm1/WXqaKmuzpz2CPZ1wjoa9uX2EGeo9kyqK7Na9axqwOS8XTOXbXwuRHHb sqs4W3IqniIchNxetkOksn+r624i0OPiWiGZQa1w8gpWpnBJF5c3axWEC+ZPk4fe396z pVFw== X-Gm-Message-State: AOJu0Yzs6TftddlSkcrAUoLZo8u+1ahxrtldGQWOZBFjzRAJkzPQQ0CJ Ml1+ZfRQIEMkANm7+6o2s8COh+V/6huYm2+gVzV0rLqLHC//fYUicQZGcDiY5ME= X-Google-Smtp-Source: AGHT+IGRTFriTj/zD+D9xo3beVCeAv7EI8MYTVCZjcZo3NYy5u9C6YCJ8lQdGg7lySVDbFS4lcL2WA== X-Received: by 2002:a17:907:94d0:b0:a77:db97:f4fd with SMTP id a640c23a62f3a-a7dc4fa198dmr1530731066b.34.1723040695989; Wed, 07 Aug 2024 07:24:55 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.236]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9bc3ca6sm648596866b.20.2024.08.07.07.24.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Aug 2024 07:24:55 -0700 (PDT) Message-ID: <8ac7fa71-ae62-497f-a467-01b262fd3da3@pantheon.tech> Date: Wed, 7 Aug 2024 16:24:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v15 2/5] dts: replace the or operator in third party types To: Luca Vizzarro , thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, bruce.richardson@intel.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, npratte@iol.unh.edu Cc: dev@dpdk.org References: <20231115133606.42081-1-juraj.linkes@pantheon.tech> <20240806151937.391917-1-juraj.linkes@pantheon.tech> <20240806151937.391917-3-juraj.linkes@pantheon.tech> <156d06f3-552a-498a-9569-7602576c4f2b@arm.com> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <156d06f3-552a-498a-9569-7602576c4f2b@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7. 8. 2024 15:34, Luca Vizzarro wrote: > Hi Juraj, > > In the past, I have noticed this problem appear only on Python versions > prior to 3.10. Before PEP 604[1] – introduced in Python 3.10 – the pipe > operator was always used as an operator between objects instead of an > alias for Union in the annotations. A quick test verifies this: > >    Python 3.8.18 (default, Aug 25 2023, 13:20:30) >    [GCC 11.4.0] on linux >    Type "help", "copyright", "credits" or "license" for more information. >     >>> from collections import Counter >     >>> from typing import TypedDict >     >>> class t(TypedDict): >    ...     a: Counter | None >    ... >    Traceback (most recent call last): >       File "", line 1, in >       File "", line 2, in t >    TypeError: unsupported operand type(s) for |: 'type' and 'NoneType' >     >>> > > I have also attempted to build the docs removing this commit on my local > setup (outside of the Poetry shell) and it appears to be working with no > problems. > My local build also works fine, but the problem was found in CI: https://github.com/ovsrobot/dpdk/actions/runs/10261380458/job/28389032405 I included a script that checks the python version, so the running version should be at least 3.10. I can't find the actual version anywhere in the logs, but the environment is Ubuntu22.04 which should run 3.10. The TypeError only happens with the Transport from paramiko. This is likely related to the new feature that I've added in these last versions: the Python dependencies don't need to be installed. If they're not found, they're added to the autodoc_mock_imports config option and basically ignored. CI likely doesn't have these dependencies so I'd say this is the reason. My local testing (building docs without paramiko) confirms this. > Best, > Luca > > [1] https://peps.python.org/pep-0604/ >