From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A760A00C4; Thu, 6 Oct 2022 16:20:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0545642C67; Thu, 6 Oct 2022 16:20:52 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2065.outbound.protection.outlook.com [40.107.94.65]) by mails.dpdk.org (Postfix) with ESMTP id 5FF6142C66 for ; Thu, 6 Oct 2022 16:20:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BaMe9qrUXczc5pFIEQcAy9XIG/EUq0+oCMKw7Ky7Q1NP87jFjPmIqlAEv7DDjPfw+zMrcoXhq66bt9wzyzsb9ok0x8dgz42K8vZdHygELRJa2uX53boyRgD6LNQGphsi1NyrbIHVabPsR51hN2AMvAuzqAQiAEiqbJJtLfUakn4/2vNxA7XcCr3Scqmo1ZTuhsYmLpbsTeLyD6i+wpgnNzNLuLTVIHXLlGTc22g1Zf5tNc3EN4XX8MfbXexe3gUEGlcYPH1hOkKmcww30Hwv9M9hgHgVx3SeZ0sarkF6E9QinilKPasGORjHVWXhiNniFnDLDeqszURt6U7VLYF1lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D+IP0sOET0kT5wzAVjS1ZTjOL9bbXa7bSq4ZbPvARVE=; b=Z60GJ7Mt9rhI00WqqrY1vc9Q4/8bDpetXJh6wDsDwaXdZySHNx0x/CSqGM1nMmVgAgpzmfVKa+v+ywLvahCYq9dk7SpMhwfGDenQG6huX6f/DX91panZoCqDq5w19dGCNT/dPLGrU/35jbVDMbFHXkys+0u8GL0uqrglxm6DOsUMLprJG6v/gFue0Q0e8mU55TbLUl0bpiqfiW5TPrzTsWqBuDBDJXBq09KBE9+ysyDkCX21gaBUvyGcbecrxS1G19gCfN4oLQdHm4fJCtuTaT/z9/B5pe0P6cwBtvc4Vkw415gdlEMkimAAMm1DYgS3GEWlfraHh8Szy3rbml69og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D+IP0sOET0kT5wzAVjS1ZTjOL9bbXa7bSq4ZbPvARVE=; b=dOT3Mi82iQy2XraVz12l5hLUPTSsr5ChlMUuE9bpZ2Hv056qRB2d1pVeYs8XX836cZI1fyP/p+AAt6/dxzpl+xDEvbgPPKq1eNoTVEucp6v+NXqPLngksEmrio7SF7Jh599v4z2C/4186Rqf94uv8sX05CkPI5imacJ7T6tHFAM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL1PR12MB5285.namprd12.prod.outlook.com (2603:10b6:208:31f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Thu, 6 Oct 2022 14:20:48 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f%7]) with mapi id 15.20.5676.036; Thu, 6 Oct 2022 14:20:48 +0000 Message-ID: <8acea1a5-1a48-4a27-1384-e09f4da63c4c@amd.com> Date: Thu, 6 Oct 2022 15:20:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v4 2/9] net/gve/base: add logs and OS specific implementation Content-Language: en-US To: Junfeng Guo , qi.z.zhang@intel.com, jingjing.wu@intel.com Cc: ferruh.yigit@xilinx.com, dev@dpdk.org, xiaoyun.li@intel.com, awogbemila@google.com, bruce.richardson@intel.com, xueqin.lin@intel.com, Haiyue Wang References: <20220923093829.3019525-2-junfeng.guo@intel.com> <20220927073255.1803892-1-junfeng.guo@intel.com> <20220927073255.1803892-3-junfeng.guo@intel.com> From: Ferruh Yigit In-Reply-To: <20220927073255.1803892-3-junfeng.guo@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0204.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL1PR12MB5285:EE_ X-MS-Office365-Filtering-Correlation-Id: dfb6adf2-d7a1-49b1-3bea-08daa7a5f6b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Oscpul6s1EvyFn8ZGpRzvX0s2e+1KmM3lNstGjEMrHUcFyVLyjB/xGrgP+Za070Fwr3m485OTGPRkDDJiHFXaBz1d6GJ8Y2XwR4eLQiajqZewKxaasgJkW1jg4n/FfEKQeA1uLu5kz0jZR9v7sFOYLFBH1iwzwIpXIFEGnHzwFxrbttrtMU6A3hYTzJ9RgMvIYD3zpQo2Gvc00/7ZH1teoF1KYZ54zR7dfuc9lmMfyQhCnVZ64PbXJfT6ROB0rHogw67ExH2Urei778VRcSxmZvyLmN1ePiwrGS3j+C5C7XZ/GHgjrk1o8maiHboEkH1QTnWs3MQOnN52jhmLAU/Jptql/vkSy3e4D1RJltXsVAjK+LAjoUFw2ud9p8nKQ0voJOvgO29O2lfb2KeHBFKiXYXjKh2oMu4F/qbrowbVxr9KgJjRlvyWce73YbAZJZ09azQXaHutk8d74KnqYNXsBPLYhL6DZTuNkhFNQ2mxF5fiAnc3LB0FxBIxNda9q6rqm3liwim76pQdFYpHAeCqnYWWzkahlVyMRK4Wa4MSMxBLuC2KG0/VasMqFpzgF7n8QfL205wSIRnY5PGUSDCNcSjMEKS/WBeFxXS08w9yVqK1t0Sf+r+KaYpyL1BPv/tta+Zaw1lMBrotv1qt/TQLHr9OPjb9dtPSjVguDfCnLPVX2NdGcWtCcrf62vqt7EBHUknDTifIFylthJ0UHBpuEglPr6BgIdmf5Wn6KtGn3H82GBWV20/WedPHted8jIJ7WDBQOoncLXo86Nv7l5+KA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(376002)(366004)(39860400002)(396003)(346002)(451199015)(186003)(86362001)(31696002)(38100700002)(8936002)(41300700001)(5660300002)(44832011)(316002)(8676002)(66476007)(4326008)(66556008)(66946007)(6666004)(26005)(6512007)(6506007)(53546011)(2616005)(6486002)(4744005)(2906002)(478600001)(36756003)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vjg1eUJacXZsOC8rY0F5cThkd28rdzErbjVHUkhobExmRkoxL1N2NG92ZTAx?= =?utf-8?B?eEFURkVlRXlUeFhGMXl2U0VUQWtEZlZJVGtFRjZMSTJuelNaeWV6ZUhLVUxQ?= =?utf-8?B?V3JvazgrQ3NqZHJMTFY0THh0WkVrZW5wLzhJS01WWHdOd01vYTRHVWV6bUhE?= =?utf-8?B?cy84Tzhha0ttZGVsbkxpTGQ3V0FXTi9JTDZURDdvUXhHQ09qRCtBUi9BRmFG?= =?utf-8?B?RlRtU2gyeFcyQXFWMitGTndZU09VSE1GTnFnN1psWU5UT2dyTUk1YW0vM0J1?= =?utf-8?B?TU5qMEZVbVVWeUZEL3NpeU10amUvb1VHVGlVdEJoelZlMXFpelphbGpmU1JQ?= =?utf-8?B?eHhldkgrcGlTYjJKa2I4SWFKWTNDUkFITWtrcUhSaUl2c3VmUEdHTmYya3Jw?= =?utf-8?B?eFJQR09jQ2w4aGtRNWFRazRRNDNzaE54ZGtZK3k5QXQwd1AwZ2xZMDhrdU9I?= =?utf-8?B?MW5UZTV2TkZzN0F5M08va1ZVV0FSWHUvajNRcFE4NmZtbUZ4N1B2SjRSRjN6?= =?utf-8?B?K2dVdlU3MWFSaURuYVhEaUdLaGZseHNlYUhvZCs2ZVN3b0RJOEFBU3NRK0tj?= =?utf-8?B?SXBZd0dlN1g1NmRxb2p6MnRpQjVScm10UFhoV0dnYWtiMHErb05TcTVtaHNR?= =?utf-8?B?THVLeDh4YkJ1WEpSRVRMRERNWmppOVB1RWRQNXRnWHBjTWdsQXA4dGRidE1O?= =?utf-8?B?bUl4YkRIYTIycjFvaFExYVRMTU5WTHBVOVB1WkhUMEdRNGowdmRNWHF6T2p2?= =?utf-8?B?Y0szVDVZYWNvWDIwVXd3aTQvYytXcW9qZHNwOEpDSE9BN1NHdUdiVjJtWFVt?= =?utf-8?B?OGhncS9FaDh4UkYxTWxpTWFiUzd6OXorY2tQeGczZ0ZSZWZuSjNZUGZqa2Vn?= =?utf-8?B?TWl2eE92SExnbUhidXA0UUN3ek9iSjgvYUZnVVNvNld2b1drWk1Od0xNMFg0?= =?utf-8?B?WUdSbzAxMnRub2RNT0dlSlVEL0dFV05zTDR4czNOOGVYK2FrZDdDaFIvaDRi?= =?utf-8?B?czdjaUxCK0txdlRERzRTWHo5d05uRm4wbkVyczNML1RVNHk3Q2RZMGNZMW5P?= =?utf-8?B?c0RoWTVSa3diZkZhQkd4ekpDcGg3M0hqeDBlUHEzTC93S0xPY0s3ZUxYZkpN?= =?utf-8?B?L1lVNGNnYmx5cUc4ZlVwS0ZiaE9hUENoS3hzSkZWclc5R0Q1ODNCaGVIemV3?= =?utf-8?B?ZWNhYmhvYkZpTWdiUlJjQnRYbDdaZEl2THpoSk1OaG0zZG1hMXlGenBtWVFz?= =?utf-8?B?M1h6VjZrTlFCTzJTNUJ2TzRKc0xpTTNMTFd1eGZScU05WDM0UnZpWEk2NW9u?= =?utf-8?B?Y25XQkk5R0RFT0I1dXcvdVhBTVpxaG5TSWpULy8yWXlIa1hrUjlZVVdxVmVm?= =?utf-8?B?cm8rNHVuNi91UGdlUWtBTFRUdHpSNGx2T3B2bE9rYWFCTlZVY2RWdXBrcURX?= =?utf-8?B?MlFpMGg3VVI5VGNhKzRUWXdabng4NE03c1lLWEQ0REtuQlUzV3cyTG9RS3p0?= =?utf-8?B?QTVlaVBpdExNTjZxRFRyWXpsZFloM3duNjd4RWlHVDBjRFBXOU8xakpBdDhH?= =?utf-8?B?N010bzZaS01nTE5CWCtxOEdkZGp3WXNyRXAyR2YvVnVGNDJaNGs4V2VlbkMx?= =?utf-8?B?UmJFcndySFdoUFpkRm1pZTJBRGx6bW1LUzIyWW43UEFsbjhhRlBDV29teVBG?= =?utf-8?B?THVWaWNGL20vMk8xWDRWQUNBYjgrQlhCUFVnTXZidDVlYXJzS0RvNlJEK2VO?= =?utf-8?B?RWYvWFRSY0VGQ21TTGI3d0o5S2J0dm8vcmpWV3EyYjVFNmt3VW51emEwdVNL?= =?utf-8?B?NENWd2hSbmovd0ozZkVtcW5TaGl1UzRwV0t3dEx4ay9IbDVwVm9ZTTZ4OTVU?= =?utf-8?B?Q25jSGtFU1pDWm83eGp2eHdSakpVbzk0cDdUcUhXQmFPcU0xUllKRUpFTmhh?= =?utf-8?B?SGxEVVZicEplMWRueUFYQWdkazVYVythZlEvaXlrL1BhWGY2Vkt0ckxEUkk4?= =?utf-8?B?YUFoOFYrUnprM0ozSHJ3RVRUd1lIamNlRktuM2NGVy8xMWFzNTZzMzZrcmIv?= =?utf-8?B?Vi9IaWMyNEdyWC9MMkNBcnJKYVBnTmIwQmtYNVpzQi9WeUtEYkVmbzBlcU9E?= =?utf-8?Q?ZmET4jf4MTdd9pQcjb7FFkrFf?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfb6adf2-d7a1-49b1-3bea-08daa7a5f6b5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 14:20:47.9204 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X2TkOyaz8CkEDgqp5+YJizmdV9PtCVAVpB73VJbb0uNmNhojWrAovJtRR/vonL7I X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5285 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/27/2022 8:32 AM, Junfeng Guo wrote: > > Add GVE PMD logs. > Add some MACRO definitions and memory operations which are specific > for DPDK. > > Signed-off-by: Haiyue Wang > Signed-off-by: Xiaoyun Li > Signed-off-by: Junfeng Guo <...> > --- /dev/null > +++ b/drivers/net/gve/gve_logs.h > @@ -0,0 +1,14 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(C) 2022 Intel Corporation > + */ > + > +#ifndef _GVE_LOGS_H_ > +#define _GVE_LOGS_H_ > + > +extern int gve_logtype_driver; > + > +#define PMD_DRV_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, gve_logtype_driver, "%s(): " fmt "\n", \ > + __func__, ## args) > + What do you think to move 'gve_logs.h' to next patch, since this is extern 'gve_logtype_driver' which is not added yet. Although files are not compiled yet, logically I think it suits better to next patch.