From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F1C9A0547; Mon, 30 Aug 2021 19:01:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1709E41140; Mon, 30 Aug 2021 19:01:59 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 51D814113A for ; Mon, 30 Aug 2021 19:01:57 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10092"; a="279325140" X-IronPort-AV: E=Sophos;i="5.84,364,1620716400"; d="scan'208";a="279325140" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2021 10:01:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,364,1620716400"; d="scan'208";a="518916983" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga004.fm.intel.com with ESMTP; 30 Aug 2021 10:01:54 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 30 Aug 2021 10:01:53 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 30 Aug 2021 10:01:53 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 30 Aug 2021 10:01:53 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 30 Aug 2021 10:01:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QV/XZv8m9Jq1FEN0txcDRZbKGj74jfLyoWor85hZPDxBlG2kEYXmSuFl4vmD79QJ3NhvaXN5ebLW0G9Xizi2mBmr5PaZIEClJpF8JqmYPGRg/d4kvSdD22M6O0yQZLNw92xQViRWVc9p7+pTk9RxSopiYurZIKxOnn2E57NXSDf2Rf3FQQMHTU619GDWfIyRmK4tuevmd27gEYAJd6cKNnBfv95sx0L8vw2sRo6Xpru4jkiSHZ+WLSKuNIfRTvurSwCvutOUGvyjB/7+Q3k0pY8G6rASIWy/pXielFn7E1OYrO5ummJK16Vec3S2Y0wHauURDlKfV+wz9HZdu+JSJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QURAaUtOZe7OQZdByA3BGWEBKm1isPkMxOdO1wx2iUc=; b=oEqZA0WYVZkyjCqLuXXE83Kx40NFSZfnD+Hj9KZUvl5+qsvi+aN6ZJwllhmDeErYwDNuSIJ/DlDfuaD/uZnyNCiY4D5oC0XJe/kWyXBxvRwiWmvJijWsmOX7vOY1svxEoFNrlQVUX3HTh0ceqcBD/QYVJUuy6J6LCGSoleJ59l6d+s7xrnpNjxmfFkf4w6oYVHkPc9sgZki36I2lP1wvbSjgoSrWog9ZZhiW0QM0wuhPyDt8HfoAcSqCzT8GV0F8I8BdFX5zB1fdPbaP1wPhKxTDmP3+4djFiVk44mjv2eJiT8AmiWGJzk26h3OdmlI6h/OxNVE0KlNNN2LqnZmE6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QURAaUtOZe7OQZdByA3BGWEBKm1isPkMxOdO1wx2iUc=; b=yvBZ2yQjRgX7mrTP1JUptfogmrTR9oNsiLhCLA2tCCEj9gKKB9lkA0hWHXF/SK3mxzO3MA1Z5sOfV+1J3FbOYdBpzyGsi1GEY30vyUdtz19FdGlWnhzDefuoXIfzyDFt7Tazm+jZ2Jcx4KeycztJrG8Qx322EEGqzf7OZczcQ2g= Authentication-Results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4887.namprd11.prod.outlook.com (2603:10b6:510:30::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Mon, 30 Aug 2021 17:01:47 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4457.024; Mon, 30 Aug 2021 17:01:47 +0000 To: David Marchand CC: Maryam Tahhan , Reshma Pattan , Jerin Jacob , Wisam Jaddo , Cristian Dumitrescu , Xiaoyun Li , Thomas Monjalon , Andrew Rybchenko , Jay Jayatheerthan , Chas Williams , "Min Hu (Connor)" , Pavan Nikhilesh , Shijith Thotton , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , Qi Zhang , Xiao Wang , Beilei Xing , Haiyue Wang , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Keith Wiles , Jiayu Hu , Olivier Matz , Ori Kam , Akhil Goyal , Declan Doherty , Ray Kinsella , Radu Nicolau , Hemant Agrawal , "Sachin Saxena" , Nithin Dabilpuram , Kiran Kumar K , "Sunil Kumar Kori" , Satha Rao , "John W. Linville" , Ciara Loftus , Shepard Siegel , Ed Czeck , John Miller , "Igor Russkikh" , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Bruce Richardson , Konstantin Ananyev , Ruifeng Wang , "Rahul Lakkireddy" , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , Gaetan Rivet , "Ziyang Xuan" , Xiaoyun Wang , Guoyang Zhou , Yisen Zhuang , Lijun Ou , Jingjing Wu , Qiming Yang , Andrew Boyer , Rosen Xu , "Srisivasubramanian Srinivasan" , Jakub Grajciar , Zyta Szpak , Liron Himi , "Stephen Hemminger" , Long Li , "Martin Spinler" , Heinrich Kuhn , Jiawen Wu , Tetsuya Mukawa , Harman Kalra , Anoob Joseph , "Nalla Pradeep" , Radha Mohan Chintakuntla , Veerasenareddy Burru , Devendra Singh Rawat , Jasvinder Singh , Maciej Czekaj , Jian Wang , Maxime Coquelin , Chenbo Xia , Yong Wang , Nicolas Chautru , David Hunt , "Harry van Haaren" , Bernard Iremonger , Anatoly Burakov , John McNamara , Kirill Rybalchenko , Byron Marohn , Yipeng Wang , dev , Tyler Retzlaff References: <20210629134632.525037-1-ferruh.yigit@intel.com> <20210827011903.1566409-1-ferruh.yigit@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <8ad71734-17d4-4e5e-a489-206a7431c041@intel.com> Date: Mon, 30 Aug 2021 18:01:28 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0301CA0074.eurprd03.prod.outlook.com (2603:10a6:6:30::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0301CA0074.eurprd03.prod.outlook.com (2603:10a6:6:30::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.18 via Frontend Transport; Mon, 30 Aug 2021 17:01:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ae6693eb-d830-4b64-a14e-08d96bd7d9ef X-MS-TrafficTypeDiagnostic: PH0PR11MB4887: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:873; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9nUDgz8Vsp8Hg9Bk/ypG7Hx9Cd902dqkOBUERKR6XY6eUlZ51IX7AF4ayjUx20RWiPTmXc3qWeQD/ONyUAVwEhNiEAKZOpH4dK7SahuoDZ2ZgEZlMJWem3bVYbynimwV928QhHCDrB/EL2TsMb8JfIIg+Tp3NPf08iBUhORY8dvJ5F76hRt/LZghOQkFk55E6iBoFNyjVj58KUs2sst3/RjMadWglQ1K2PE0zoMbfWfG2uK+N5AzArvo4wQezho+LncL0gg55f5t7vbY450OaaFuQ2Gu8lz4mBgdXctwkoUXp0PVLEaC4jnfFb4mmAUOxw3EecdanX0x1sVnhRMrKUq02zlHddgkmhVyOoiJKFKOb4HXkPNhnZZD5Y17NbCSdFDQcOCY7VP4lg2y+BQHJ6QYj5ZqvZjk8aqzPJVBgOMsusegq6ZPD/etAggcci1+Ulo+aJPnoma9V7PSDYDomQhjrG1Tm8x/KE4lz7fCztTDLf2fyU3kPRde63JqKeV48viY3vqDhu3GLs5If/Mh80fmLNZ4xlZqCfuT1/GtKSXA7+eAyszsedejBKsc/QJIUaTcVQlxbzXOfFuqbyPQZaEoZKNup90++q4Yk/s8PbJ4IS5H7zARo7o16zK++mSLdbICFS/cqcQiL4X3RnEMcv3LeV/RBQ5kFqB7UHlhDLdgcOnrz5tDyRTS7FoXz0Aqts3pFWMj/feQ+VR24U4rYG3Ycz/n/YDF9ykwjd3A/VHaVMijuwVJ3MII4GdJOOWPJpJXY07kpDvnuq59dPIWmw/Uud0cF4FaXofQfRo10Tg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(16576012)(54906003)(86362001)(36756003)(4326008)(5660300002)(38100700002)(53546011)(31696002)(8936002)(2616005)(956004)(66946007)(66556008)(966005)(66476007)(44832011)(6486002)(6666004)(8676002)(31686004)(508600001)(6916009)(186003)(2906002)(7416002)(7366002)(7406005)(316002)(26005)(83380400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3FPalI4M1RzcTd5WWJteG1xSVpXQkNxSllERVp5RVBxRlBhK3FtaDhOVUx6?= =?utf-8?B?NEpySkw2Z1ZNdWErWjJydUVtS3JRVGNmMytiam5JVFQvNnNwSndqNVRVQ1FM?= =?utf-8?B?WE9Qend5ZXBqUU5uL0xpRkxuRlc4Tzg2YVhwTlI1UmEzZzJUT3dxRE85Skxl?= =?utf-8?B?TTZQSFJZVzZRR1ZIclYwRUQzREIvVmIxUnpxV3pwOHVoVGk0UnRrRnU3SThi?= =?utf-8?B?MWVOc0JNZU1ZbjZZQlZkcWxsOTRRR2t2MTJMcWkwcS9JdWpKMEJNQUpPL2Mv?= =?utf-8?B?Z3FqRW5wTkcrYmxGVVNpS3NzWXF6VGh0VEtVRWVFQjh2Vjc3SldHQUlXdGkw?= =?utf-8?B?SmJ6Ly9tbWwybHRCL1VPR0hnbEhZenJMc2pJRzhzZCt6NkNMMWwvTnNVRllx?= =?utf-8?B?S2FEcHJIYlBmSWVCSWJiR0ZlRkdGTEM3ZWwyY1ZrTTRrRHBtdTgzKy9xQmtU?= =?utf-8?B?ZG81V2o2WVYyWGlJZmNGK2R2bXpRYkRPQTF4Y1o1NnozVDJsMjNpWTdpREZS?= =?utf-8?B?YzdYT2lPREYxbm9mbWdrc2VlY2ZKbHBxMitINEZTNzZ6bGNPcUxvTUc2Nlls?= =?utf-8?B?UUIzOTRkcVMvNk9oWWU5V25XNDZxQTJZSVVNWU1UNGVrdXFPSTFCWE1XNW1V?= =?utf-8?B?SzdURm1HZjVBKzZxSzA1MEFtTlBTcXZJZWVMNndUUlUrRVVhYUdFUXNabE5w?= =?utf-8?B?RkZyOWtwUk5QM2JFbUo3VFlqNTkzOEhnb0JZQUdyVUthSFlrSkIwenl2TzlE?= =?utf-8?B?YS9wN0dNNDRvRWhtcU5JbDl2Skx2MkM0REFTUlZlT2lnak9nV3E2V0RYMGRO?= =?utf-8?B?ME1MZm9ablBhQ2xVTnVhNWFpZUp5K0NHektDazJQTTZMemlsTk9PbUVkNnpP?= =?utf-8?B?OWRZbTR2cHRtWHh3M3E0ODIxVTNUZWxLMlZaSG9oenFwVlNlaGIxcUlkUFlO?= =?utf-8?B?a0VYOXdydE1jYiswZGRkVHpNUjhzN3Y1aVZVbXozeC9wWHU5enBTYS9JejM0?= =?utf-8?B?ZFFkdW5DaHRRbDZCTDQ3d0taelNxMEhSakFsdVBVdkhuWHVvN3o3UkV3U2d5?= =?utf-8?B?cUN5TThvd3cwN3EvZ1hBWTBLUEhrcElTam05bnpxaFB0WVpqWVFDSmVFTWp4?= =?utf-8?B?NDAyclRVcTlZTHBmL3pCeEEydTFvbkVQODd4cUorMXpmVW9PV212N0ZqWDhr?= =?utf-8?B?OVJKdDdVZGVSNjV6aHpYNHBPck90ODhXZk9mcDRISzYzR2hYamFOOG1jNmZy?= =?utf-8?B?SVZrZG1wMFlhV1o5eFUyeGxheE1xbStjdGpRRzdwUTN6d05sOWxyY20yN0Zy?= =?utf-8?B?c29hcFBTQUU5UUFsT05VOHBjbzEyWnlKOGVreC9OZkxjUXBlcFgwZmVjU0t2?= =?utf-8?B?THFhNTJWbGZtNkdZZkFDSllCTnBtdGV5R3NHZHNNay9ZeFkxclU3dTd6ZmND?= =?utf-8?B?RUIwT2crNnRXR2MyOGREbjJwUCtSd2VsSlRnQ2ZRTHd6OVNWY2NXeFFEbU1a?= =?utf-8?B?TWdtdmdJdFlTQlFUY3loZFVGVVpYWlpkU3Z3dk51MmJpRDd2TitqOHBrV01T?= =?utf-8?B?WWlHQU1zT1N3QnRlQ3kzdjEzOUgwRWFlWmkyaWs4WW5aZGhZN3FHc2hYOVlU?= =?utf-8?B?QzFsaXBNRjVDVE1tYTI3M0ZTY3RobGt3S3IxaU0vczJ6NjczMmg1V0VHNXNl?= =?utf-8?B?WEwvZmtvMHhHdVlRWEVkaG51RVRndjVhczA3OVdMeCtHeUZpTkowVUtjTlZP?= =?utf-8?Q?sZ4igc9htMo/zckYhTGUcmS6hKtSXehinj1fgUM?= X-MS-Exchange-CrossTenant-Network-Message-Id: ae6693eb-d830-4b64-a14e-08d96bd7d9ef X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2021 17:01:47.2009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MXGDMnvi+TaVdfG4CgoUAHIPm08iMBmmqZ2SWf6eTP6WdSFVr0K639tR8lsaIWMphEJfYjtSM4yYAqZZxs5C1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4887 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add namespace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/30/2021 10:41 AM, David Marchand wrote: > Hi Ferruh, > > On Fri, Aug 27, 2021 at 3:26 AM Ferruh Yigit wrote: >> >> Add 'RTE_ETH' namespace to all enums & macros in a backward compatible > > For completeness, there are some struct renames too in this patch. > ack, will add to the commit log. Also fixing some checkpatch warnings and noting this in the commit log. > >> way. The macros for backward compatibility can be removed in next LTS. > > Olivier had provided a script when he prefixed librte_net macros. > https://inbox.dpdk.org/dev/20190529144602.5tpfb5p3yasz3tvl@platinum/ > > Did you use a script to do those renames and can you share it? > Or maybe we can simply reuse Olivier script. > Using Olivier script seems was good idea, but unfortunately I updated manually. > >> >> Internal components switched to new enum & macro names. > > I found remaining references for macros and structs. > Enums look fine. > Thanks for catching these, I am updating patch to fix them. > With this patch applied: > > # For structs: > $ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk '/^-struct > / {print $2}' |sort -u); do git grep -w $word |grep -v '#define > '$word'[[:space:]]'; done > lib/ethdev/rte_ethdev.h: struct rte_fdir_conf fdir_conf; /**< FDIR > configuration. DEPRECATED */ > lib/ethdev/rte_ethdev.h: struct rte_intr_conf intr_conf; /**< > Interrupt mode configuration. */ > > # Enums look fine: > $ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk '/^-enum / > {print $2}' |sort -u); do git grep -w $word |grep -v '#define > '$word'[[:space:]]'; done > $ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk > '/^-\t(RTE|ETH)_[^ ,]*,/ {print $2}' |sort -u); do word=${word%%,}; > git grep -w $word |grep -v '#define '$word'[[:space:]]'; done > $ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk > '/^-\t(RTE|ETH)_[^ ,]* = / {print $2}' |sort -u); do git grep -w $word > |grep -v '#define '$word'[[:space:]]'; done > > # For macros: > $ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk '/^-#define > / {print $2}' |sort -u); do git grep -w $word |grep -v '#define > '$word'[[:space:]]' && echo; done > doc/guides/rel_notes/release_18_11.rst: To request keeping CRC, > application should set ``DEV_RX_OFFLOAD_KEEP_CRC`` > > doc/guides/rel_notes/release_19_11.rst: * Added new Rx offload flag > ``DEV_RX_OFFLOAD_RSS_HASH`` which can be used to > > lib/ethdev/rte_ethdev.h: } tc_rxq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS]; > lib/ethdev/rte_ethdev.h: } tc_txq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS]; > lib/ethdev/rte_ethdev.h: uint8_t tc_bws[ETH_DCB_NUM_TCS]; /**< TX > BW percentage for each TC */ > > lib/ethdev/rte_ethdev.h: uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES]; > lib/ethdev/rte_ethdev.h: uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES]; > lib/ethdev/rte_ethdev.h: uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES]; > lib/ethdev/rte_ethdev.h: uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES]; > lib/ethdev/rte_ethdev.h: uint8_t > prio_tc[ETH_DCB_NUM_USER_PRIORITIES]; /**< Priority to tc */ > > [snipped the rest of the output] etc... > >