DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Dexuan Cui <decui@microsoft.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Donald Lee (RD-TW)" <Donald_Lee@trendmicro.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	Abhishek Marathe <Abhishek.Marathe@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters
Date: Tue, 26 Nov 2019 17:02:22 +0000	[thread overview]
Message-ID: <8adfb064-0bd4-ead3-b5e4-0435a9e96e65@intel.com> (raw)
In-Reply-To: <PU1P153MB01697D8E0DEF8ABE061AD7A3BF450@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>

On 11/26/2019 3:32 AM, Dexuan Cui wrote:
>> From: Dexuan Cui
>> Sent: Monday, November 25, 2019 7:29 PM
>> To: Stephen Hemminger <stephen@networkplumber.org>; dev@dpdk.org;
>> Donald_Lee@trendmicro.com
>> Cc: stable@dpdk.org
>> Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters
>>
>>> From: Stephen Hemminger <stephen@networkplumber.org>
>>> Sent: Monday, November 25, 2019 9:13 AM
>>> To: dev@dpdk.org
>>> Cc: Stephen Hemminger <stephen@networkplumber.org>;
>> stable@dpdk.org;
>>> Dexuan Cui <decui@microsoft.com>
>>>
>>> In order to change RSS parameters, the host requires that RSS
>>> is disable first.
>>>
>>> Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
>>> Cc: stable@dpdk.org
>>> Signed-off-by: Dexuan Cui <decui@microsoft.com>
>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>> ---
>>>  drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
>>>  1 file changed, 14 insertions(+)
>>>
>>> diff --git a/drivers/net/netvsc/hn_ethdev.c
>> b/drivers/net/netvsc/hn_ethdev.c
>>> index 164e9ad174a7..575780ee5f26 100644
>>> --- a/drivers/net/netvsc/hn_ethdev.c
>>> +++ b/drivers/net/netvsc/hn_ethdev.c
>>> @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev
>>> *dev,
>>>  			hv->rss_ind[i] = reta_conf[idx].reta[shift];
>>>  	}
>>>
>>> +	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
>>> +	if (err) {
>>> +		PMD_DRV_LOG(NOTICE,
>>> +			"rss disable failed");
>>> +		return err;
>>> +	}
>>> +
>>>  	err = hn_rndis_conf_rss(hv, 0);
>>>  	if (err) {
>>>  		PMD_DRV_LOG(NOTICE,
>>> @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev
>>> *dev)
>>>  			return err;
>>>  		}
>>>
>>> +		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
>>> +		if (err) {
>>> +			PMD_DRV_LOG(NOTICE,
>>> +				"rss disable failed");
>>> +			return err;
>>> +		}
>>> +
>>>  		err = hn_rndis_conf_rss(hv, 0);
>>>  		if (err) {
>>>  			PMD_DRV_LOG(NOTICE,
>>> --
>>> 2.20.1
>>
>> Hi, Stephen,
>> I think the patch originally came from Donald Lee (I added him to "To").
>>
>> IMO Donald's Signed-off-by should be added.
>>
>> And, can you please change my Signed-off-by to Tested-by?
>>
>> -- Dexuan
> 
> Also, please add Tested-by for 
> 
> Abhishek Marathe <abmarath@microsoft.com> (Cc'd).

Hi Stephen,

I will update this in next-net if you confirm.
And to prevent confusion, can you please reply the tags that needs to be used?

Thanks,
ferruh

  reply	other threads:[~2019-11-26 17:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26  3:28 Dexuan Cui
2019-11-26  3:32 ` Dexuan Cui
2019-11-26 17:02   ` Ferruh Yigit [this message]
2019-11-26 17:19     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-12-09 21:29 ` [dpdk-dev] " Dexuan Cui
2019-12-10  2:31   ` Donald_Lee
2019-12-10  6:59     ` Stephen Hemminger
  -- strict thread matches above, loose matches on Subject: below --
2019-11-25 17:13 Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8adfb064-0bd4-ead3-b5e4-0435a9e96e65@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=Abhishek.Marathe@microsoft.com \
    --cc=Donald_Lee@trendmicro.com \
    --cc=decui@microsoft.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).