From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8267FA0548;
Tue, 17 Aug 2021 10:11:29 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 0D38640DF5;
Tue, 17 Aug 2021 10:11:29 +0200 (CEST)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
by mails.dpdk.org (Postfix) with ESMTP id C61E54014E
for <dev@dpdk.org>; Tue, 17 Aug 2021 10:11:27 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10078"; a="277046370"
X-IronPort-AV: E=Sophos;i="5.84,328,1620716400"; d="scan'208";a="277046370"
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
17 Aug 2021 01:11:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.84,328,1620716400"; d="scan'208";a="520349547"
Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17])
by FMSMGA003.fm.intel.com with ESMTP; 17 Aug 2021 01:11:24 -0700
Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by
ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.10; Tue, 17 Aug 2021 01:11:24 -0700
Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by
ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.10; Tue, 17 Aug 2021 01:11:23 -0700
Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by
orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.10 via Frontend Transport; Tue, 17 Aug 2021 01:11:23 -0700
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172)
by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2242.10; Tue, 17 Aug 2021 01:11:23 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=crNFXVLW+nBajs0jmzMxFPcl9fv+NQ9+bltxpuF3CS0Xo5pKh/ZbEUrXgp/CHbkDhXP7TlwZfITyKFO/6gbXZwo//OrPNLS+WO3M+HvmbiVrd6SVegCQGwFvAxlXIEGNRPeZxO3Tq+PXcg67P259mg3C9NWlZyWhWCusBKJI7SRBZkkDvDCb/W80qu9SuCxvwBx0ugKMBtrh4CZZSudVh0aLg08ipXEKhDwr4p6ItxG0uxkUB4OS8Ynug+8UuBTyzvSo+daDq0QGdk4JgBu3oP/E8pFpHhGlYuh/stbt6qP6ArwbHtolBeVHjCFdBVP1GHUT8EVXvc45t1VUqJjytA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=KycWsJgnNbQZKS3tX2wEkJV//uaOGEUXqOkbKLqzG7w=;
b=ixsgBR3QriSx2twpjHIz+NWuCqy3hulBKPKntACbx9tbyuqbQnECHtSVgDmmhlxt8X0M3asB0bcheWBnWk/iXNbFuBr3Vqpo5rZn76/SXGyc2Prcof2uJvKGl9siti9gA/kOdFCKpPluf59QdHf/3YFu1+8HkBDJGgllO+hbutiLSQ6jzA9j0PIQl9xKOSn+8OkufOJZ/byW40dtov6iaKzcXGIZ6Hfj9P2cICcdxvU5jrUVe0wtT9LPNDu0XIwSkHsE+j0prspDORbHmUXzQARd8seHvQcqCiW+hUfnwvEz/66pzs7rUnyir74zCdPVJ9vZ3TDVwxkpOXrXZa6Wwg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=KycWsJgnNbQZKS3tX2wEkJV//uaOGEUXqOkbKLqzG7w=;
b=MkhVILrvvpCq0PTpfiUy1InVO8vmkAMeE+rfM6bx10IwPz65Yk0g03N+4M47Yj0CN/wOjYlIfp3YglTrrmoHNpU5z58fVyJgcDh5LMgPjQH2WEFYadrExHTZDPHZ5pngPoCQ+MKSZoGOnAs62E3NtPliKyQqjr3Er58Wnk/4vFg=
Authentication-Results: dpdk.org; dkim=none (message not signed)
header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com;
Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19)
by PH0PR11MB5077.namprd11.prod.outlook.com (2603:10b6:510:3b::17)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Tue, 17 Aug
2021 08:11:22 +0000
Received: from PH0PR11MB5000.namprd11.prod.outlook.com
([fe80::2979:70ca:38a:dbaf]) by PH0PR11MB5000.namprd11.prod.outlook.com
([fe80::2979:70ca:38a:dbaf%7]) with mapi id 15.20.4415.024; Tue, 17 Aug 2021
08:11:22 +0000
To: Stephen Hemminger <stephen@networkplumber.org>, Aman Singh
<aman.deep.singh@intel.com>
CC: <dev@dpdk.org>
References: <20210816095728.17193-1-aman.deep.singh@intel.com>
<20210816095728.17193-3-aman.deep.singh@intel.com>
<20210816160347.0a35723a@hermes.local>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <8b0c151c-fc49-59f2-863c-233f419f4d40@intel.com>
Date: Tue, 17 Aug 2021 09:11:17 +0100
In-Reply-To: <20210816160347.0a35723a@hermes.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0068.DEUP281.PROD.OUTLOOK.COM
(2603:10a6:d10:4b::15) To PH0PR11MB5000.namprd11.prod.outlook.com
(2603:10b6:510:41::19)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.0.206] (37.228.236.146) by
FR3P281CA0068.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::15) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.4436.9 via Frontend Transport; Tue, 17 Aug 2021 08:11:21 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6fb939d6-0cbf-422f-f445-08d961569993
X-MS-TrafficTypeDiagnostic: PH0PR11MB5077:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR11MB50776878C899A4A06CB1B1DD95FE9@PH0PR11MB5077.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:525;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ygn4+slMMb4cIwsfKRLBw+ANmTjGBu1RsxbdSoW8yFliw6P/6+FAm6m4dZGNI/Tonk8yxF8QlI53vLWWDD/nxd89TMRtPpsRdT6TgV4JwEtf4X1RJHJAPufr1Fm/XujOsu6VDA+aUFyHgWfKfjGXc/0Oy11mwMEQ1pSZady84SafQYQT/9ZBbRlNtaLGcZn54q/G+mCVEyxmoAlwY7r4NRSQidinBy9nKvIe/VjUbgf/u2mtx63YPj4j8yVidbudB6dfwbOR7ikHFUxSBodVuR/Tsf4m9vfZGdpkkL8Fr7SZjQaF4xejMg7LnCmKlf9Q/by2QE3LJl+QsPaVDzNonxe5J18H+Id5DEM6TS2qltZH2Xmzc2/GoB23cbRkzkwc9EpU1/S40+CD4GaP6D4YFtoC7yRVYiSXYCqlENxcXXBiop5Z+ulKfpbeK9UYS7o4rEF4EbnBwMlzqYjhhFCwv6yd4HhjVNS24gQ/kYW1cwCRz5KlAxYuKGjn6GA9Z/n6eCB3eMSAITOTeA7spJ6mKNSrVWo/IY4LPHMSdMQ2EhoQDACwhd5td/LRgwnSHaWBIMCFb+HxQc8SIowyEivXkBLiNxubtsXa1YEv3oYLscoynLnIq/BZa79XUO+0cQljrEArBYiOWbDqb4kg9qP1WDemSslIwN+XQPHAOHiIqGKbAzmbhrBRet39lbf6dirN48vjeRFgR4MnkaokzUXalQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(39860400002)(376002)(346002)(396003)(136003)(366004)(38100700002)(36756003)(31696002)(6636002)(6486002)(8676002)(44832011)(186003)(26005)(2616005)(4326008)(956004)(8936002)(31686004)(110136005)(66476007)(6666004)(53546011)(478600001)(66946007)(66556008)(5660300002)(4744005)(86362001)(2906002)(316002)(16576012)(45980500001);
DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHpmTlYvUUtndmdRY0xrbkYwM3o3V0RhTkk3SC9xK0JJSU9mNi9zVVJoRUVV?=
=?utf-8?B?alRobnZPUytBU0trN1RvZEdFZXd6R1ZmRlVwWDhUcE8zVy9pRGZFZDdPRGgr?=
=?utf-8?B?SmtvWngzdGJhS0Ria1pudExXekRaM3VYQ1FqbHpHdkNQeHgvMkxCbDZEOHNK?=
=?utf-8?B?K1c5clVGaC85dlpmZk02VDl6dnBzNkt3czE5YjZtVDdDdlJMYmtsMFA0YjRy?=
=?utf-8?B?RDNJUmU4cnkxYTFxdkMwTGRMUGhiUnkxd21zajRES2ljTDJDY05BaENHMmE3?=
=?utf-8?B?LzhCOW9qQThSSGlIbmZTVWl4Uks3dlZrSlRaTnlENE1LMi9ma3pERVRIWk95?=
=?utf-8?B?VU1MWnJmVTVlWUM2YlhsU1Q2cFVFdit5SE5ScEQ4aENaRWFGcnNVQVk4T3R6?=
=?utf-8?B?L2pSZ3l0c1llOEJyZzUrYWtYYkc3ZFBTcUFLekVud1N2WDlUeHJSdksrUFRT?=
=?utf-8?B?bURWUzVkTnBIeEdTQm5ZQjBkTmMraWRzTDBqK1JGOWVHMXllVzBBNXIwdG44?=
=?utf-8?B?WnR3cDhHREoyN0VwUERHc0I0eVNiRWdQZ2ZNNWNqWnRoMXFTRFRmRGFqQUVU?=
=?utf-8?B?cjZiOE0wZmZrM3lpMHhNQ1Vpb1RFUUNKdmZxYVphY3NlZDRCMGI4bjJ1YkNy?=
=?utf-8?B?TGp1aEdPVTJNcFVwV0hMTzhxT1lhdjB2NGFicjNVcHBpZFFTa1BCWXFuWkE5?=
=?utf-8?B?L3cwaHhtOHMzMTc1RThOa2lTbXh5SHRPcmtnVU5pbWZRYThLcldDZklCN3ph?=
=?utf-8?B?cFVHQURBNWZGK3FtSDZuSmFTMXI0TTVsREMxWHhoTmFHUjdZRHN1b0E4TXhh?=
=?utf-8?B?cStMSFF2RDlRK1E0ME1hdS9EUjRaRmZESDV5K2JQT2tReG5LWllKUHVHL096?=
=?utf-8?B?ZzFSNFlySVlqUFk3b1FyemVwb2dydkNkelpXbk80ZzR5anpBWUlRT1hHUERS?=
=?utf-8?B?VS9aUGVYM2Jlcjc4T1dwamw2dmZja0ZZQ1NtcDVMZkdxK2VmQ0VaWHNFaTRC?=
=?utf-8?B?aTdJZFF5SGx1UTU3akluTWNDRnovdCs3WjNHeW9SSm1CZy9maUk2SlRIYklU?=
=?utf-8?B?Y2E3SU9KSnljS0lHZ09NK29USXhkSXlaYUk5Tm1qTFAzSHRLVnVld0gweHJR?=
=?utf-8?B?UVNQRjlzYjNFbTNCS0JTdm1qMG9aVzJBZkx1ODlqOVkrWE1YTVVSMEt1OW9z?=
=?utf-8?B?TFNKWisrOS9FK3grbUNhVkRZMjZqNXVnd3lUNVhKTjZlN1MwS1dFNTJaR0hG?=
=?utf-8?B?NHBUdnVoNFAyQmNqU3VsT1BwWkYzUEhwTmVwUm9jQ2F3dXJQdVNtbGhGaDMz?=
=?utf-8?B?NHVrazhDOWpYK3lyL1k3WXgyMHZ5Mk0xN3UvZjRtdXF1N2JmVGQxaW5oWEtI?=
=?utf-8?B?T09wM3lOeHQ0eUdxMUMzSm5XNGhTNUtMbk0wMFVwR2QwYk8ydDRQUzVWV2Nr?=
=?utf-8?B?R1pzaUJDTFUxTG5ZU3B5eURtUEc3dFhHMnZZQys1VDVJMlRzZmprSC9va1VN?=
=?utf-8?B?NEREU0NjY0tLK3kyQVN1aW9IQ0oxQ3Irb1NUOFhmaTI2MVNiNWlPYXBibmI1?=
=?utf-8?B?QTRoUWxTajdDYXBLNW43aThEVUZOWUNNQkZDYkxCMFhVRUJDenZlYURlSXBp?=
=?utf-8?B?ZDd6QlNsMURGOW85eXY4dkFqSm9ZS3cvU1M0RUt2MldlNUhJQnpQb1g5RDk5?=
=?utf-8?B?ekFVSnFjTURSK3RhaTFUcFVsNFlWYlZvTEZOUFR2R0pNV3c5ODltU2V0MzdO?=
=?utf-8?Q?2mZz7PIKXz2rBlRCWIRg8aCHEr294PjZMOX7+tw?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fb939d6-0cbf-422f-f445-08d961569993
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2021 08:11:22.3563 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wc3uuLYnvD6BcQBWHSw9Ndmm2qtDdVvn93xvfuDTERhHKZgcnrGLpjYbBlBhGE6rFGNt3rYcWONpuHXZbO72Og==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5077
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v4 2/2] net: added macro to extract MAC
address bytes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 8/17/2021 12:03 AM, Stephen Hemminger wrote:
> On Mon, 16 Aug 2021 15:27:28 +0530
> Aman Singh <aman.deep.singh@intel.com> wrote:
>
>> Added macros to simplify print of MAC address.
>> The six bytes of a MAC address are extracted in
>> a macro here, to improve code readablity.
>>
>> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> The change in the document will be done in seperate patch.
>> To ensure document has direct reference of the code as shown in
>> commit 413c75c33c40 ("doc: show how to include code in guides").
>
> NAK
> The DPDK already has rte_ether_format_addr()
> why does so much code not use it?
>
'rte_ether_format_addr()' formats string to a buffer, but most of the times the
need is just to log and having a buffer for it is unnecessary.
Both macros look useful to me.