From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F50DA034F; Mon, 7 Feb 2022 12:46:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A048410F3; Mon, 7 Feb 2022 12:46:23 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 86E11410EA for ; Mon, 7 Feb 2022 12:46:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644234381; x=1675770381; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=ImR1AEFULwAmFD5cAcTGU56q0TkCuFMuQAmCWDnZ4FE=; b=cQj6PSYBaz+wf7c96s3C6ALeNKmKRpBpGPa5YmkbaNx8Q5g30/ynYZka znXajDvDRQX8WwsjIf2z/5m80LNucE8pt7D3SEcWRdqOZrVAp3D+ZQ9fN sOAibdm5R1Ur9ksLt663qXwzYdrBVXwmHjwFWsrUrmK+BLrW2DJST0KWO glQlHEUmMssHtu7t/w/ISMToklXafO2cNolnShfQeBNkVhnsQG2R/Vbo9 3kO+9Sbgw2OFiCVQO3FexZYsPbVWAxt7ROF3CzLUPjmlZW/6PL0bzOPTz Q8eoBfX2HhCyTadIKWlPsmFGImi0AyowwKCcydxNgJaKdDZIDiBCerBmc Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10250"; a="248648368" X-IronPort-AV: E=Sophos;i="5.88,349,1635231600"; d="scan'208";a="248648368" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 03:46:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,349,1635231600"; d="scan'208";a="525103267" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 07 Feb 2022 03:46:20 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 7 Feb 2022 03:46:20 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 7 Feb 2022 03:46:20 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 7 Feb 2022 03:46:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HHpinIuScn2KBMcDySMdBe61fVxNtNIA2Hr3aC1dpeQND2i1DoxZehaWQg0JTv+bIkCvKy+BQCCFkPRCgl8is/VZhaZyDp/AcwNsD0iMtZvWok06enK9NEIOsDDTwl+G0E6qHonRGNT9t9/PDIxM3JO86Yr/YL0SKZsL3KXLgKVQsrFggIza6YJde1DZcpcCVyXUeuypsW0bdjNCkb2l5QqEAQYdzPHgW3zabe56WEHapbPuQhYlvNs6fbt8xs1t0eavizFJJYezQojzpi9/V5LABVzHoHp7Pp6SkxZXx5u+EViZbRJLDylez/la51Iw+W9/mWMOqv1VDIjL/ulVAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lfq1g84WWGKTle2w8D/NW+wMGrtiTROKwT/Ho26jbtA=; b=G/iKWnuUc4tlP6rOZySANKXiwWRfbXjvhTEIX+YdAUbDlvcVhBSsQ+wQ94pJKmVyNsNUYNMqZyLKDLlpesd2HDLgEKuT0YSL8LFFnreV9bozPgjrlRaLpKzKKlkhNCJeSxIeAl3B8r5UChF7g2fitDX5NVjJ6vP0QeB1qVdwP3cZtND+tRn7nSypxIdB17BKO7zwijojFxAb9XZuygJePr2MK6bQqAM6ByQ3EIGvLnWGaIggFYuRQbmfqyD1L/u9f4i5FOmCHv/BF+SnLNDnlc+m2xH3cy4NKX5gbwDFDQwB0LRhIfSTOBuXxR6fHB6gS8bNwSEe1LDGmI8ZnvwDUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MWHPR11MB2061.namprd11.prod.outlook.com (2603:10b6:300:28::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Mon, 7 Feb 2022 11:46:18 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.019; Mon, 7 Feb 2022 11:46:18 +0000 Message-ID: <8b129213-8d64-0b9e-8bb3-5faa8bfdd2d4@intel.com> Date: Mon, 7 Feb 2022 11:46:13 +0000 Content-Language: en-US To: "Min Hu (Connor)" , CC: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Ray Kinsella , Ajit Khaparde , Thomas Monjalon , Andrew Rybchenko References: <20220111115437.32855-1-humin29@huawei.com> <20220207014719.16611-1-humin29@huawei.com> From: Ferruh Yigit Subject: Re: [PATCH] ethdev: introduce ethdev dump API X-User: ferruhy In-Reply-To: <20220207014719.16611-1-humin29@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0495.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::20) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 43ece240-00ab-45c1-4066-08d9ea2f7422 X-MS-TrafficTypeDiagnostic: MWHPR11MB2061:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iUmC9zfXLiG7slY5aqWnG8TPFfBQyh/3aKxnAXzI9gn5xDGjYZ9zBLFIXC6ImIOzN32yOFofM6CCrOEa9w/Wzx23qbk5vbfVLM54SXKcq690ZaHCUpjtgGqZRbsLTmjjr/Dm41ZdoUN0jJkBG17qbRVMFn+K2q5qW+gHmDJQA6pLAC+To/BnwO/QkTYG6QKnkZuTrUbu79Hj1PVSQQF8V8FOiqLLkK4HtGVFEXaxp1MCLLfLRIbiXRQd9KgRsKSf7/osjiiTDgc28Xqzml+kHq43Ul6FD1C+AKe7wzZAKtsP9MxwKh1HsYq+rBqFCArywxWmv2sfl1j7fy7jFsi0xX2c5zy+JHMG/XC/txmGdpZCxnNZtnx/Jg+LNkVoVKCtNbH4e8p3+cY9IKe2fJsXZ5JQZG2a5To46OIR2Q0V8D+gAk62fBSeYPXav1RHUXby44GuAMugwk2UPgCOctzZ1tOAo0pPquO6dMGKPEMHTDIiBX+OzUuARPROjhwGcNRFTCWsTV1h3AFOMGTm7ewCVQZqpF4wUc37Bco5UAyXepl5yNM0A5j4ZxlkYwbQeCewNTVB4Tuw5x3KvmVKKRpT/HDp8j79MSq5A5LT+/ly1p97zdGRvRBgLerBif8rmLz3PCK1JH5Vg6yBjzfJJ6vGCmnwSNMraON6x9tP+hWRM33lO0cV7IedR1/fsjmsFnXCDIzMVMCbj0hjIzO19NEnXA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(53546011)(38100700002)(54906003)(6512007)(6506007)(6486002)(6666004)(26005)(316002)(86362001)(55236004)(8676002)(2616005)(31696002)(186003)(508600001)(4326008)(8936002)(66946007)(66476007)(66556008)(36756003)(83380400001)(66574015)(31686004)(82960400001)(2906002)(5660300002)(44832011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDFMdFhsYjR2M2UvQ0c5cWxzUTBnek5sMnNxdE0wVEFRVUZ4cmljam5lSXhj?= =?utf-8?B?ZDEybkg1QU1nUWJwSzFlTTNvcndvZDdobHhuQ1ZRc3NyY1R1UzU4aG1vU0Nv?= =?utf-8?B?MzNDOUxVUmZIcUcwaEt6aEJaR1IrcHVMQmhlUk41M0V4bDNQMTdCWmtaM2Rm?= =?utf-8?B?MkhIN2lUS21xTm1oQ0dHS0kyb1E0NEZPNGx0VHhqQXd3VjRiRVVMc1pWM1hj?= =?utf-8?B?ekpqZzBHY1R2YW1MdXNOTWpZRDJpK3c2UmxmODVUN1FBVk9ZSzR0OUUyV2NY?= =?utf-8?B?Y1NxM2MzVnVPeXJ0M1Q2RUtvV0w4MFE1aXNyWkh3c3VUc1pXOTErdTQ4aHdR?= =?utf-8?B?T21YdU9qc2E0NGlaaG43RmFQNGtlMmI3dzV6Uk9lbUZ1eFRGNXRlaFRVWmdh?= =?utf-8?B?OTA2ZlMvNE4vVGdzMCt3dVRPY1VFUElPQU1UaitZczF2bUxGK3NLRSsrckJh?= =?utf-8?B?dnJMci9IWGVTS3pXTGNXWVoyN1hhNDVINVZtaXVTbU5OejVFUXZXSHFGNmRT?= =?utf-8?B?NTBqMEN2VTkyN0JmbE5Ub2pqZXBoWWMyRXF1eUJoeG9XemcwZVhKNUtIZkpX?= =?utf-8?B?WGdKaXR4b051aXVkTVJBOStSR3JzVStBZzRHeXA3dlNFT2RaYzZzQnNBUndt?= =?utf-8?B?a1hXa2JvSVhBRmdjSGNyOHFBNVdJRnQ4Q2hDeWVOdWVFOEVsR3kraHg1ZVpQ?= =?utf-8?B?bTNPcEVYN3NweUdGL0JybmFRcVNTUU5PVklyaEJacEVXWXNiK3lhcG5rc2kr?= =?utf-8?B?dXhDbk5YdFpRNEVsaHlvVWpob29NMkFZS0ZNVmhYZGZqRWY0VWJTZEUxaCtN?= =?utf-8?B?UlF4bWkzWGxrM1NKQ3Vod3pDZWVUQkRDV0VaYjJUamdxSURvNUprUzZhT0lL?= =?utf-8?B?dkpaK21iSk9zQmQrWkM5VUo4bWVWVFFwNlNTVnFMc2piOFpqUkM2RllrdWhJ?= =?utf-8?B?VGJnVHQ3ZEhLRWZscXg4UTB1RWNqcUMybHZOTWlXKzU0dU9IK2F6UUF5ZDRv?= =?utf-8?B?SDVNekNSZStydmhBaDNJSmRzZ1ZZYTlLTVI3VjQrN201R2QyVzdjbmRCQ3VI?= =?utf-8?B?d0k0RmEybnRiKzhxZGQwT0owZkswS29adGdET2kwR3JSZWhic2R5YTVmT0NS?= =?utf-8?B?OVh3WGJkclNSak5KcForcjBTWk41dW1CRFQwMHZ0Uyt0WmdZeDVCVDV2Y0xn?= =?utf-8?B?L1pWN1B5bUd5OUV5bS9uTDJHdmZkM2NZdktJOHROakt1blB5N0FHVjNlTGlw?= =?utf-8?B?dHd4TVpiNVMwa3A1a3VyU0tXRXp5SDZ0V2p6Sjd0UzlnNUc1U1lDUXJzbDND?= =?utf-8?B?dnVCODUvRkYvSVQzeitCS0gvR1p5QVRQcEhPQ2phalZKTUxSTHJlZXREaTlT?= =?utf-8?B?RndaUHNvSnhKRmNnUkd6d0c5UHNVaEYyYnUraFBGNGcrUExwOGR1R3JNQXVY?= =?utf-8?B?K1MwSzVvaEJHWlJya1Jvb21nOFRia0J5VzRHblV0NkYxaDEwSGNxYVNOYzU3?= =?utf-8?B?b1pVWDJpZ0xOZE5aSnBKU0FlZFZwTWpGWVlIU3V6NDlvY3lQR3Y5YndBQWZp?= =?utf-8?B?RUoxVS9tTnR0dVhoZTFjblNhelpId1RpcXNLSWdxRFQ2YmVFV1lGeEdxVXli?= =?utf-8?B?WE5lS1pWbm53Ujdxa3F4UjJPd3BsVDJzbnhrdFdna1ZhZ0Nlb3ZtQ3JiREpa?= =?utf-8?B?a1J2NVI1UFlmVy9vMUFJaGgvQktncHVVMnNrMWJZdVVCNmhTbEdEV2gwQnVz?= =?utf-8?B?RHYxYnhEZmpWQjlqclFRN3JUd3pIbDJra0FrRU56b2d1V0MyNURPZkdhbGZa?= =?utf-8?B?NHhob0FWcWRsOHc1TUNTdmI1R2pTMnppV0ZQVUF0RHhvMDVrQUlPSDRweEw2?= =?utf-8?B?ZERMVzhLOGtkZkRrSTl1c1UybzZYUloxY0NiRDV5dVcxcUFQTG9KQmJ2cDZo?= =?utf-8?B?VytzVWttSnd3dVAxY3UyekhqZHErZ2ZwYWZzUmMxZ1Y3MUdGMTUwQnlEc3dJ?= =?utf-8?B?NDluVHVhS3AxK2tQWTRYeFNNbjNCam5meGZxQWJ6cmxGY1dhU1R0bVkzWmM2?= =?utf-8?B?bzZ5cXY1SExTcUNLamNxUVJTSTlEczlGR0pXd1o3TWp0K0t6NWJTMnR4U3Nu?= =?utf-8?B?SWN2RnRHT1F3MGVWNlhHSzBaWnh6YldLMzV3QjRTMWZEK2dkTTJFRE1wN0cx?= =?utf-8?Q?FQ8CiCIHxr2B8HAWdE6Fj54=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 43ece240-00ab-45c1-4066-08d9ea2f7422 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 11:46:18.5056 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Cn0xtef7UwZ70y98SvUIwBS1NNh7Pb76i9D4VAvIgnhJTzZ9CDrJbz38kLStXeYeMccyWYfvy9LFeoxRDAu1Cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2061 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/7/2022 1:47 AM, Min Hu (Connor) wrote: > Added the ethdev dump API which provides functions for query private info Isn't API and function are same thing in this contexts? > from device. There exists many private properties in different PMD drivers, > such as adapter state, Rx/Tx func algorithm in hns3 PMD. The information of > these properties is important for debug. As the information is private, > the new API is introduced.> In the patch title 'ethdev' is duplicated, can you fix it? > Signed-off-by: Min Hu (Connor) > Acked-by: Morten Brørup > Acked-by: Ray Kinsella > Acked-by: Ajit Khaparde > --- > doc/guides/rel_notes/release_22_03.rst | 7 +++++++ > lib/ethdev/ethdev_driver.h | 17 +++++++++++++++++ > lib/ethdev/rte_ethdev.c | 15 +++++++++++++++ > lib/ethdev/rte_ethdev.h | 16 ++++++++++++++++ > lib/ethdev/version.map | 3 +++ > 5 files changed, 58 insertions(+) > > diff --git a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst > index b20716c521..5895194cde 100644 > --- a/doc/guides/rel_notes/release_22_03.rst > +++ b/doc/guides/rel_notes/release_22_03.rst > @@ -92,6 +92,13 @@ New Features > * Called ``rte_ipv4/6_udptcp_cksum_mbuf()`` functions in testpmd csum mode > to support software UDP/TCP checksum over multiple segments. > > +* **Added the private ethdev dump API, for query private info of ethdev.** > + > + Added the private ethdev dump API which provides functions for query > + private info from device. There exists many private properties in > + different PMD drivers. The information of these properties is important > + for debug. As the information is private, the new API is introduced. > + > Can you please move the update up, just above the ethdev PMD updates? > Removed Items > ------------- > diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h > index 7d27781f7d..d41d8a2c9d 100644 > --- a/lib/ethdev/ethdev_driver.h > +++ b/lib/ethdev/ethdev_driver.h > @@ -990,6 +990,20 @@ typedef int (*eth_representor_info_get_t)(struct rte_eth_dev *dev, > typedef int (*eth_rx_metadata_negotiate_t)(struct rte_eth_dev *dev, > uint64_t *features); > > +/** > + * @internal > + * Dump ethdev private info to a file. > + * It doesn't dump the 'ethdev' private info, it dumps the private info from device. > + * @param file > + * A pointer to a file for output. > + * @param dev > + * Port (ethdev) handle. > + * > + * @return > + * Negative errno value on error, positive value on success. > + */ > +typedef int (*eth_dev_priv_dump_t)(FILE *file, struct rte_eth_dev *dev); > + > /** > * @internal A structure containing the functions exported by an Ethernet driver. > */ > @@ -1186,6 +1200,9 @@ struct eth_dev_ops { > * kinds of metadata to the PMD > */ > eth_rx_metadata_negotiate_t rx_metadata_negotiate; > + > + /** Dump ethdev private info */ Ditto, not 'ethdev' private info. > + eth_dev_priv_dump_t eth_dev_priv_dump; > }; > > /** > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index 917a320afa..07838cc2d9 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -6485,6 +6485,21 @@ rte_eth_rx_metadata_negotiate(uint16_t port_id, uint64_t *features) > (*dev->dev_ops->rx_metadata_negotiate)(dev, features)); > } > > +int > +rte_eth_dev_priv_dump(FILE *file, uint16_t port_id) > +{ > + struct rte_eth_dev *dev; > + int ret; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > + dev = &rte_eth_devices[port_id]; > + What do you think to check 'file' pointer against NULL before passing it to dev_ops? > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->eth_dev_priv_dump, -ENOTSUP); > + ret = (*dev->dev_ops->eth_dev_priv_dump)(file, dev); Should 'eth_err()' used here? > + > + return ret; > +} > + > RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO); > > RTE_INIT(ethdev_init_telemetry) > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 147cc1ced3..1c00fdbcd2 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -5902,6 +5902,22 @@ rte_eth_tx_buffer(uint16_t port_id, uint16_t queue_id, > return rte_eth_tx_buffer_flush(port_id, queue_id, buffer); > } > > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice > + * > + * Dump ethdev private info to a file. > + * Ditto. Should we highlight that provided data and the order depends on the PMD? > + * @param file > + * A pointer to a file for output. > + * @param port_id > + * The port identifier of the Ethernet device. > + * @return > + * Negative errno value on error, positive value on success. What does 'errno' mean here, does the API cause errno to be set and return it? Also it is possible to list possible specific error values, as done with other API documentation, like: (0) if successful. (-ENODEV) if *port_id* is invalid. (-ENOTSUP) if hardware doesn't support. .... > + */ > +__rte_experimental > +int rte_eth_dev_priv_dump(FILE *file, uint16_t port_id); > + What do you think to have the 'port_id' as first argument to be consistent with the other APIs? > #ifdef __cplusplus > } > #endif > diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map > index 1f7359c846..376ea139aa 100644 > --- a/lib/ethdev/version.map > +++ b/lib/ethdev/version.map > @@ -256,6 +256,9 @@ EXPERIMENTAL { > rte_flow_flex_item_create; > rte_flow_flex_item_release; > rte_flow_pick_transfer_proxy; > + > + # added in 22.03 > + rte_eth_dev_priv_dump; > }; > > INTERNAL {