DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Haiyue Wang <haiyue.wang@intel.com>, dev@dpdk.org, xiaolong.ye@intel.com
Cc: ray.kinsella@intel.com, bernard.iremonger@intel.com,
	chenmin.sun@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 0/4] get Rx/Tx packet burst mode information
Date: Mon, 14 Oct 2019 13:11:55 +0100	[thread overview]
Message-ID: <8b2fb1ae-81ff-c891-50b0-643820044732@intel.com> (raw)
In-Reply-To: <20190926145444.114485-1-haiyue.wang@intel.com>

On 9/26/2019 3:54 PM, Haiyue Wang wrote:
> v1 -> v2:
> 	1). Change the return type of dev_ops callback from 'void' to
> 	    'int'.
> 	2). Update the ice/i40 PMD patches with clear git commit log.
> 
> RFCv3 -> v1:
> 	https://patchwork.dpdk.org/patch/59103/
> 	https://patchwork.dpdk.org/patch/59104/
> 	https://patchwork.dpdk.org/patch/59105/
> 	https://patchwork.dpdk.org/patch/59106/
> 	1). Use the function 'rte_bsf64' to iterate the options for
> 	    getting the name.
> 
> Haiyue Wang (4):
>   ethdev: add the API for getting burst mode information
>   net/i40e: add Rx/Tx burst mode get callbacks
>   net/ice: add Rx/Tx burst mode get callbacks
>   app/testpmd: show the Rx/Tx burst mode description

Hi Haiyue,

Overall lgtm, but what do you think adding a new feature to default.ini for
this, something like 'Burst mode info"?

And i40e and ixgbe patches can add this feature to the PMD .ini files.

Also please remind 'doc/guides/nics/features.rst' also needs to be updated with
default.ini update.

Thanks,
ferruh

  parent reply	other threads:[~2019-10-14 12:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-26 14:54 Haiyue Wang
2019-09-26 14:54 ` [dpdk-dev] [PATCH v2 1/4] ethdev: add the API for getting " Haiyue Wang
2019-09-26 14:54 ` [dpdk-dev] [PATCH v2 2/4] net/i40e: add Rx/Tx burst mode get callbacks Haiyue Wang
2019-09-26 14:54 ` [dpdk-dev] [PATCH v2 3/4] net/ice: " Haiyue Wang
2019-09-26 14:54 ` [dpdk-dev] [PATCH v2 4/4] app/testpmd: show the Rx/Tx burst mode description Haiyue Wang
2019-09-27  8:14 ` [dpdk-dev] [PATCH v2 0/4] get Rx/Tx packet burst mode information Ye Xiaolong
2019-10-14 12:11 ` Ferruh Yigit [this message]
2019-10-14 13:50   ` Wang, Haiyue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b2fb1ae-81ff-c891-50b0-643820044732@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=chenmin.sun@intel.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=ray.kinsella@intel.com \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).