From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A04A8F8C0 for ; Wed, 11 Jan 2017 18:37:02 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP; 11 Jan 2017 09:37:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="51869791" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga005.jf.intel.com with ESMTP; 11 Jan 2017 09:37:00 -0800 To: Stephen Hemminger , dev@dpdk.org References: <20170109233022.31154-1-stephen@networkplumber.org> <20170109233022.31154-5-stephen@networkplumber.org> From: Ferruh Yigit Message-ID: <8b31507d-f03b-7bc5-0868-7320ed6d2662@intel.com> Date: Wed, 11 Jan 2017 17:36:59 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170109233022.31154-5-stephen@networkplumber.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 4/7] kni: remove useless return statements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 17:37:03 -0000 On 1/9/2017 11:30 PM, Stephen Hemminger wrote: > A return statement at end of void function is unnecessary. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_82575.c | 4 ---- > lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_i210.c | 2 -- > lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_mac.c | 4 ---- > lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_phy.c | 1 - > lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c | 3 +-- > lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c | 2 -- > lib/librte_eal/linuxapp/kni/ethtool/igb/igb_vmdq.c | 11 ++--------- > lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_82598.c | 2 -- > 8 files changed, 3 insertions(+), 26 deletions(-) > I am not sure about benefit of refactoring drivers in KNI, since we have no intention to do development on that code, at best we can get updated version of the driver and replace, which I don't expect to happen soon. But if you have strong opinion on this: Reviewed-by: Ferruh Yigit