From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75FF345BB8; Sat, 26 Oct 2024 01:48:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 443DA40295; Sat, 26 Oct 2024 01:48:08 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2059.outbound.protection.outlook.com [40.107.244.59]) by mails.dpdk.org (Postfix) with ESMTP id 91D2A40273 for ; Sat, 26 Oct 2024 01:48:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xdxB4ziQTkti1PR2CkKK1b9T78mUhN0mlHXPfzteKyt3zWKQ3zPQt6rMdpX1jfAI0v60JoE/78angQV173tlxcUVWXCKiI25g3ENDKWoUXtqMkeihmOOtPRHupbrp4OOXKgJdzWUT/g/wFFPPcLx+Jo6I0n8M98XIDHj1fhG1ZbX8j695YOvzpaatveDWwoYf4e7e2JHhujpz9CA0xFCCv9Ms6Z5vKUkSIOMMFRpw//lOCo7l7TalNE4GUvnsdKhCvONADOMkn83R73AThncF8aljqFg68KB1f4UW4fmPwvObxoZrhzheKW8rG4aTl8subn1QlbvSN+HfHNdBN6m8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rLoxRVvsZB7wzQc1XrfUqhQWeduVKleCvURaRGPLuSo=; b=aJP7GOe4dQq4mJI+Awsb+4h+omRlGj3x/Z4E/Fx6GuHklvfw+wMSWOdx3+TZDF12+jE16KKG7129NnyAcQ2VfJGJhjO++LmbLdPT2UnV132tY0VJEX9b40uyspii6nMDnV6eA2pU/EWYV1hJ9cYMJ6JYzy9TlXPA7+xfNkuc81xPplwo5+1gHpdLsN+8AqnZjEzLANou0KIXXY8zlIwvZXsjBfLoGr7AAxDnT0lspdYUOhZ2rQXBtX49B/rAGWEGbNnO/4jNAhGboM66wa0z/dlkXByNEt5+c+LnVVfWszytnmoRlKbEUhzTPUbCB/ZfT2nQpD+2n/908bacdjQ2nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rLoxRVvsZB7wzQc1XrfUqhQWeduVKleCvURaRGPLuSo=; b=hFrr7YgBC7gVNcOtsj1dZNGPOQ2ZeSVyzVCca7wZxAkUiBA2C2YSWbD9Sp+rfGDrDrVch8Gvmw/AIYphPuIVNhWSyXbAnDQJwUQlvg8OHkqL15+IOvujQhv/fFdY1N+znMQo7DUnj1GyhGWmng4OsTlo8EJIj1sK4eCjtCqM8tU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by CYXPR12MB9317.namprd12.prod.outlook.com (2603:10b6:930:e2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.21; Fri, 25 Oct 2024 23:48:02 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8093.018; Fri, 25 Oct 2024 23:48:02 +0000 Message-ID: <8b463454-b62f-4330-b602-14752436561c@amd.com> Date: Sat, 26 Oct 2024 00:47:56 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v01] net/af_packet: don't specify protocol on socket create From: Ferruh Yigit To: Stephen Hemminger , Gur Stavi Cc: dev@dpdk.org, "John W. Linville" References: <20241016183811.338dc230@hermes.local> Content-Language: en-US Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0083.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::23) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|CYXPR12MB9317:EE_ X-MS-Office365-Filtering-Correlation-Id: 86b975ac-2844-4260-767d-08dcf54f7674 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?azJsM0hZeXhUQWxqZzArOWl1NmwyaUQ3aGZyMlJkcjNMNStCTGhxWG1DU2ZD?= =?utf-8?B?MXRjak53NTI5ekgrN2JFaUpJR2x5S1UwRmxPSWRBWnE4Q1pvbTh0aFZTak10?= =?utf-8?B?bHV6NVpaSVFpQThKYytaaHB1QWE0ZDRMVEZRY0ZGcTh3cXdXS1EzWkFLUFFO?= =?utf-8?B?Q0NUZG16bFVJTXV6eUd3aC9Zc09mNEVEcEN0SGFNWnRGaTYrQ2ZLTXVkOExU?= =?utf-8?B?cEN1TmJIQ0hNbFZTSis1WEhZNWh4aERIYTFGTzNPSTg0cHhUM0sreC9LNmtw?= =?utf-8?B?c0hwdmt3V2VTb3FpZTRrTStvS3dGd1QrRnJWb1p3dU5sUWhnSGROSzQxY3cw?= =?utf-8?B?SkVENnF5ZTVNWVg5djVHck9ReEpJdnJJbVRZMUFRcnM0QW1uOWwzZXdwclJE?= =?utf-8?B?c3hyRWkvY0ZNN0lxYkg5OFJaZWU0aWtvdy92R2VFSGlTaHhjU25ZdmUvcldS?= =?utf-8?B?ZEsydVJPU3A1NWVCaU1vTFp0bHBDejRwdUlNNlRtSGNlN0pLbnpBL09mT2l1?= =?utf-8?B?TFpmd1dBMGF4cXZPV0hDaG5HK2tXZjVlOHZVRTd3c2s1Nnlyb2Mwd0lJbkpP?= =?utf-8?B?Y1VKTDlrVXZnbUFpNXo4V3RUMTdxNXVuajZwdEJFRjFGa0VWNUt2MDA1c0Vu?= =?utf-8?B?M3JDWGFiOUw4K2I3aExUMkF3SWpaRkVrU0IxZTc5enZKVEVFcndtOHZ2S3pE?= =?utf-8?B?WmZTVmF3czdsTno0d05vRFRzcjVsQkZXdUQ4c2tENmFnSVNtdU1sRzAyUGZZ?= =?utf-8?B?MGxWN044YWJpNDNIc1BBbk9IZUV5YmVjYVRYT3NxL2dHK1hMWkJuRk5xMXV2?= =?utf-8?B?VnhDUGJsZnZnTWMydVYzRG5ER2JodXRGTVl6aFMwQUV5bURCS1B3S3pXejYx?= =?utf-8?B?NkQ5ckxCU2RQdGdFOWc4cm1Nb2oyTm1HWGhrM09SLzlYeG56K05XTm1qK0Mw?= =?utf-8?B?d0lJS3JGNXlyZGplMkhSeDhWQWhZRVBORE05bWdwOWtsbDllMno2N0hlTnN2?= =?utf-8?B?UmZLOThjUDlORzlqSUROVmE2bnFueWdTZVNYeXJhbnIyWG1Td3JqRDVNSUtQ?= =?utf-8?B?cGZJMGo2WEt5RWdjVHQ3SmRXcm03SEV0V2hGanNkeCtUcVdsQVlqcTYwV2lC?= =?utf-8?B?eEszZWdWSjFvZHl3MGY4YjlFUWltajJFekpodzhNTjFBQXFCSlA2V09Yazdj?= =?utf-8?B?VHIwVlgxZTJZMDZWM0FzMDVmRXI3STJPQkRhS3JUQmtaVllvWUQ4MjZadHNQ?= =?utf-8?B?Qk5vZWduK0hsbEVyWmFWK285M2oyRklId1RYWDV6bmx6eGhseWJSUlcvbWRr?= =?utf-8?B?SFpHc2JXTGhzYnI4UUpsODRMZVIrOFlnRkkrNmh1MXFIL2t6WkxlVzUwUlpR?= =?utf-8?B?aHF2STM5MFVMaU9YcVp3ejFhMXlYNXh2cFdsenF6aUlaekU4VUNWcEtNSTZG?= =?utf-8?B?WXcxL3dweUM0VXBoWHRXclR6Slp6Qkk2eFhvcGNadW53aXdKVy9jM1pMQ08x?= =?utf-8?B?d2R3MFM4UUlDbzZraEtsUWJNbG1ZWEw4dVBnaG80dkt5RDlLUHlFbXMxMTV3?= =?utf-8?B?N3BHMFJBaVBTL0psVDQyMUFrdnVnYm12bkptTDFHWVcvZE5yd0RxWlZUbVNP?= =?utf-8?B?MkgvRWt4V2szOVNYbjhyR2JTTURwaytuRlNkWEVHYnBkK0lyMnVTRm9PcVNK?= =?utf-8?B?NDVjOS9KQy8vcmY5WUtlcFZXTDlsanVuaFEzOTJKVXhGYWRtZ2tDVGZ0cTly?= =?utf-8?Q?RilY4IkG0ll376Phig=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUVVbHJpMUMyMlhNbndINGkvQ0dBL3hyeWhORFNBZGtZZHRuemVVa0VpdW9I?= =?utf-8?B?WGNjUEorV2FiWVBjL282VE1vdG4rdkZibWpodlVIeUI1M3N0em5ueUdyVXlr?= =?utf-8?B?d1F5Z2pKZXQ3a2M4QWkyaDJhYkJxR2QrdVZNRFNrT1ZXejMyWUIwSVhJU1hK?= =?utf-8?B?TitRVFF1T0h1OCt3Z1BWak4xbkJPcE80d3BQMWJMa3BvcXVhMmVzdjV2NERS?= =?utf-8?B?OUlSazgxZDR2WkhlYTZsNGlZMm9wOURpU2lNcDNUcWQzZVAyb0ZmT2FlZHov?= =?utf-8?B?VDljbmNRMjZRRVJCanFxU1VBT09xYXJ3dWRjUlBvVFJOQXpJcjJrajVHQ2VK?= =?utf-8?B?RFR1NEc4V0NNRmdIK3lkTkVNZk5icUtlODZsNDNhOStnZmFEVjJ6bXFWa1JE?= =?utf-8?B?NlRuM0EzVElzK2JBVVUzL2I0bGNzcXNjb2dFY1ZEZUYwOFR5RWkwdytJOTRW?= =?utf-8?B?RU5RMlFYaDl6VzN4aGpoVlJmOVhnd055V0NDanpRQ1Q0ZWQzS1dJYkxmQ2Vl?= =?utf-8?B?dW9JOXgyRy8yRzJaWno2R24xU0piWk5IN3NqRmV2S3lhajNESWUxTmw1UEps?= =?utf-8?B?eFNYaDQvb2UvV1ByWTh2LzJ1NlluN1AwTmx6eEtCR1V3YnJRMkNEaWp0NEZp?= =?utf-8?B?a0dNZndIMnNjRHh6bGJJVWR0dlBvYVhIRHhSanlENk5zK1BVUWszUjFOQWd3?= =?utf-8?B?cW5NNHQ5ajFXbUJSczBBaG1aVzJleXBBZlVwa2FGdVVQZHNRcVhCcmVRaHQ3?= =?utf-8?B?c2poK3lPZTltdjRjNWRlcTNZOTlMRU1MY1pySCttaG5zcU51TVdpY0NkVXRV?= =?utf-8?B?d3RlazdtMUxKdURCZGlBTW40aHVuU3QwYlVUQ2FrVHZkbFI3TW1QNzZzNVkx?= =?utf-8?B?UncxUTFNRVRtS1hwVlhOa2pUZHdNb0ZETmphMk8zV2c1Y0R0Y3RZb1dPTHhu?= =?utf-8?B?bXJyNlA5dDAwOWIyd3MyeWFZRytpb29OTUQzNTJseEttQUpwYzVDSU90UndX?= =?utf-8?B?eVRuQVB0MFVjZVFxY28rOFN0S2REZ25Hb0FkYU9mRDE1NklibnZIbGFNZjY5?= =?utf-8?B?ME9JQTZHS1BQMkhPZ2lWYUJHMmwvUENYZGMyNlAzYkRiYVpFSzNDSnU4QWE1?= =?utf-8?B?Nm9CRmlqSWwxcWZ5aXdBakRHeFFLL0svVWhtRlhYWjNteTZMZ3NBenBPZWVX?= =?utf-8?B?YTNBMEMyeW9WVzRyVHBZVzQ0enBTN3BwNFIyN1hJdExtYXphbndhTnBtUi91?= =?utf-8?B?NzJXa0JwUWpuWVB0K1VVdmZsRGZtOGk3YnFKOUFKV2VRc2VRbWxoYUljaGp0?= =?utf-8?B?VG1rZTNOTnhwNDVocDNIKzFHTzBJWmtoMkNMalQ0TVpNdERKVmdZWWtJU1hv?= =?utf-8?B?OXczcFg0aWs1blduN0RkbkxtSVZKVHQwYjliRTlpMmRUcGd6N1k2Nkhqc2pw?= =?utf-8?B?V2pqQmZaa3JkbGE1QVZaYlkxUU1OMERiWktoZHgvRGM4dmJ6M3QrSk1GdTBX?= =?utf-8?B?b3BxVXNoeFBJanRxYlZjUTkyc1dLcVRhYW9iaW8wVHEyd2M3N3Izd3h0Yk9j?= =?utf-8?B?ZkQyRzNNZjlnaVc0b0pXbzA0WjBCbXo4YXQ5NVZvTVQzVWNKSEhIeFZHU2FK?= =?utf-8?B?NllTL0RrODBRdmJvcm50b2NHSzR1OEhnYjA4akluR2VaZmhXUVIyRjA0S1R5?= =?utf-8?B?aU5WU3NUenBsU25FNGE3TUtLM2dZdFZPNXNXcVI1OElyK2Y1QUVJdWVHb2ov?= =?utf-8?B?S0VwaW5LN0ozRlFHWTlwK0VLQzNxMEpvcC9yLzV6Y0pkTldvVkcwaXpndDZI?= =?utf-8?B?TEhhd3hHMEhCRExNNXZaU0llcklNV25BRlg4cXVoM1FsSzZZY0dHZEtXa2tX?= =?utf-8?B?Z1JNVGpvbTRFYzlldkdJZm93MTFTeDVyQmd4SzVBYnNkTGJLcmUzYnROK2lF?= =?utf-8?B?NjFNYTdpZ1pRQnZnWjJJMitJd014Y0xyOXVmVzF3S3BDbnBXM0xjOE4xaVdq?= =?utf-8?B?cDQrc1RSV0VUbkJSY1h6blNUUnVMOHBoMU5RNWhmRS9iZFNkN05POVZLMGda?= =?utf-8?B?RmwvUytDTkhGbVBiR3l5YTRiaE1uWkRNMyt1enRTN0lJWEJKdmVCRUU1Z1h0?= =?utf-8?Q?CL98P0U3K8fdigi+Szg6xP3zA?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86b975ac-2844-4260-767d-08dcf54f7674 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 23:48:02.0585 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4jKbpv10H2sWEnHklsc7yQKOoWsdvmI55I97hKbv5gUb0vTkqx/38PbIC3A+GA+3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9317 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/26/2024 12:10 AM, Ferruh Yigit wrote: > On 10/17/2024 2:38 AM, Stephen Hemminger wrote: >> On Sun, 13 Oct 2024 16:59:47 +0300 >> Gur Stavi wrote: >> >>> When creating AF_PACKET socket with specified protocol it is >>> immediately implicitly bound to any existing interface and >>> becomes RUNNING. Calling bind on such socket is affectively unbind >>> from "any interface", then bind to the specific interface. >>> >>> When creating socket with 0 as protocol, it is created in non-RUNNING >>> state, then it can be bound to interface and protocol in a single bind >>> call and switch to RUNNING state. >>> >>> Especially with ETH_P_ALL, binding to any interface is not a good idea. >>> It is safer and faster to use the 2nd approach. >>> >>> This patch replaces protocol in socket creation from ETH_P_ALL to 0. >>> >>> Signed-off-by: Gur Stavi >> >> This makes sense see packet(7) man page: >> >> By default, all packets of the specified protocol type are passed to a >> packet socket. To get packets only from a specific interface use >> bind(2) specifying an address in a struct sockaddr_ll to bind the packet >> socket to an interface. Fields used for binding are sll_family (should >> be AF_PACKET), sll_protocol, and sll_ifindex. >> >> So there is a small window where the packet socket could pick up junk before >> the bind from other interfaces. >> > > Thanks, this answers some of my questions in this thread, also I did > some experiment and verified the same. > > I agree this change is more close the intention of the driver (driver is > not to get packets from all interfaces), hence: > > Acked-by: Ferruh Yigit > Series applied to dpdk-next-net/main, thanks.