From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AC7B11023 for ; Tue, 24 Jan 2017 17:03:18 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP; 24 Jan 2017 08:03:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,278,1477983600"; d="scan'208";a="56678698" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga005.jf.intel.com with ESMTP; 24 Jan 2017 08:03:17 -0800 To: Matej Vido References: <1485254992-12545-1-git-send-email-vido@cesnet.cz> <89bf9fb7-9101-2ff4-c4bf-8075424b6165@cesnet.cz> <1e1906b4-6ee5-ecc0-019e-28f0689c4d76@cesnet.cz> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: <8b485c9a-7595-4059-93a2-81a93d4e3041@intel.com> Date: Tue, 24 Jan 2017 16:03:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1e1906b4-6ee5-ecc0-019e-28f0689c4d76@cesnet.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/szedata2: fix incorrect device memory access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2017 16:03:20 -0000 On 1/24/2017 3:55 PM, Matej Vido wrote: > On 24.01.2017 16:11, Ferruh Yigit wrote: >> On 1/24/2017 2:02 PM, Matej Vido wrote: >>> On 24.01.2017 12:58, Ferruh Yigit wrote: >>>> On 1/24/2017 10:49 AM, Matej Vido wrote: >>>>> Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources") >>>>> >>>>> Signed-off-by: Matej Vido >>>> Unrelated from this patch, in maintainers file, you have your other mail >>>> address: "Matej Vido ", do you want to update it? >>> Hi Ferruh, >>> >>> yes, I will send the patch. >>>>> --- >>>>> drivers/net/szedata2/rte_eth_szedata2.h | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/net/szedata2/rte_eth_szedata2.h b/drivers/net/szedata2/rte_eth_szedata2.h >>>>> index b58adb6..afe8a38 100644 >>>>> --- a/drivers/net/szedata2/rte_eth_szedata2.h >>>>> +++ b/drivers/net/szedata2/rte_eth_szedata2.h >>>>> @@ -192,7 +192,7 @@ struct szedata { >>>>> } >>>>> >>>>> #define SZEDATA2_PCI_RESOURCE_PTR(rsc, offset, type) \ >>>>> - ((type)((uint8_t *)(rsc)->addr) + (offset)) >>>>> + ((type)(((uint8_t *)(rsc)->addr) + (offset))) >>>> Although output will be same, (in all uses, type is a pointer), >> Of course won't be same, please forget about it J, I am confused. >> >> So these two differs a lot, taking into account that offset numbers used >> are big numbers (0x8000..), it should be accessing very unrelated addresses. >> >> So how this was working before? > > The macro was fine before the patch [1]. It hasn't been working since > the acceptance of that patch, but I didn't manage to test the > functionality until now. I see, thanks for clarification, seems broken relatively new, and thanks for fixing. > > [1] http://dpdk.org/ml/archives/dev/2016-December/053241.html > > Regards, > Matej > >> >>> this >>>> seems the intention, so: >>>> >>>> Reviewed-by: Ferruh Yigit >>>> >>>> btw, following will do same, right, not sure if it is better: >>>> ((type)(rsc)->addr + (offset)) >>> This is also wrong. The intention of the macro is to add an offset to >>> the base address and typecast the result. >>> >>> Regards, >>> Matej >>>>> >>>>> enum szedata2_link_speed { >>>>> SZEDATA2_LINK_SPEED_DEFAULT = 0, >>>>> >