From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 62700A0096 for ; Thu, 6 Jun 2019 11:34:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 287E21B95A; Thu, 6 Jun 2019 11:34:03 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3C62B1B958 for ; Thu, 6 Jun 2019 11:34:02 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A781FA3816; Thu, 6 Jun 2019 09:33:58 +0000 (UTC) Received: from [10.36.112.53] (ovpn-112-53.ams2.redhat.com [10.36.112.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A13522A2C6; Thu, 6 Jun 2019 09:33:51 +0000 (UTC) To: Bruce Richardson Cc: dev@dpdk.org, tiwei.bie@intel.com, david.marchand@redhat.com, jfreimann@redhat.com, zhihong.wang@intel.com, konstantin.ananyev@intel.com, mattias.ronnblom@ericsson.com References: <20190529130420.6428-1-maxime.coquelin@redhat.com> <20190529130420.6428-6-maxime.coquelin@redhat.com> <20190605125304.GF1550@bricha3-MOBL.ger.corp.intel.com> From: Maxime Coquelin Message-ID: <8b522e8a-e737-6331-8537-d91da6bfe9bf@redhat.com> Date: Thu, 6 Jun 2019 11:33:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190605125304.GF1550@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 06 Jun 2019 09:34:01 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 5/5] eal/x86: force inlining of all memcpy and mov helpers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/5/19 2:53 PM, Bruce Richardson wrote: > On Wed, May 29, 2019 at 03:04:20PM +0200, Maxime Coquelin wrote: >> Some helpers in the header file are forced inlined other are >> only inlined, this patch forces inline for all. >> >> It will avoid it to be embedded as functions when called multiple >> times in the same object file. For example, when we added packed >> ring support in vhost-user library, rte_memcpy_generic got no >> more inlined. >> >> Signed-off-by: Maxime Coquelin > Acked-by: Bruce Richardson > Thanks, finally applied it on dpdk-next-virtio tree as per Thomas' request.