From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD40AA04DD; Tue, 26 Nov 2019 14:15:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0569D2B88; Tue, 26 Nov 2019 14:15:50 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BF775CF3 for ; Tue, 26 Nov 2019 14:15:48 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Nov 2019 05:15:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,245,1571727600"; d="scan'208";a="359160480" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.96]) ([10.237.221.96]) by orsmga004.jf.intel.com with ESMTP; 26 Nov 2019 05:15:45 -0800 To: Dekel Peled , Matan Azrad , Shahaf Shuler , Slava Ovsiienko Cc: Ori Kam , "dev@dpdk.org" References: <9f9d216b-d8a2-302b-db8e-030782798586@intel.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <8b63801d-6774-f9f0-f19a-c85ffbabf152@intel.com> Date: Tue, 26 Nov 2019 13:15:45 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix flow engine select by rdma-core ver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/26/2019 12:48 PM, Dekel Peled wrote: > Thanks, PSB > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Tuesday, November 26, 2019 1:29 PM >> To: Dekel Peled ; Matan Azrad >> ; Shahaf Shuler ; Slava >> Ovsiienko >> Cc: Ori Kam ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix flow engine select by rdma- >> core ver >> >> On 11/26/2019 8:34 AM, Dekel Peled wrote: >>> Recent patch [1] sets the DV (Direct Verbs) flow engine as default. >>> Newer versions of DV flow engine use the DR (Direct Rules) features. >>> DR is supported from RDMA Core library version rdma-core-24.0. >>> This cause failure to start port when using older rdma-core version, >>> without DR support. >>> >>> This patch selects DV flow engine if rdma-core version is v24.0 or >>> higher. Verbs flow engine is selected otherwise. >>> >>> [1] >>> >> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch >>> >> es.dpdk.org%2Fpatch%2F61900%2F&data=02%7C01%7Cdekelp%40mell >> anox.co >>> >> m%7C38999818be02482ca83608d77263e1f3%7Ca652971c7d2e4d9ba6a4d1492 >> 56f461 >>> >> b%7C0%7C0%7C637103645640442451&sdata=wytpQti4UM8l2xMxWRNl >> mx0oxnrxv >>> o2vWG6gwN8iAo8%3D&reserved=0 >> >> Can you please add reference to the git commit instead of the patchwork, >> and I assume the commit is the one ins the fixes line, so why to add >> additional patchwork link too? >> > > I accept, the reference is redundant and can be removed. > Should I send v2? or can you remove it when taking the patch? I updated in next-net, thanks. > >>> >>> Fixes: cd4569d2bf3c ("net/mlx5: change default flow engine to DV") >>> >>> Signed-off-by: Dekel Peled >>> Acked-by: Ori Kam >>> --- >>> doc/guides/nics/mlx5.rst | 2 +- >>> doc/guides/rel_notes/release_19_11.rst | 3 +++ >>> drivers/net/mlx5/mlx5.c | 2 +- >>> 3 files changed, 5 insertions(+), 2 deletions(-) >>> >>> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index >>> 2080766..771970f 100644 >>> --- a/doc/guides/nics/mlx5.rst >>> +++ b/doc/guides/nics/mlx5.rst >>> @@ -673,7 +673,7 @@ Run-time configuration >>> - ``dv_flow_en`` parameter [int] >>> >>> A nonzero value enables the DV flow steering assuming it is >>> supported >>> - by the driver. >>> + by the driver (RDMA Core library version is rdma-core-24.0 or higher). >>> >>> Enabled by default if supported. >>> >>> diff --git a/doc/guides/rel_notes/release_19_11.rst >>> b/doc/guides/rel_notes/release_19_11.rst >>> index 48c80e5..928698e 100644 >>> --- a/doc/guides/rel_notes/release_19_11.rst >>> +++ b/doc/guides/rel_notes/release_19_11.rst >>> @@ -193,6 +193,9 @@ New Features >>> * Added support for matching on packets withe Geneve tunnel header. >>> * Added hairpin support. >>> * Added ConnectX6-DX support. >>> + * Flow engine selected based on RDMA Core library version. >>> + DV flow engine selected if version is rdma-core-24.0 or higher. >>> + Verbs flow engine selected otherwise. >>> >>> * **Updated the AF_XDP PMD.** >>> >>> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index >>> 59ae408..8abd1b1 100644 >>> --- a/drivers/net/mlx5/mlx5.c >>> +++ b/drivers/net/mlx5/mlx5.c >>> @@ -2428,7 +2428,7 @@ struct mlx5_flow_id_pool * >>> !defined(HAVE_IBV_DEVICE_COUNTERS_SET_V45) >>> DRV_LOG(DEBUG, "counters are not supported"); #endif -#ifndef >>> HAVE_IBV_FLOW_DV_SUPPORT >>> +#if !defined(HAVE_IBV_FLOW_DV_SUPPORT) || >> !defined(HAVE_MLX5DV_DR) >>> if (config.dv_flow_en) { >>> DRV_LOG(WARNING, "DV flow is not supported"); >>> config.dv_flow_en = 0; >>> >